kpriv/pkgsrc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
pkgsrc/audio/id3/patches/patch-ab

16 lines
345 B
Text
Raw Normal View History

Add upstream bug report URL.
2016-08-24 12:01:21 +02:00
$NetBSD: patch-ab,v 1.3 2016/08/24 10:01:21 wiz Exp $
getopt.h is non-standard.
https://gitlab.com/ppentchev/id3/issues/1
Do not attempt to include the non-standard getopt.h, unistd.h should be sufficient. Remove an unnecessary install argument to allow this package to install unprivileged.
2003-12-23 19:11:19 +01:00
Updated id3 to 1.0.0. 1.0.0 ----- - Development taken over by Peter Pentchev. - Import a Debian patch by Stefan Ott <stefan@ott.net> to avoid backquotes in the usage string. - Import a Debian patch by Stefan Ott <stefan@ott.net> and Peter Pentchev to let the compiler and linker flags be overridden. - Let the install program and the strip flag also be overridden. - Check some more functions' return values for errors. - Add some preprocessor and compiler flags to specify certain POSIX and C environment standards. - Reorder the #include statements. - Also include <strings.h> for strncasecmp(). - Mark the list of genres in genre.h as "const char". - Add a lot of GCC-specific compiler warning flags. - Use the err(3) and warn(3) functions, they're portable enough. - Mark several global variables as static. - Break the display of the ID3 tags out into a separate function. - Use "return" from main(), remove unreachable "break" statements. - Avoid possible out-of-bound copying when storing command-line arguments into the new tag structure. - Expect a C99 compiler and reduce the scope of some variables. - Use the C99 "bool" type for, well, boolean flags. - Convert the id3.1 manual page to the mdoc format. - Fix the fields length in the manual page - only the comment is limited to 28 characters, the rest of the text fields are at 30. - Use the more common "file..." instead of "file1 [file2 [file3...]]" - Fill in some commonly-used manual page sections. - Validate number-to-string conversions for the genre and track number. - Fix a signedness error in the track number display.
2016-08-24 11:59:31 +02:00
--- id3.c.orig 2016-08-13 22:39:26.000000000 +0000
+++ id3.c
@@ -18,7 +18,6 @@
#include <ctype.h>
#include <err.h>
Do not attempt to include the non-standard getopt.h, unistd.h should be sufficient. Remove an unnecessary install argument to allow this package to install unprivileged.
2003-12-23 19:11:19 +01:00
#include <errno.h>
Updated id3 to 1.0.0. 1.0.0 ----- - Development taken over by Peter Pentchev. - Import a Debian patch by Stefan Ott <stefan@ott.net> to avoid backquotes in the usage string. - Import a Debian patch by Stefan Ott <stefan@ott.net> and Peter Pentchev to let the compiler and linker flags be overridden. - Let the install program and the strip flag also be overridden. - Check some more functions' return values for errors. - Add some preprocessor and compiler flags to specify certain POSIX and C environment standards. - Reorder the #include statements. - Also include <strings.h> for strncasecmp(). - Mark the list of genres in genre.h as "const char". - Add a lot of GCC-specific compiler warning flags. - Use the err(3) and warn(3) functions, they're portable enough. - Mark several global variables as static. - Break the display of the ID3 tags out into a separate function. - Use "return" from main(), remove unreachable "break" statements. - Avoid possible out-of-bound copying when storing command-line arguments into the new tag structure. - Expect a C99 compiler and reduce the scope of some variables. - Use the C99 "bool" type for, well, boolean flags. - Convert the id3.1 manual page to the mdoc format. - Fix the fields length in the manual page - only the comment is limited to 28 characters, the rest of the text fields are at 30. - Use the more common "file..." instead of "file1 [file2 [file3...]]" - Fill in some commonly-used manual page sections. - Validate number-to-string conversions for the genre and track number. - Fix a signedness error in the track number display.
2016-08-24 11:59:31 +02:00
-#include <getopt.h>
#include <limits.h>
#include <stdbool.h>
#include <stdio.h>
Reference in a new issue Copy permalink