kpriv/pkgsrc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Implement a fix for the security vulnerability reported in

Browse source 
<http://seclists.org/fulldisclosure/2008/May/0488.html>.
This commit is contained in:
tron 2008-05-22 12:10:49 +00:00
parent bcfbe6ecef
commit 11ac3fc8aa
3 changed files with 49 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
net/mtr/Makefile
View file

@ -1,6 +1,7 @@
# $NetBSD: Makefile,v 1.48 2007/08/16 23:12:20 joerg Exp $
# $NetBSD: Makefile,v 1.49 2008/05/22 12:10:49 tron Exp $
DISTNAME= mtr-0.72
PKGREVISION= 1
CATEGORIES= net
MASTER_SITES= ftp://ftp.bitwizard.nl/mtr/

3
net/mtr/distinfo
View file

@ -1,7 +1,8 @@
$NetBSD: distinfo,v 1.22 2006/10/03 19:15:20 wiz Exp $
$NetBSD: distinfo,v 1.23 2008/05/22 12:10:49 tron Exp $
SHA1 (mtr-0.72.tar.gz) = afc26c9e8a30eba7ca92ba68d4489b0c9c07977d
RMD160 (mtr-0.72.tar.gz) = 69843b82fb2de2b2a597c21a62d8eb9473df31b6
Size (mtr-0.72.tar.gz) = 295845 bytes
SHA1 (patch-aa) = 3db4ccac08fadcf2fcf75753efc165c6d92a97c3
SHA1 (patch-ab) = 3923fcd252bdcd9475e937fb78d1d7e5ec607180
SHA1 (patch-ac) = a34b91ff6ff7a89bea4fc8b262d7604017ff6fad

45
net/mtr/patches/patch-ac Normal file
View file

@ -0,0 +1,45 @@
$NetBSD: patch-ac,v 1.3 2008/05/22 12:10:49 tron Exp $
--- split.c.orig 2005-01-11 08:34:07.000000000 +0000
+++ split.c 2008-05-22 13:07:48.000000000 +0100
@@ -100,24 +100,28 @@
addr = net_addr(at);
if( addrcmp( (void *) addr, (void *) &unspec_addr, af ) != 0 ) {
+ int bytes;
name = dns_lookup(addr);
if(name != NULL) {
/* May be we should test name's length */
- sprintf(newLine, "%s %d %d %d %d %d %d", name,
- net_loss(at),
- net_returned(at), net_xmit(at),
- net_best(at) /1000, net_avg(at)/1000,
- net_worst(at)/1000);
+ bytes = snprintf(newLine, sizeof(newLine), "%s %d %d %d %d %d %d",
+ name,
+ net_loss(at),
+ net_returned(at), net_xmit(at),
+ net_best(at) /1000, net_avg(at)/1000,
+ net_worst(at)/1000);
} else {
- sprintf(newLine, "%s %d %d %d %d %d %d",
- strlongip( addr ),
- net_loss(at),
- net_returned(at), net_xmit(at),
- net_best(at) /1000, net_avg(at)/1000,
- net_worst(at)/1000);
+ bytes = snprintf(newLine, sizeof(newLine), "%s %d %d %d %d %d %d",
+ strlongip( addr ),
+ net_loss(at),
+ net_returned(at), net_xmit(at),
+ net_best(at) /1000, net_avg(at)/1000,
+ net_worst(at)/1000);
}
+ if (bytes < 0 || bytes >= sizeof(newLine))
+ strcpy(newLine, "???");
} else {
- sprintf(newLine, "???");
+ strcpy(newLine, "???");
}
if (strcmp(newLine, Lines[at]) == 0) {