easytag: update to 2.4.3

pkgsrc changes
--------------
* add option for doc (Yelp is required at runtime for user help)
* add option for manual
* update PLIST

upstream changes
----------------
commit effffadf1472a55ef6470f2b1763eefeef7c3b71
Date:	Mon Dec 5 19:21:36 2016 +0000
    Update Windows installer for latest Fedora MinGW
    Drop Pango modules, add additional libraries.

commit 466181aa708d9cfee3682ba2d5a35f455e32b0bb
Date:	Sat Dec 3 09:51:15 2016 +0000
    Support MP4 files with the AAC file extension
    https://bugzilla.gnome.org/show_bug.cgi?id=775559

commit 2e34e40b9041ac9e7f2d2c0555a342a2097e3634
Date:	Wed Nov 16 20:17:17 2016 +0000
    Fix user directory constant in Windows installer
    Use the syntax for a constant, not a variable.

commit 9866e92a905d085758532735cfb1f8928a9c3b39
Date:	Wed Nov 16 20:16:22 2016 +0000
    Fix help action on Windows

commit 397ce70660c38c2e679faa4a4ffdf9feb9e796d6
Date:	Mon Nov 14 23:33:38 2016 +0000
    Fix initial state of ID3v2 character set radio
    Bind the id3v2-enable-unicode setting to the secondary radio button in
    the group, to ensure that the state is restored correctly when the
    preferences dialogue is first displayed.

commit 756412dcfee019a46b3f13e34cef362295324397
Date:	Fri Nov 11 18:36:45 2016 +0000
    Use ID3V1_TAG_SIZE define consistently

commit 8a96195566b8a03de9c2b3fa82a27ceeeba6e6a6
Date:	Thu Nov 10 16:28:35 2016 +0000
    Add a comment to clarify ID3 APIC descriptions

commit 5d4b94caf2639cf78d38a915b3bc2ea76426e24e
Date:	Thu Nov 10 16:27:20 2016 +0000
    Improve check for numeric genres in ID3 tags
    Check that the string between two brackets in an ID3v1-compatible
    genre field is numeric.

commit e5c640ca3f259f1b74e716723345521987a7bd68
Date:	Wed Nov 9 17:29:34 2016 +0000
    Do not maintain an open handle on Ogg files
    Only keep a file open for reading long enough to read the necessary
    items from the file. Remove the file input stream from EtOggState, as
    it is no longer preserved across function calls.

commit 2576fbaf7edbfdb60d25692c7c3407f36751fe68
Date:	Wed Nov 9 16:22:37 2016 +0000
    Fix Ogg tag writing on Windows
    Under Windows, if a file is opened for reading, it cannot be opened a
    second time for writing. The Vorbis comment code keeps the file open
    for reading throughout the process of writing new tags, mostly because
    the audio stream must be read into memory before being written out
    after the new tags. Avoid the problem by closing the input stream only
    during the writing process, and at all other times maintaining a
    consistent state, with the input stream open.
    https://mail.gnome.org/archives/easytag-list/2016-November/msg00000.html

commit 8dd7eb0dcc911b7c150c8939ff036cb9ff3fddde
Date:	Tue Nov 8 08:29:21 2016 +0000
    Fix label for remove spaces during rename option
    The label was accidentally set as "No conversion", when it should have
    been "Remove spaces".
    https://bugzilla.gnome.org/show_bug.cgi?id=773476

commit acc9db6ed544a2bb1b66d955adadfccbca3ae092
Date:	Tue Oct 25 22:26:25 2016 +0100
    Fix saving of ID3v1 genre when also using ID3v2.4
    When writing ID3v2.4 tags using libid3tag and the
    id3v2-text-only-genre
    setting is disabled, ensure that only the ID3v2 genre field is
    converted to the bracketed form, so that valid genres are assigned to
    the ID3v1 genre field.
    https://bugzilla.gnome.org/show_bug.cgi?id=773443

commit 03cce6dbc403e45d6a27da68dbc3f1591eb4a4ab
Date:	Sat Nov 5 21:09:43 2016 +0000
    Add an ID3 genre number test
    Test that the expected genre IDs convert to appropriate strings (not
    the "Unknown" placeholder), that the index of the final expected genre
    is correct and finally that all unexpected genres are reported as
    "Unknown".

commit 9bd38070aed2133380f124ab3469772e8ea7c1f2
Date:	Fri Oct 7 07:06:54 2016 +0000
    Update Chinese (Taiwan) translation

commit 78213d225ba1c7632129dfe3027d274cacb5a374
Date:	Sun Oct 2 21:07:11 2016 +0000
    Updated Croatian translation

commit c73212ca65381c1ab86c5b825ff8bd9af92b2831
Date:	Sat Oct 1 10:20:16 2016 +0000
    Updated Croatian translation

commit aa5157c6eeb423c33c9b29321b28b375e5b247bf
Date:	Fri Sep 30 21:55:47 2016 +0000
    Updated Croatian translation

commit 914b8a54575c2e15d86be1c380a708314ac0e83f
Date:	Fri Sep 30 19:14:40 2016 +0000
    Updated Croatian translation
    (cherry picked from commit 3c078f7ea98e040296b18a5b8c6daac45e675826)

commit 5cc5f9bc1fa1a2b4cf887bba36c347110ef81ced
Date:	Fri Sep 30 14:23:56 2016 +0000
    Added Croatian translation
    (cherry picked from commit e49cfc61cf1341b9918221deccfdc4856316febf)

commit f63b92f0fe4260cacb49cbba914163fe11800d79
Date:	Sun Sep 25 22:09:46 2016 +0000
    Updated Swedish translation

commit c4b2ae53dce7847b7051bf4def0a1eca03ce4ec0
Date:	Mon Sep 19 22:25:10 2016 +0200
    Update Catalan translation

commit 244e6229ad90679af351faac43833df3ad98c44b
Date:	Tue Sep 13 20:14:33 2016 +0200
    Updated Spanish translation

commit 03d2a4fc7993f8d55cd2301be69587dbdd889edc
Date:	Wed Sep 7 04:49:56 2016 +0200
    Updated Polish translation

commit a3a75ad8f815cd5c68326421de6016cfd705a80d
Date:	Tue Sep 6 08:09:08 2016 +0200
    Upload Catalan translation

commit a2ac2a7216412417b31b6e297fae3fdd880083a2
Date:	Thu Aug 25 18:02:24 2016 +0000
    Updated French translation

commit 9d08aa809821ebd27d6a4dcc75cba547d3c4b5fb
Date:	Fri Aug 19 19:51:31 2016 +0000
    Updated Hungarian translation

commit 3102e5b5a834cfdc6edc72f5a6d23c0c91f98d0d
Date:	Fri Aug 19 18:06:26 2016 +0200
    Updated Polish translation

commit 13134323c7d9cade4c71f19564d2eb255486293f
Date:	Sun Aug 14 17:15:22 2016 +0000
    Updated Romanian translation

commit cddf65049d75deb13cbbf89fc617d1908284f0ca
Date:	Wed Aug 3 14:42:35 2016 +0200
    Use AM_DISTCHECK_CONFIGURE_FLAGS
    DISTCHECK_CONFIGURE_FLAGS is for users and packagers to override
    distcheck options, while AM_DISTCHECK_CONFIGURE_FLAGS is for the
    maintainer of the software.
    https://www.gnu.org/software/automake/manual/automake.html#DISTCHECK_005fCONFIGURE_005fFLAGS

commit 529a1055a25549b52acadc86101eb9c30c5fd8aa
Date:	Sat Jul 16 22:32:23 2016 +0100
    Fix return type of Cddb_Get_Album_Tracks_List_CB()
    The changed signal of GtkTreeSelection has a return type of void.

commit 833798088681db64cc0fce642534ee38090646a7
Date:	Fri Jul 15 19:09:10 2016 +0200
    Add Language headers to po files
    Future versions of gettext will fail if this header is missing.

commit b7eafda2bb62ea2da51286477c92bd1f748b22ec
Date:	Thu Jul 14 08:42:28 2016 +0100
    Add a TODO item about custom themed icons

commit bb66d4788e4b044cf10035a8c80ba2d580f7a51e
Date:	Thu Jul 14 08:37:59 2016 +0100
    Add artist and artist/album icons in Adwaita style

commit 2d327d1b4b8ec9e5c6f65965949925fa8e3c8154
Date:	Thu Jul 14 08:27:36 2016 +0100
    Use correct icon for artist/album toolber button

commit 868e1ea6cf8e6d5b544e7a144aca99b989840937
Date:	Thu Jul 14 02:43:09 2016 +0800
    Allow running autogen.sh in non-srcdir
    https://bugzilla.gnome.org/show_bug.cgi?id=768784

commit 3a4a357ff27f059ea9836bf28db6961c7e25cf11
Date:	Wed Jul 6 16:48:16 2016 +0100
    Ensure that a newly-selected path is visible
    When a path is selected programatically, such as when loading the
    initial path
    on startup, make sure that the path is visible by first scrolling
    the view to
    the path and then selecting it.
    https://bugzilla.gnome.org/show_bug.cgi?id=768470

commit 954d43d50ef4477c3648153580ea72daf540e612
Date:	Thu Mar 10 21:00:14 2016 +0000
    Replace a further use of strcasecmp()
    Ignore the locale when comparing CDDB genres.

commit 1836dea1617f55fc0b12c6b3f09e96bd91f8287e
Date:	Mon Jun 27 20:24:48 2016 +0100
    Refactor Cddb_Track_List_Row_Selected()
    Reduce scope of some variables and improve spacing.

commit cafc9ffc8832ca1826ed986702851eb23050b73c
Date:	Mon Jun 27 17:53:36 2016 +0100
    Automatically match unselected CDDB results
    In the case that a CDDB result for an individual track does not
    have an
    associated file, match up the file against the current browser
    selection.
    https://bugzilla.gnome.org/show_bug.cgi?id=766499

commit 7d545a37dccc1ee33240e233d0849144f112073d
Date:	Mon Jun 27 17:31:45 2016 +0100
    Reduce code duplication when applying CDDB results
    The code to update the contents of the ET_File in the DLM and non-DLM
    cases was identical, so factor it out to a new
    set_et_file_from_cddb_album() function. As a side effect, avoid
    a crash
    when applying results from CDDB searches.
    https://bugzilla.gnome.org/show_bug.cgi?id=766499

commit 953914f2c31f38107019d7beb3d05342b0df706d
Date:	Tue Jun 7 08:56:01 2016 +0100
    Refactor and rename ET_File_Name_Generate()
    Rename ET_File_Name_Generate() to et_file_generate_name(). Use
    g_return_val_if_fail() for invariant checks.

commit f144e6a0cdfae35a4e3f5034b229174fa16ed1a5
Date:	Tue Jun 7 05:51:27 2016 +0100
    Avoid crash when saving audioless ID3v2.4 tags
    In the case where an ID3v2.4 tag was written that differed in size to
    the previous tag, audio was assumed to exist after the tag. This
    assumption failed if the file consisted solely of the ID3 tag and
    nothing else. Avoid the crash by skipping the audio reading and
    writing
    if there is none to copy.
    https://mail.gnome.org/archives/easytag-list/2016-June/msg00002.html

commit b99d6c73f170524aec7f175c6f278b72639ff3bd
Date:	Wed May 25 20:53:54 2016 +0200
    Improve const use in FLAC and Ogg tagging

commit a67b2fa023ce32686d9e57870de44c3986a601b7
Date:	Mon May 23 17:35:43 2016 +0100
    Refactor and rename ET_Check_If_File_Is_Saved()
    Avoid comparing directly against TRUE or FALSE. Rename to
    et_file_check_saved().

commit 9be88c3aafaae47ce31dc62e76629f74ef5fbdfc
Date:	Mon May 23 17:31:11 2016 +0100
    Refactor on_picture_add_button_clicked()
    Avoid a crash when unselecting all files and clicking on the add
    images
    button.  Use the GLib filename encoding when setting the current path
    of the add images dialog. Simplify several checks for the
    currently-selected file.
    https://retrace.fedoraproject.org/faf/reports/843689/

commit ddd6fa206e15e0ffd59dc3afb3adc3a81cb885b3
Date:	Sun May 8 11:00:37 2016 +0100
    Explicitly mark the GSettings schema for intltool
    As recommended in the GSettings documentation.

commit 48958f45f3290b23fbfbe28e9b2e205f3f4b0d3f
Date:	Sun May 8 11:00:19 2016 +0100
    Add gettext-domain to GSettings schema

commit 5182edd12d4286fa341dc29facb4fb817328ad11
Date:	Wed May 4 18:33:11 2016 +0000
    Updated Portuguese translation

commit 3b4766f81173eb3bf3b416295ae4984572d8e06e
Date:	Wed Apr 27 17:22:43 2016 +0200
    Improve MP4 album artist support with newer TagLib
    TagLib 1.10 and above supports the album artist field directly,
    without
    the need to manually retrive the atom. Use this support if building
    against a suitable TagLib version.

commit ac666308a91a4cd83855671556322765653ff0f9
Date:	Wed Apr 27 09:07:03 2016 +0200
    Use et_str_empty() when writing MP4 tag fields
    Simplify the logic for checking if a tag field is empty.

commit dfb03abb2c5dd129e67e732139aa121384b6d7cc
Date:	Tue Apr 26 22:06:46 2016 +0100
    Improve MP4 empty field handling
    Do not copy fields which are empty, as this always results in the file
    being marked as requiring saving.
    https://bugzilla.gnome.org/show_bug.cgi?id=765385

commit 6aecd7451e3889c5f755736b427a478c93e9f5b2
Date:	Fri Apr 22 15:48:18 2016 +0530
    Fix undefined symbol when id3lib is not available

commit 9f5c5819f8d6dbf5b8b107064d1f0658114a95a9
Date:	Fri Mar 25 20:03:24 2016 +0000
    README schema error documentation and examples
    In the event of a schema failure (EasyTAG schema not in cache
    results in
    assert crash otherwise) - so this is which files need to be in the
    system schema cache, and how to add them in to it.
    https://bugzilla.gnome.org/show_bug.cgi?id=764207

commit f25a76ce6943502436e66551d8b80c8ef682db29
Date:	Wed Mar 23 09:07:49 2016 +0000
    Updated Spanish translation

commit bf444c94da12a57928c5d0b480ef50a884a6d998
Date:	Tue Mar 22 11:25:34 2016 +0000
    Updated Spanish translation

commit 55ef17463570bccd1c10d3b7fdfabf1e578d340b
Date:	Mon Mar 21 16:19:40 2016 +0000
    Updated Spanish translation

commit c3aeb58c98710e86f1b04cd66ee980aae185eb90
Date:	Fri Mar 18 09:03:10 2016 +0000
    Updated Spanish translation

commit 9f40d46193d7666a76a8cae0e835e4cedb56e8d8
Date:	Thu Mar 17 10:23:46 2016 +0000
    Updated Spanish translation

commit 3cc462ce2c122d981d9f3eb492de65871aff5b8b
Date:	Tue Mar 15 15:56:10 2016 +0000
    Fix FLAC build when Ogg support is disabled
    Move the defines for the Vorbis comment field names to be outside the
    ENABLE_OGG checks, and eanble them at all times.
    https://bugs.gentoo.org/show_bug.cgi?id=576490

commit c985c83e70bb28f8dfb0b000f0a466a7cca7ebec
Date:	Sun Mar 13 09:20:57 2016 +0000
    Updated Occitan translation

commit 04c7e16f994fdad2c04e630442b9e3f1cc31378f
Date:	Sun Mar 13 09:03:43 2016 +0000
    Added Occitan translation

commit 4503eff78c7798fae7dd1f4abe67cda5297f279f
Date:	Sat Mar 5 22:38:24 2016 +0000
    Fix possible overflow of reads in the file list
    When checking whether to read the file list on startup, use a
    gboolean rather
    than an int.

commit 2437156f61115e1995c1ecc07133acf1d37c66a6
Date:	Wed Mar 2 08:13:41 2016 +0000
    Mention use of C89 comment style in HACKING

commit fe5e205d9d05bdac737873da14f9f5709b9bcb23
Date:	Tue Mar 1 16:36:53 2016 +0000
    Fix a bogus check when reading Ogg tags
    Avoid a duplicated check for description tags inside a Vorbis comment
    of an Ogg
    file.

commit 3dbfd06126c259d163541b2b49d937df3692266d
Date:	Sun Feb 28 22:02:17 2016 +0000
    Open the online help if Yelp is not installed
    If Yelp is not installed, or fails to start, show the online help
    instead.
    https://mail.gnome.org/archives/easytag-list/2016-February/msg00009.html

commit 4df33c1f7b719ea59d9a054b009ec2217b261b8b
Date:	Sun Feb 28 21:35:02 2016 +0000
    Document that Yelp is required at runtime
    Warn during configure if yelp is not found in the path.
    https://mail.gnome.org/archives/easytag-list/2016-February/msg00009.html

commit 543b1f071dc82848e8819c68b19d4ed5d2395abc
Date:	Sun Feb 28 08:46:16 2016 +0000
    Avoid another crash in the load filenames dialog
    Make the reload action insensitive when no file is selected.

commit 53c9b955aee4aa4f41510e6fe6b78597257fa110
Date:	Fri Feb 26 17:27:05 2016 +0000
    Fix a crash when loading filenames from a file
    Swap the arguments of the callbacks for the reload signals.
    https://bugzilla.redhat.com/show_bug.cgi?id=1312163

commit dc471e9ddd4025750bf6b9b30cf4adff81e949bb
Date:	Wed Feb 24 10:11:03 2016 +0000
    Updated Brazilian Portuguese translation

audio/easytag/Makefile

@@ -1,7 +1,6 @@
-# $NetBSD: Makefile,v 1.108 2018/11/14 22:21:01 kleink Exp $
+# $NetBSD: Makefile,v 1.109 2019/06/21 06:25:58 triaxx Exp $
 
-DISTNAME=	easytag-2.4.2
-PKGREVISION=	8
+DISTNAME=	easytag-2.4.3
 CATEGORIES=	audio
 MASTER_SITES=	${MASTER_SITE_GNOME:=sources/easytag/2.4/}
 EXTRACT_SUFX=	.tar.xz

audio/easytag/PLIST

@@ -1,5 +1,6 @@
-@comment $NetBSD: PLIST,v 1.23 2016/03/07 20:56:39 nros Exp $
+@comment $NetBSD: PLIST,v 1.24 2019/06/21 06:25:58 triaxx Exp $
 bin/easytag
+man/man1/easytag.1
 share/appdata/easytag.appdata.xml
 share/applications/easytag.desktop
 share/glib-2.0/schemas/org.gnome.EasyTAG.enums.xml
@@ -205,6 +206,7 @@ share/locale/en_GB/LC_MESSAGES/easytag.mo
 share/locale/es/LC_MESSAGES/easytag.mo
 share/locale/fr/LC_MESSAGES/easytag.mo
 share/locale/he/LC_MESSAGES/easytag.mo
+share/locale/hr/LC_MESSAGES/easytag.mo
 share/locale/hu/LC_MESSAGES/easytag.mo
 share/locale/id/LC_MESSAGES/easytag.mo
 share/locale/it/LC_MESSAGES/easytag.mo
@@ -213,6 +215,7 @@ share/locale/ko/LC_MESSAGES/easytag.mo
 share/locale/lt/LC_MESSAGES/easytag.mo
 share/locale/nb/LC_MESSAGES/easytag.mo
 share/locale/nl/LC_MESSAGES/easytag.mo
+share/locale/oc/LC_MESSAGES/easytag.mo
 share/locale/pl/LC_MESSAGES/easytag.mo
 share/locale/pt/LC_MESSAGES/easytag.mo
 share/locale/pt_BR/LC_MESSAGES/easytag.mo

audio/easytag/distinfo

@@ -1,6 +1,6 @@
-$NetBSD: distinfo,v 1.43 2016/03/07 20:56:39 nros Exp $
+$NetBSD: distinfo,v 1.44 2019/06/21 06:25:58 triaxx Exp $
 
-SHA1 (easytag-2.4.2.tar.xz) = 40a86f070960244aa9b24457884d14c928c9bb11
-RMD160 (easytag-2.4.2.tar.xz) = af521a740302d54d2406506c07aa60c801988119
-SHA512 (easytag-2.4.2.tar.xz) = 8aa50a430249fe5d99b6fa06890dae7a946c65bae22a97a4ee9bd9984412a1a85479de86d8251796a926d54f4e1be5bffb0f532dd44bfb2d4613486767114784
-Size (easytag-2.4.2.tar.xz) = 1362768 bytes
+SHA1 (easytag-2.4.3.tar.xz) = eb8196fe699543776e632de4c3931f88fb82aaa4
+RMD160 (easytag-2.4.3.tar.xz) = fb5684d904efeb8902bf4ec212f75cbba5e77dd1
+SHA512 (easytag-2.4.3.tar.xz) = ef596341772ce7da3b7feec2c82a20ca29d25c2496074c469be5b8dd75d2b2718e689310e0d61de53bc29a4f54ce9f853a336e1a35076046fd107afd28699087
+Size (easytag-2.4.3.tar.xz) = 1381084 bytes

audio/easytag/options.mk

@@ -1,11 +1,15 @@
-# $NetBSD: options.mk,v 1.8 2014/04/12 06:45:31 wiz Exp $
+# $NetBSD: options.mk,v 1.9 2019/06/21 06:25:58 triaxx Exp $
 
 PKG_OPTIONS_VAR=	PKG_OPTIONS.easytag
-PKG_SUPPORTED_OPTIONS=	flac ogg opus speex wavpack
-PKG_SUGGESTED_OPTIONS=	flac ogg opus speex wavpack
+PKG_SUPPORTED_OPTIONS=	doc flac manual ogg opus speex wavpack
+PKG_SUGGESTED_OPTIONS=	doc flac manual ogg opus speex wavpack
 
 .include "../../mk/bsd.options.mk"
 
+.if !empty(PKG_OPTIONS:Mdoc)
+DEPENDS+=		yelp-[0-9]*:../../misc/yelp3
+.endif
+
 .if !empty(PKG_OPTIONS:Mflac)
 .  include "../../audio/flac/buildlink3.mk"
 .  include "../../audio/libvorbis/buildlink3.mk"
@@ -14,6 +18,15 @@ CONFIGURE_ARGS+=	--enable-flac
 CONFIGURE_ARGS+=	--disable-flac
 .endif
 
+.if !empty(PKG_OPTIONS:Mmanual)
+BUILD_DEPENDS+=		libxslt-[0-9]*:../../textproc/libxslt
+BUILD_DEPENDS+=		docbook-xsl-[0-9]*:../../textproc/docbook-xsl
+CONFIGURE_ARGS+=	--with-xml-catalog=${PKG_SYSCONFDIR}/xml/catalog
+CONFIGURE_ARGS+=	--enable-man
+.else
+CONFIGURE_ARGS+=	--disable-man
+.endif
+
 .if !empty(PKG_OPTIONS:Mogg)
 .  include "../../audio/libvorbis/buildlink3.mk"
 CONFIGURE_ARGS+=	--enable-ogg