kpriv/pkgsrc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

In a recent thread [1], the value of including USE_CMAKE=yes in the file

Browse source 
meta-pkgs/kde4/kde4.mk was discussed.  The conclusion was that it did
make sense to include that definition because kde4.mk is included by
packages that use the kde4 configure and build system, which is cmake.
Thus, they will need to define USE_CMAKE anyway and currently must do
so in addition to including kde4.mk.  This adds the needed definition
so that it is no longer necessary to do both things.

Many other packages currently include kde4.mk and also define USE_CMAKE.
In many cases they also define CMAKE_ARGS.  To avoid potential confusion
centering around wondering whether or not USE_CMAKE was forgotten (e.g.,
if readers do not know it is now defined in kde4.mk), the definition was
not removed from those packages.

Future package authors can determine whether or not it is clearer to
include the definition even though kde4.mk is also included.

[1] http://mail-index.netbsd.org/tech-pkg/2011/08/28/msg007595.html
This commit is contained in:
brook 2011-08-31 19:40:43 +00:00
parent c102109317
commit 828fd6c882
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
meta-pkgs/kde4/kde4.mk
View file

@ -1,4 +1,4 @@
# $NetBSD: kde4.mk,v 1.2 2010/04/10 02:45:03 markd Exp $
# $NetBSD: kde4.mk,v 1.3 2011/08/31 19:40:43 brook Exp $
#
# This Makefile fragment is included by packages that use the KDE4
# configure-and-build process.
@ -9,6 +9,7 @@ KDE4_MK= # defined
USE_PKGLOCALEDIR= YES
USE_CMAKE= yes
CMAKE_ARGS+= -DHTML_INSTALL_DIR=${PREFIX}/share/doc/kde/HTML
CMAKE_ARGS+= -DDATA_INSTALL_DIR=${PREFIX}/share/kde/apps
CMAKE_ARGS+= -DCONFIG_INSTALL_DIR=${PREFIX}/share/kde/config