kpriv/pkgsrc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Shell comments may be hidden using @, as they have no side effects.

Browse source
This commit is contained in:
rillig 2009-05-26 21:40:42 +00:00
parent c276552f70
commit f60a2d91d1
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkgtools/pkglint/files/pkglint.pl
View file

@ -1,5 +1,5 @@
#! @PERL@
# $NetBSD: pkglint.pl,v 1.811 2009/04/26 16:08:40 rillig Exp $
# $NetBSD: pkglint.pl,v 1.812 2009/05/26 21:40:42 rillig Exp $
#
# pkglint - static analyzer and checker for pkgsrc packages
@ -4377,7 +4377,7 @@ sub checkline_mk_shelltext($$) {
$set_e_mode = false;
if ($rest =~ s/^\s*([-@]*)(\$\{_PKG_SILENT\}\$\{_PKG_DEBUG\}|\${RUN}|)//) {
if ($rest =~ s/^\s*([-@]*)(\$\{_PKG_SILENT\}\$\{_PKG_DEBUG\}|\$\{RUN\}|)//) {
my ($hidden, $macro) = ($1, $2);
if ($hidden !~ m"\@") {
@ -4386,6 +4386,9 @@ sub checkline_mk_shelltext($$) {
} elsif (defined($mkctx_target) && $mkctx_target =~ m"^(?:show-.*|.*-message)$") {
# In some targets commands may be hidden.
} elsif ($rest =~ m"^#") {
# Shell comments may be hidden, as they have no side effects
} elsif ($rest =~ $regex_shellword) {
my ($cmd) = ($1);