Commit graph

2187 commits

Author SHA1 Message Date
rillig
972b1c15e8 - Made the parser for distinfo files stricter. It can catch mismatched
filenames now.
- MD5 checksums are marked as deprecated.
- Warnings from distinfo files now appear correctly sorted.
2006-01-23 01:51:46 +00:00
rillig
f08ac4fcfb - Made -Wvarorder work like stated in the documentation. I had replaced the
wrong ``false'' with $opt_warn_varorder.
- Fixed the detection of $seen_Makefile_common.
2006-01-23 00:04:50 +00:00
rillig
bc1f74eace - Instead of only allowing the :Q modifier for quoting, allow any modifier
that ends in :Q.
- When NO_CONFIGURE ist defined, REPLACE_PERL does not work.
2006-01-22 23:35:04 +00:00
tron
393e2ba708 Update "rpm2pkg" package to version 2.1.1. Changes since 2.1:
- Fixed GCC 4.x build warning (which would have resulted in an error
  with future GCC versions).
- Depend on newer version of "rpm" package to fix build under Mac OS X.
2006-01-21 20:46:29 +00:00
jlam
758d912e33 Update package Makefile now that bsd.pkg.extract.mk is using the
"extract" script for extraction.  Many cases where a custom EXTRACT_CMD
simply copied the distfile into the work directory are no longer
needed.  The extract script also hides differences between pax and
tar behind a common command-line interface, so we no longer need code
that's conditional on whether EXTRACT_USING is tar or pax.
2006-01-21 18:57:40 +00:00
rillig
6abf92a1f4 Updated pkglint to 4.54.
Changes since 4.53:
- Added about 50 new variables to be type-checked.
- For unknown variables, the type is guessed from the variable name.
- In patch files that patch Makefiles, added lines are checked for
  absolute pathnames.
- Replaced the -Wdebug option with --debug, so that the debugging warnings
  don't show up when using -Wall.
- Many minor improvements.
2006-01-20 13:46:04 +00:00
rillig
46b20cd5dc - Added the -d|--debug command line option, which replaces -Wdebug. The
latter has been removed.
- Added -Wvarorder (default: disabled) to check the ordering of variables
  in simple packages.
- Using ${WRKSRC}/.. is only considered a warning, not an error, because
  there are packages that work nevertheless. Using this construct remains
  discouraged.
- Replaced most of the TODOs in the source code with code that prints
  a warning in --debug mode.
- The characters '.' and '+' are allowed in BuildlinkPackages.
- Variables *_FLAGS and *_ARGS that have their type guessed based on the
  name don't have to be assigned using the += operator.
- Variables that are assigned using the != operator are not checked for
  type compliance.
- README files are not marked as unknown when they appear in a package
  directory.
2006-01-20 13:33:37 +00:00
rillig
07a40aebce Setting BROKEN_GETTEXT_DETECTION to "no" really means "no", so allow it. 2006-01-20 13:03:10 +00:00
rillig
e6e1a0b8eb Despite its name, BUILTIN_FIND_FILES_VAR is a _list_ of variable names. 2006-01-20 12:35:51 +00:00
reed
6491d05a69 Add include/X11/XlibConf.h to xorg list. I noticed and added that
a few weeks ago when I was doing some builds using modular-xorg.
(Now that new Xorg is in, maybe there are some others to add?)

Update version.
2006-01-19 01:05:24 +00:00
rillig
de8b313520 - Added some more state transitions and warnings to the shellword parser.
It has come to the point where almost any further improvement means to
  adopt a real recursive parser.
2006-01-17 23:01:17 +00:00
rillig
97e5b5c2cd - In -Wextra mode, emit warnings if a "?=" operator occurs before
../../bsd.prefs.mk is included. (It is only shown in -Wextra mode
  because it is still quite unreliable.)
2006-01-16 01:37:39 +00:00
abs
59b795ff54 Update pkgtools/pkg_chk to 1.66
Fix incorrect quotation in test
2006-01-15 12:32:56 +00:00
rillig
d2bf446cb1 - Implemented a first prototype of the diagnostics with character-wise
precision in checkfile_patch for the warning for context diffs.
- The --source option produces more condensed output than before.
- The diagnostics with character-wise precision are colored using
  ANSI/VT100 color sequences. Support for other output formats will be
  added later.
2006-01-15 01:35:55 +00:00
rillig
76967e1b58 - The pkgdir variable is only defined when checking a pkgsrc package. For
other directories it is undefined. This avoids some false warnings when
  checking files in pkgsrc/mk/.
2006-01-14 11:56:09 +00:00
rillig
fa01b55c47 - Reduced the number of false warnings for relative directories. 2006-01-14 11:44:04 +00:00
rillig
03370d625a - Unquoted make variables in shell words can be fixed automatically. As
with the change from December 2005, when using this feature, care should
  be taken for variables that are pre-quoted.
- In patch files that patch Makefiles, added lines are checked for
  absolute pathnames.
2006-01-14 01:48:08 +00:00
rillig
a1ca3d5c5a Added LIBTOOL_OVERRIDE. 2006-01-13 00:59:39 +00:00
rillig
913ad8e379 - When guessing the type of variables, *_DIRS and *_FILES are both of the
type List of Pathmask.
2006-01-13 00:42:08 +00:00
rillig
59005a739b - Added about 50 variable types to makevars.map.
- Added some variable types.
- For unknown variables, the type is guessed from the variable name.
- Added more checks for relative pathnames.
- Improved the shell parser once more.
2006-01-12 22:28:06 +00:00
wiz
cf52b6b4c0 Bump date for some new features. 2006-01-12 21:50:43 +00:00
joerg
599b02b412 When creating the sorted list of binary packages, "ls -t *.tgz" can
easily overflow the argument space e.g. on DragonFly. Replace this
statement with "ls -t | grep '\.tgz$'" to remove this constraint.
2006-01-12 21:17:16 +00:00
joerg
ae610a4540 Add runtime dependency of xpkgwedge on imake and xmkmf.
When using non-native X11, xpkgwedge could be installed before imake
and host.def en up with just the xpkgwedge.def include. This means
that ProjectRoot as set by xorg's host.def is not used and wrong
path names are used. This run time dependency is the easiest way to
ensure proper order, but isn't perfect. Just providing a fixed host.def
and a secondary include file for Lesstif to modify breaks with
USE_XPKGWEDGE=NO, so keep the old approach.

Discussed with jlam@
2006-01-12 19:02:34 +00:00
rillig
16a2cd8def Updated pkglint to 4.53.
Changes since 4.52:
- New warning categories "debug", "space", "quoting" that can be selected
  independently.
- Improved the parsers for shell commands and shell words.
- Added warning for using $(...) in shell programs, as the Solaris /bin/sh
  doesn't support it.
- Added some warnings about quoting.
- Some other minor changes.
2006-01-12 14:05:50 +00:00
rillig
4eed0be377 Added APACHE_MODULE. 2006-01-12 13:59:42 +00:00
rillig
0740dd8c6c - Allow '^' to appear unquoted in shell programs, although it ``is an
obsolete synonym for the pipe operator "|", so you must protect it with
  quotes''. (Kernighan/Pike, The UNIX Programming Environment, 1984.)
- $@ is another well-known shell variable.
- All substitution arguments to ${SED} and ${PAX} should be quoted whether
  they contain special characters or not.
2006-01-12 13:51:54 +00:00
rillig
9af416c16b - The shell variables $!, $# and $? are recognized as such. All other
occurences of a $ in double quoted strings result in a warning.
2006-01-12 13:19:57 +00:00
rillig
c0fc81f666 - Improved the parsers for shell words and shell commands. Parsing errors
are only shown in -Wdebug mode, as the diagnostic messages are too
  cryptic.
- Added detection for the $(...) replacement for backticks, as the Solaris
  /bin/sh cannot handle them.
2006-01-12 13:01:47 +00:00
rillig
cb558f2a78 - Defining and using make variables starting with an underscore is only
worth a warning, not an error. There are worse things at the moment that
  need to be fixed.
2006-01-12 10:39:30 +00:00
rillig
4d9663f2a9 - Added three warning categories "debug", "quoting" and "space" that can
be enabled independently. They are all disabled by default.
- A note is emitted if variable definitions are aligned using space instead
  of tabs.
2006-01-12 10:32:40 +00:00
rillig
2ef3b243e0 - Added the package PkgLint::String, which will be used for improving the
precision of the diagnostics. It is currently unused.
2006-01-12 04:31:30 +00:00
rillig
e6e6cf9fb7 - Added plist-clash.pl to the list of files that have @PERL@ replaced. 2006-01-12 04:27:58 +00:00
rillig
fb188361c0 - In the shell command parser, go to state SCST_CONT instead of SCST_START
after parsing the command line options of ${INSTALL}.
- Don't warn for CFLAGS that reference other make variables.
2006-01-11 22:57:10 +00:00
rillig
4907cb1168 - In resolve_relative_path, the depth of the path should only be adjusted
in about half the cases -- added an additional parameter.
2006-01-11 12:25:19 +00:00
rillig
271edbd2ec Fixed spacing issue. 2006-01-11 11:42:27 +00:00
rillig
53e93b0ab9 - Renamed PkgLint::FileUtil::Line to PkgLint::Line in preparation to some
upcoming changes.
2006-01-11 04:29:12 +00:00
christos
cd18fc91dc Use ${ABI} for library files, patterned after what SGI does. This makes
X11 packages work on amd64 linux boxes. From Benjamin Shi.
2006-01-10 16:56:42 +00:00
rillig
2cd8334aa7 Updated pkglint to 4.52.
Changes since 4.51:
- The occurence of a symlink other than work* inside the pkgsrc tree is
  not an error, just a warning.
- SUBST_MESSAGE should not be quoted.
- If -Wextra is enabled, all make variables that are used in shell commands
  are checked for proper quoting.
- Improved the parser for shell commands.
- Some other minor changes.
2006-01-10 00:52:00 +00:00
rillig
c24a72897b Fixed the simple part of the pkglint -Wall warnings. 2006-01-09 23:39:55 +00:00
rillig
1d78045e51 - Even in an unquoted shell word, variables should be quoted. For example,
${PREFIX:Q}/foo.
- The semicolon after the "for" loop in the shell does not mean that some
  exitcode is ignored, so don't print warnings for it.
2006-01-09 23:14:45 +00:00
rillig
9bb9aae442 - Only check make variables for deprecation and $(...) instead of ${...}. 2006-01-09 03:22:45 +00:00
rillig
043613d277 - Added "Please use ${FOO} instead of $(FOO)."
- It is an error if the COMMENT has the default value from url2pkg.
2006-01-09 02:47:56 +00:00
joerg
a32d8f5c53 Unbreak by adding NO_BUILD=yes. 2006-01-08 21:00:22 +00:00
rillig
2464072040 - Rewrote the state transition of the shell command parser. The source
code now needs less lines than before. For unknown state/shellword
  combinations, warnings are printed (currently none).
2006-01-08 15:55:13 +00:00
rillig
74e4928049 - In shell commands, "case" statements are parsed properly. (Fixes a false
positive warning in mk/subst.mk.)
- Improved debugging support for parsing shell commands by printing the
  current state and word in -vv mode.
2006-01-08 14:14:36 +00:00
wiz
d182d0d618 Sync with usr.sbin/pkg_install 1.58:
Use MaxPathSize instead of PATH_MAX.
2006-01-08 12:25:06 +00:00
rillig
4d0e362738 - Enabled the quoting warning for SUBST_MESSAGE (this time the other
direction: it had been quoted too much in the past).
2006-01-07 23:29:23 +00:00
rillig
6e63ea31f3 - Added SUBST_MESSAGE to the list of checked variables. The plan is to
remove the quoting from the definitions in the Makefiles.
- When checking with -Wall, print warnings about possibly misquoted
  variables in the various states of the shell word parser.
2006-01-07 20:00:00 +00:00
seb
5ad846112f Update to version 1.25.
Fix libkver support for pkg_comp's build, auto and install targets,
Reported broken and fix tested by salo@.

Also ensure libkver is built, if needed, even before digest.

Approved by jmmv@
2006-01-06 23:08:51 +00:00
rillig
6bf7eb18c8 - Moved the code for checking macro names in patch lines into its own
subroutine, as it has no code that is specific to patch files.
2006-01-06 21:06:06 +00:00