Commit graph

49 commits

Author SHA1 Message Date
rillig
9f330148b3 Some things from the TODO list have been done. 2006-06-08 15:14:22 +00:00
joerg
4726a63c51 Add a wish for PYTHON_VERSIONS_INCOMPATIBLE. 2006-06-03 00:25:34 +00:00
rillig
5138f12646 Updated the TODO list. 2006-06-03 00:12:38 +00:00
rillig
79494065d4 Updated pkglint to 4.62.
Changes since 4.61:
- Bug fixes.
2006-05-16 22:18:59 +00:00
rillig
c0f3775f92 * In the vartypes.map, distinguish FOO and FOO.*. 2006-05-10 09:01:15 +00:00
rillig
fff7c773b6 Updated pkglint to 4.60.
Changes since 4.59:
- For many variables the :Q operator is not needed (by definition), for
  example some pathnames, user names, group names.
- Improved the diagnostics for planned package updates.
- Various catch-ups to recent changes in the infrastructure, among them
  BUILDLINK_ABI_DEPENDS and gettext.mk.
- When the PLIST contains a libtool archive, the *.a and *.so files don't
  have to be mentioned explicitly.
2006-04-21 10:37:51 +00:00
joerg
7633711ecd Possible warnings if the PLIST contains libtool archives, but the
package doesn't say it uses libtool. Warn for redundant libraries,
when the libtool archive is also included in the PLIST.
2006-04-19 15:05:34 +00:00
rillig
8da147b378 Debian's lintian has many ideas for things that pkglint could also check.
Maybe we can use some of them.
2006-03-01 22:11:15 +00:00
rillig
0514bb16a6 * Many of the checking routines need some context to provide better
warnings. For example, checkline_foo() may need to know what has
  happened in the file before that line.
2006-02-04 03:39:40 +00:00
joerg
41ad43f789 Wish for warning about BUILD_USES_MSGFMT being used without
devel/gettext-lib/buildlink3.mk being included. This is often,
but not always incorrect.
2006-02-02 17:41:57 +00:00
rillig
7fa0c4e8e9 Added an RCS Id and an introductory comment. 2006-01-06 17:24:38 +00:00
joerg
a485b489e3 Ask for warnings so that e.g. CONFIGURE_DIRS has overrides for
config.guess and config.sub as well.
2006-01-03 20:52:27 +00:00
rillig
1c0702676a Cleaned up the TODO list. 2006-01-02 10:12:09 +00:00
rillig
862032689f * record with each substring its source location to be able to make
even more precise diagnostics
2006-01-02 09:42:52 +00:00
joerg
ff4b54c998 Index: has sometimes different precedence in patch, avoid problems. 2005-12-30 16:27:13 +00:00
rillig
9c2bd09a33 * check quoting in CFLAGS+= -DPREFIX=\"${PREFIX:Q}\" 2005-12-11 22:07:46 +00:00
rillig
ab84b76ce4 Cleaned up the TODO list. 2005-12-08 10:47:38 +00:00
rillig
081ebe2d92 The option names are now checked if they are in
mk/defaults/options.description.
2005-12-08 10:43:04 +00:00
rillig
ddf867e458 I've sent joerg a patch which would fix his TODO item. 2005-12-07 18:47:34 +00:00
rillig
e3aeff9129 * IMAKE_MANNEWSUFFIX should be deprecated in PLISTs, says Joerg. 2005-12-06 16:42:15 +00:00
rillig
714c2498e8 * check that all values used for the PKG_OPTIONS are documented in
mk/defaults/options.description. Requested by Antoine Reilles via
  private mail.
2005-12-02 22:48:13 +00:00
rillig
34fc9c76f2 - Reintroduced the check for absolute pathnames in shell commands. This
check had been removed some time ago due to the huge number of false
  positives. Now that pkglint can parse shell commands quite well, it
  has been reintroduced, as absolute pathnames often indicate unportable
  features of a package. To implement this check (and a few others)
  accurately, the whole code for checking shell commands has been
  rewritten as a finite state machine.
2005-12-01 03:10:16 +00:00
rillig
f468c4d5c8 Implemented the --explain option and the checks for CPP macros in patch
files. New TODO items:

* extract the DISTFILES if they exist and check all files in them for:
  - security holes,
  - coding style violations,
  - possible unportable constructs
2005-11-24 10:18:50 +00:00
rillig
9cb1e0009d * warn about unportable CPP macros in patches. 2005-11-21 16:56:02 +00:00
rillig
77d1409d5f * mention the SUBST framework whenever ${SED} is used. 2005-11-15 10:30:54 +00:00
rillig
ca37329f8e * warn about the use of ${WRKDIR:=...}, as this construct should only
be used with lists.
2005-11-14 13:07:05 +00:00
rillig
5b6ded4f08 The readmakefile() subroutine only returns the lines of the main Makefile
in the $all_lines parameter, but the whole text of the included files in
the $whole parameter.

This change avoids duplicate diagnostics for *.mk and Makefile* in the
package directory. A side effect is that package authors only get the
diagnostics they can probably fix, as diagnostics from included files are
not given.
2005-11-14 12:32:58 +00:00
rillig
6f16fd47e3 * avoid duplicate warnings. 2005-11-14 11:47:07 +00:00
rillig
79c6c6d064 * detect spelling errors in variable names 2005-11-14 06:35:36 +00:00
rillig
c812c03911 * Find a reliable, secure way to delete all CVS directories inside
${WRKSRC}. When that is finished, add a warning that using ${XARGS}
  is insecure.
2005-11-10 12:19:58 +00:00
rillig
b892acdfdc diff:
- check for magic numbers like 0755, 755, 644
+ check for direct use of user names and group names
2005-11-08 21:00:33 +00:00
rillig
b59bd19d70 + check for magic numbers like 0755, 755, 644 2005-11-06 22:38:36 +00:00
rillig
0ce39795b4 * check Makefile directives
* check _every_ line of the Makefiles
* warn about the use of ${SED} in {pre,do,post}-install
2005-11-06 15:59:48 +00:00
rillig
7fb5f1c563 + include "../../mk/bsd.prefs.mk" before any .if. 2005-11-06 15:55:24 +00:00
rillig
94c299cd71 include ../../mk/bsd.prefs.mk before using "+=". 2005-11-03 23:28:09 +00:00
rillig
3dd3e17928 The "../.." and PERL5_PACKLIST checks are implemented. 2005-11-03 23:27:10 +00:00
rillig
e95f2f49e0 Updated pkglint to 4.28.1.
Declared some more variables as List types. Added a check that
PERL5_PACKLIST matches the PKGNAME.
2005-10-14 09:23:46 +00:00
rillig
e79b082b35 "-Wl,-rpath" should not be used directly. ${COMPILER_RPATH_FLAG} is better. 2005-10-13 20:17:45 +00:00
rillig
3184319c95 Cleaned up the TODO list. 2005-09-28 16:34:47 +00:00
rillig
234e62b9d0 Updated pkglint to 4.22.
A distfile that only has an SHA1 checksum, but not an RMD160 one, is
considered an error. While at it, made the distinfo file check a little
stricter.
2005-09-27 21:13:20 +00:00
rillig
4b97d64081 Checking for C/C++ comments is not necessary for Makefiles. No-one uses
them. All pathnames are already interpreted as being relative to the
package's directory. Added a reminder that ONLY_FOR_PLATFORM should be
changed to NOT_FOR_PLATFORM where appropriate.
2005-08-06 08:00:14 +00:00
rillig
e2d2fab6bc TODO: make all pathnames relative to the current directory. 2005-07-02 15:22:52 +00:00
rillig
25b5a911d7 Check for non-normalized dependency lines like package:../package instead
of package:../../category/package.
2005-06-07 17:53:08 +00:00
rillig
c338f5dab6 Removed unused subroutine abspathname. Added the things it did to the TODO
list.
2005-05-31 21:15:06 +00:00
wiz
31a5af7870 Add: * fatal error if RMD160 missing 2005-05-25 13:12:10 +00:00
rillig
859bc7f974 Removed the check for absolute filenames, as it has produced too many
false positive warnings. Added a reminder to TODO that a similar check
be added to pkglint. Welcome to 4.15.
2005-05-18 08:28:06 +00:00
rillig
be9e6c0d80 TODO: Check for C/C++ style comments in Makefiles. 2005-05-14 00:38:56 +00:00
rillig
1976ccd594 Added --explain option. 2005-05-05 22:59:18 +00:00
rillig
b65911e7f3 Added TODO list for pkglint. 2005-04-30 11:50:42 +00:00