Commit graph

132 commits

Author SHA1 Message Date
joerg
bd737b69e2 Extend shared library check to all files that match *.so. 2012-05-29 21:53:55 +00:00
marino
9220ff46a6 mk/check/check-files.mk: Skip locale.alias
On DragonFly, packages like devel/doc++ and net/wap-utils were failing the
file check during installation due to a present locale.alias file.  Treat
it the same as charset.alias.
2012-05-22 07:59:31 +00:00
reed
88166ad6f5 Rename "flavor" to "pkgformat".
This is from Anton Panev's GSoC 2011 project to add RPM and DPKG
support to pkgsrc. (I am not adding that further support in this
commit.)

This is just a rename of the existing functionality. Now it will
be easy to test the GSoC work by simply putting in a single
directory (such as "rpm" or "deb"). See
http://addpackageforma.sourceforge.net/ for some details.

This is from Anton's CVS, but I made some minor changes:

- changed plural pkgformats to singular pkgformat (to be consistent)

- fixed a few places (in comments) that were missed

- catch up on some additions to flavor not in the pkgforma cvs:
PKGSRC_SETENV and _flavor-destdir-undo-replace and
undo-destdir-replace-install.
2011-10-15 00:23:07 +00:00
abs
fc3bada41a Introduce PKGSRC_SETENV, defaulting to SETENV. Can be set to ${SETENV} -i
to santise environment
2011-09-08 20:17:15 +00:00
roy
7ecb96b2ef Just warn about non executable files using env. 2011-04-19 15:31:45 +00:00
roy
b73064c230 Disallow the use of env(1) as an interpreter. 2011-04-19 14:28:28 +00:00
obache
fb23ffa128 Skip interpreter check unless regular file.
PR#44089, avoid warnings from broken symbolic link or link to a directory.
2011-01-11 12:03:18 +00:00
bad
89f715edf7 I'm fed up with having to waste time because PKG_DEVELOPER is "special" and
can't be disabled by setting it to "no" like the other variables.
Besides, flavor/pkg/metadata.mk has been expecting for a long time that "no"
is a valid value.

Make PKG_DEVELOPER DWIM.
2010-08-24 19:08:28 +00:00
joerg
40c00aad94 Deal with cases where the first dependency of a package is a build
dependency, but a full dependency follows later.
2010-02-02 23:35:36 +00:00
tnn
f7cda37482 The missing run-time search path test cannot run reliably in DESTDIR mode
when not using the readelf(1) method, so skip the test and warn about it.
2010-02-02 15:36:15 +00:00
tnn
ab33a2bb5f revert previous - better do a bulk build with this change first to see
if/how much stuff is dependent on it.
2009-10-21 18:00:00 +00:00
tnn
33518e0113 remove lib/charset.alias from CHECK_FILES_SKIP 2009-10-21 17:00:33 +00:00
joerg
013ced16d3 Add wrkref check for using the .buildlink or .x11-buildlink
subdirectories. Update comment on the default checks.
2009-09-02 14:43:06 +00:00
agc
d07c430fe5 Get rid of an abstraction violation which has been in the tree since
March 2008. Not vital, but the previous way does not scale well/at all.
2009-07-26 05:32:43 +00:00
tnn
ddc47f016a fix typo in comment 2009-06-18 14:51:55 +00:00
minskim
ecb0f805f1 Remove a redundant "$" from a grep pattern. 2009-05-08 20:46:29 +00:00
uebayasi
c166eebbec Fix check-wrkref path.
_CHECK_WRKREF_FILELIST_CMD is a command which prints PLIST paths
converted to absolute path.  _CHECK_WRKREF_FILELIST_CMD can run
anywhere, so cd ${DESTDIR} before that is pointless.  To access files,
_CHECK_WRKREF_FILELIST_CMD's output needs to be s/^/${DESTDIR}/ when
destdir is used.


Reviewed By:	joerg
2009-01-12 13:11:22 +00:00
rillig
c448324760 Oops. 2008-12-15 12:28:49 +00:00
rillig
9a009cf3a3 Made the code shorter.
The info messages can be omitted. At least for ELF binaries, the code is
sufficiently stable.
2008-12-15 11:03:49 +00:00
rillig
0e70dc215e Removed unused variables. 2008-11-18 21:58:22 +00:00
joerg
8f45797884 "Downgrade" checkperms dependency to a normal build dependency.
This way it doesn't have to be installed for make checksum etc.
to run.
2008-06-22 22:05:19 +00:00
tnn
29fefc1b76 Enable USE_CHECK_SHLIBS_ELF on FreeBSD. Aleksej Saushev PR pkg/38606. 2008-05-13 11:40:24 +00:00
joerg
630dcf7283 Enable USE_CHECK_SHLIBS_ELF by default on DragonFly and NetBSD. 2008-03-09 13:47:08 +00:00
rillig
0f02165471 Removed colons from variable names so they are accessible to "bmake
help".
2008-02-20 10:43:55 +00:00
rillig
5530265343 After being deprecated for 16 months, SKIP_PORTABILITY_CHECK is now
obsolete.
2008-02-20 10:27:35 +00:00
rillig
5f7de0ffaa Removed colons for the sake of "bmake help". 2008-02-20 10:23:26 +00:00
rillig
c18f3fed81 Added a new check for binaries, so that they are installed according to
the INSTALL_UNSTRIPPED variable. By default, this check is disabled, so
that it does not cause any breakage.

NB: The file(1) command needs the explicit locale to prevent translated
messages. This file is copied from check-interpreter.mk.
2008-02-13 15:02:20 +00:00
rillig
339e8ef931 Adjusted the documentation to the source code. 2008-02-13 08:33:08 +00:00
tnn
8a03a4df4f Enable check-fakehome.mk. 2008-02-10 11:44:48 +00:00
tnn
d91ec32482 Enable fake home directory support. Also add a wrkref check because an
embedded path to the HOME directory can be a security problem if, say,
the package looks in the HOME directory of an unprivileged user for
configuration files.

Note that this has the potential to cause some short-term fallout.
2008-02-10 11:43:20 +00:00
adrianp
d08d9e77fe Skip ${PREFIX}/emul/linux32/proc.* as well 2008-02-08 23:13:35 +00:00
rillig
66736dde43 Replaced _PKG_SILENT and _PKG_DEBUG with RUN. 2008-02-07 21:36:13 +00:00
tnn
96ef75e1dd No need to walk the whole directory when checking for emptyness.
From Robert Elz.
2008-02-05 11:17:00 +00:00
tnn
3b84dc1b5a This is the check part of the fake $HOME code. Not enabled yet. 2008-02-05 09:45:00 +00:00
tnn
a1bf36e0ae Convert to ${RUN} 2008-02-05 08:17:59 +00:00
rillig
cef72b1779 STEP_MSG may be a hidden command. 2008-01-23 14:30:59 +00:00
rillig
3444dbc941 The package x11/gdm embeds ${exec_prefix} into a macro containing a
PATH, in which it is not directly preceded by a quote character:

	#define GDM_USER_PATH "/usr/bin:/bin:${exec_prefix}"

Catch this by complaining about "${" also when it appears after a colon.

Since this check is still disabled by default, it will not surprise anyone.
2008-01-21 06:11:09 +00:00
joerg
daa4ab9470 Make the default rpath for USE_CHECK_SHLIBS_ELF a platform variable.
Define the values for NetBSD and DragonFly.
2008-01-16 14:03:31 +00:00
bjs
c4ff3e236e The interpreter check for packages which are their own interpreter,
e.g. lang/perl5, was failing.  Adding a check for ${DESTDIR}"$$interp"
fixes this.
2007-11-30 08:34:31 +00:00
rillig
91b1d082d9 Print a warning for every file that has /bin/sh as interpreter, but only
on Solaris.
2007-11-28 17:00:04 +00:00
rillig
e5fa877447 Activated the check-interpreter for PKG_DEVELOPERs. I don't remember why
activating this has taken so long.
2007-11-07 10:52:00 +00:00
dsl
d24555b956 Fix the .include lines so that make looks in the right place first.
Remember .include "foo.mk" is looked for (first) in the directory that
contains the makefile being processed (like in C), so remove all the
${.PARSEDIR} and ../ sequences that just cause grief.
2007-10-13 11:04:15 +00:00
rillig
3e6363f13d Even though VARBASE is sometimes below LOCALBASE, some users want to
check it. Don't prevent that in CHECK_FILES_STRICT=yes mode.
2007-09-27 13:57:12 +00:00
rillig
7c238f4588 In bulk builds with a custom PKGSRCDIR, that directory should not appear
in binary packages. This check can be enabled by adding "pkgsrc" to
CHECK_WRKREF.
2007-09-13 09:52:46 +00:00
rillig
c852fe8d9a check-files shouldn't complain about files in VARBASE, since they cannot
be represented in the PLIST.
2007-09-12 10:22:53 +00:00
rillig
876b9237c3 Now it's possible to add custom directories to the check for directory
references.
2007-09-05 13:34:32 +00:00
jlam
f7addad279 Allow the existence of symlinks that point nowhere. 2007-08-21 21:44:23 +00:00
joerg
8b88cd8fca Add actual license and a small description of what this is doing. 2007-08-21 21:08:18 +00:00
joerg
80b8a5c96a Add a cross-compile and DESTDIR safe alternative to ldd for
check-shlibs. This allows more stricter detection (e.g. it checks
whether the package links against a build dependency). It also checks
whether the rpath contains wrkdir references (like qt3-libs). It depends
on readelf and is only available for ELF systems for now. To test it,
add USE_CHECK_SHLIBS_ELF to mk.conf.

Supported-by: Google SoC 2007
2007-08-20 11:04:02 +00:00
joerg
8eae292c51 Fix a number of bugs in the DESTDIR support:
- check-perms.mk was not DESTDIR aware, prefix files before passing it
  to the directory extraction
- PKG_FILELIST_CMD was calling pkg_info, which is fine for normal
  installation, but fails of course for DESTDIR. Just drop the @ lines
  from ${_DEPENDS_PLIST} and use that.
- To make he former work, ensure that _flavor-generate-metadata is part
  of _INSTALL_ALL_TARGETS. It was normally a dependency of
  _flavor-register, but that is skipped for DESTDIR.
- Remove ${_DEPENDS_PLIST} when running install-clean.
2007-08-14 23:58:24 +00:00