Packages defined the variable BROKEN inconsistently. Some added quotes,
like they are required in PKG_FAIL_REASON, some omitted them.
Now all packages behave the same, and pkglint will flag future mistakes.
pkglint -Wall -r --autofix --only aligned
After running the above command, three packages had to be adjusted
manually:
In maelstrom-x11, pkglint didn't see that a commented variable
assignment should have been re-aligned as well.
In netmaze, there was a single line that didn't align well with all the
others, but pkglint decided to adjust the whole paragraph to this single
line. The result would have been ok, but not good.
In tscp, there was a paragraph where some of the lines were indented
one space more than the others. This rule is useful when one variable
name is very long compared to the others, but not in this case.
* Fix permissions of data files. noted in PR 38912.
* Put data files in share, instead of lib.
* Put score files in ${VARBASE}, and use SETGIDGAME.
* Include string.h to suppress warnings.
Bump PKGREVISION.
or USE_X11BASE set, but don't include mk/x11.buildlink3.mk directly or
via buildlink3.mks
- introduce BUILDLINK_PREFIX.libXpm as alias for BUILDLINK_PREFIX.xpm
in the !modular case
- fix some cases where the check for libX11 couldn't work at all by using
C++ for compilation without including the proper headers
Verified using a full X11_TYPE=xorg bulk build without additional
breakage. Discussed with salo@, wiz@ and send to packages@ for feedback.
