Commit graph

2240 commits

Author SHA1 Message Date
rillig
055eed4044 Oops. The last change modified the behavior of an if-then-elsif chain in a
way that I didn't intend. Fixed.
2006-02-13 17:50:40 +00:00
rillig
b61c6ea237 - Including "options.mk" does not qualify to using common Makefiles, which
would suppress the variable order checking.
- Added an additional debugging statement to the variable ordering.
2006-02-13 15:37:49 +00:00
rillig
cf3ce2644e - Even if the type of a variable is guessed based on its name, report it
as untyped when in --debug mode. This allows the --debug mode to be used
  for detecting spelling mistakes.
2006-02-13 15:20:22 +00:00
rillig
860a0bd4e3 Correctly handle Python and Ruby prefixes in binary package names. Patch
provided by YOMURA Masanori in private mail.
2006-02-12 18:35:59 +00:00
rillig
fec6a92aae - ${COMPILER_RPATH_FLAG} should be used instead of the various -Wl,...
flags.
- [Brackets] are allowed in pathname masks.
2006-02-12 12:10:13 +00:00
rillig
3575f7b1eb - Changed the wording of the warning message for misquoted variables. The
wording had been completely mysterious. Now it gives a direct advise on
  how to fix the problem.
2006-02-11 20:58:08 +00:00
rillig
d78a085b17 - Removed duplicate definition for LIB_DEPENDS. 2006-02-11 19:49:58 +00:00
rillig
9021008619 - MANDIR is deprecated. Use PREFIX/PKGMANDIR instead. 2006-02-11 19:29:39 +00:00
rillig
e5d84f7208 - Added a backtrace() subroutine that prints a backtrace when debugging
mode and very verbose mode are activated. Currently unused, but it's
  handy to have it defined.
- Removed two subroutine calls that had resulted in duplicate warnings.
- Variables whose names end in _VAR may appear inside double quotes.
2006-02-11 16:14:40 +00:00
rillig
1c9ae5d76c - Added TOOLS_DEPMETHOD. 2006-02-11 16:12:26 +00:00
rillig
7135541b60 - Absolute pathnames are interpreted as such when pkglint checks whether
the file exists or not.
2006-02-11 12:47:05 +00:00
rillig
8ec9cc0783 - Recognize "set -e" even when it is hidden by other options, like
"set -eu".
2006-02-11 11:55:19 +00:00
rillig
9bcca64f85 - PKGNAME may appear in double quoted shell strings. 2006-02-11 11:53:21 +00:00
salo
21686515f8 Welcome to 1.26:
- add MAKEROOT_HOOKS, a whitespace separated list of functions
  or external scripts to be executed after the sandbox is created,
- be more verbose about hooks execution,
- run hooks only when they are defined.

ok <jmmv>
2006-02-10 23:41:20 +00:00
salo
9b0c71935c Add LIBKVER_STANDALONE_PREFIX to _TEMPLATE_VARS so it will appear
in the template. (hi seb!)
2006-02-10 23:36:12 +00:00
rillig
139bcdc38c - Don't warn if shell variables appear unquoted in ``for'' loops. 2006-02-10 12:49:22 +00:00
rillig
acca5866d1 - New error: The Solaris /bin/sh cannot handle "cd" inside conditionals. 2006-02-07 22:10:20 +00:00
rillig
e661eea073 - ../../pkgtools/x11-links/buildlink3.mk must not be included directly. 2006-02-07 21:44:39 +00:00
rillig
886c0440a6 - The diagnostics are filtered through strxvis(), so that pkglint is able
to check and report warnings even in files of random contents without
  emitting any terminal control sequences.
2006-02-07 09:49:09 +00:00
rillig
675546c4b7 - Not only check for the definition of deprecated variables, but also for
using them.
- The :Q operator should not be used in double quotes.
2006-02-07 09:20:17 +00:00
abs
8db20b79d3 Update pkg_chk to 1.76:
Append rather than prepend /usr/sbin:/usr/bin to path, to avoid issues
    on Solaris which has feature-poor ftp in /usr/bin
2006-02-06 12:44:08 +00:00
rillig
d62b095666 Updated pkglint to 4.56.
Changes since 4.55:
- Avoided false positive warnings about bsd.prefs.mk being required before
  using buildlink3.mk files.
- Restricted the files that are checked for absolute pathnames in patch
  files.
- Some tools that are often used as ${TOOLNAME} need to be explicitly
  added to the USE_TOOLS variable. When complaning about their direct
  use, add a proper advice.
- Readded all the deprecated variables. The warnings will have to stay
  longer than just three months.
2006-02-06 10:11:34 +00:00
rillig
5fab31e375 - Reworded two occurrences of "unportable". They sounded too harsh. 2006-02-06 10:07:23 +00:00
rillig
f017b5590f - Don't emit an extra warning if a tool should be added to USE_TOOLS. Just
append it to the previous line.
2006-02-06 09:46:42 +00:00
joerg
5911def816 Recursive revision bump / recommended bump for gettext ABI change. 2006-02-05 23:08:03 +00:00
rillig
e47296e901 Readded almost all variables that had been here in the past. We cannot
force the developers to learn all pkgsrc changes every three months, so
it's better to keep the warnings for a much longer time. I don't know
yet what "much longer" exactly means.
2006-02-05 00:05:39 +00:00
rillig
8b2f8a458e Pinned down the collected problems of the current pkglint development. 2006-02-04 04:10:12 +00:00
rillig
0514bb16a6 * Many of the checking routines need some context to provide better
warnings. For example, checkline_foo() may need to know what has
  happened in the file before that line.
2006-02-04 03:39:40 +00:00
rillig
abd8089cf7 - Some tools that are often used as ${TOOLNAME} need to be explicitly
added to the USE_TOOLS variable. When complaning about their direct
  use, add a proper advice.
2006-02-04 03:37:08 +00:00
rillig
05451e4af6 - bsd.prefs.mk does not need to be included before BUILDLINK_DEPMETHOD gets
assigned using the "?=" operator, since these variables are not meant to
  be set by the user.
- Restricted the files that are checked for absolute pathnames in patch
  files.
2006-02-02 20:50:02 +00:00
joerg
41ad43f789 Wish for warning about BUILD_USES_MSGFMT being used without
devel/gettext-lib/buildlink3.mk being included. This is often,
but not always incorrect.
2006-02-02 17:41:57 +00:00
rillig
619bb5ab6e Updated createbuildlink to 3.10.
The last line is now indented with <tab> instead of six spaces. This
prevents many pkglint warnings and also looks better.
2006-01-31 03:35:35 +00:00
rillig
8ade92fcb2 Updated pkglint to 4.55.
Changes since 4.54:
- -Wvarorder works now as expected.
- distinfo files are checked more strictly.
- Reduced the number of false positives.
- Make(1) variables of the form $(...) are detected properly.
2006-01-30 09:35:13 +00:00
rillig
75562fa202 - Added a hack to be able to parse nested make(1) variables like
${TOOL.${t}}. They just extend up to, but not including the next space or
  quote character.
- log_debug() is used for printing debugging info, not log_error().
- Even if NO_CHECKSUM is set, distinfo files may exist if the package has
  patches. Noted by salo.
2006-01-30 01:26:04 +00:00
rillig
16bdee598a - Variables whose name end in DIR, DIRS, FILE, FILES, as well as PATH,
PREFIX, LOCALBASE and PKGNAME may appear in single quotes.
2006-01-29 01:29:38 +00:00
rillig
c99dd61732 - PkgLint::String::substring accepts an undefined second argument.
- Added PkgLint::String::match_all.
- Make(1) variables of the form $(...) are detected properly.
- The shellword parser's state is printed in --debug mode.
- In double quoted strings, normal text is processed faster.
- The proof of concept for match_all is done with finding absolute
  pathnames in patch files.
2006-01-28 12:24:20 +00:00
rillig
6282c39496 - Added a comment above get_regex_plurals, explaining what it does. 2006-01-28 11:19:07 +00:00
rillig
20511917c5 - Added PkgLint::Util::min and PkgLint::Util::max.
- Rewrote PkgLint::String::substring to make it look less like a Brainf***
  program. I guess this will greatly improve execution speed.
2006-01-28 11:18:17 +00:00
rillig
6af5ebf4c7 - Removed PkgLint::Util::match.
- Added PkgLint::Match, which represents the result of matching a regular
  expression against a PkgLint::String.
- Fixed the arguments to substr in PkgLint::String::substring.
- Added PkgLint::String::match.
- Added a proof of concept in checkfile_patch, in the warning about RCS
  tags. Run pkglint -s --klickibunti to see it.
2006-01-28 11:11:49 +00:00
rillig
0d54162e3d - Found the one variable that slipped through when renaming $file to
$fname.
2006-01-27 02:25:52 +00:00
rillig
a45550b4ce - Fixed inconsistent use of white-space. 2006-01-27 00:56:26 +00:00
rillig
825e4abfb6 - Reformatted simple getter/setter methods to save some space. 2006-01-27 00:55:08 +00:00
rillig
48fa42a5a7 - Globally renamed all variables called $file into $fname. The identifier
$file is reserved for variables of the type PkgLint::File.
2006-01-27 00:48:57 +00:00
rillig
f833e97ec7 - Added the two data types PkgLint::File and PkgLint::Location. I will need
them soon.
2006-01-27 00:07:07 +00:00
rillig
3a4982c5f2 - Added the PkgLint::Util::match function that matches a string against a
regular expression and saves the values of the volatile @- and @+ arrays.
2006-01-26 23:05:49 +00:00
rillig
482bedac8b Even in quick-install mode, the self test should be run. 2006-01-26 16:20:45 +00:00
rillig
95d3203cb2 Added a ``quick-install'' target that allows me to install pkglint in three
seconds instead of 40.
2006-01-25 22:04:26 +00:00
xtraeme
391437abe6 Fix false positives about the test that checks for pkg-config files
in WRKSRC. Now it works properly.

Bump to 1.33.
2006-01-25 05:10:00 +00:00
rillig
f43a67d266 - In --debug mode, all variable assignments that occur when the package
Makefile is read in are logged to give further aid in debugging.
- Warnings about PKGNAME and DISTNAME are anchored at line numbers instead
  of the package Makefile.
2006-01-25 00:23:48 +00:00
joerg
fa0e987ec8 Add conditional code to ignore the non-numeric part of an OS version
for the sake of compatibility tests in pkg_add.
E.g. DragonFly versions like
        1.4.0-RELEASE
are reduced to
        1.4.0

This code is currently enabled for DragonFly only.
2006-01-25 00:20:09 +00:00