Up to now, all files whose names started with "patch-" were considered
patch files. This was wrong, since e.g. devel/patch also has distfiles
with the same naming pattern.
When shutting down the master after all jobs are done, send a zero
length request to the clients and wait a second for them to shutdown the
connection. Calling shutdown on the server side doesn't avoid TIME_WAIT
as originally intended.
overrides our attempt to set it to "x86_64" and ensure consistency across
platforms. Work around this by setting it using PKGSRC_MACHINE_ARCH.
Confirmed to fix the issue and not break a variety of other platforms by
Sevan, and approved under duress by Joerg.
This resolves issues on platforms which MACHINE & MACHINE_ARCH is explicitly
defined, such as OpenBSD/amd64 & Bitrig/amd64 where we would like to build with
MACHINE_ARCH=x86_64 but can't as a platform check fails when installing
packages after bootstrap
pkg_add: Warning: package `digest-20121220' was built for a platform:
pkg_add: OpenBSD/x86_64 5.8 (pkg) vs. OpenBSD/amd64 5.8 (this host)
Tested on
Mac OS X Tiger/PowerPC
OpenBSD
Bitrig
Solaris 10/SPARC
FreeBSD 10.2-RELEASE & 11-CURRENT
DragonFlyBSD
Debian 8
OmniOS
Reviewed by joerg@
The warning that "return undef" is bad must be taken with great care.
Although perlcritic explains it a lot and warns to think before simply
fixing it, it doesn't mention that in some cases a simple "return" means
"return '0'", which had happened here.
* Removed needless check for MD5; all packages have been migrated already
* Made the code simpler by not relying on state transitions
* Allowed the newly introduced SHA512 to be mentioned in distinfo
The pkglint.pl file has grown pretty large, which makes it hard to under-
stand. Therefore it is useful to split it into reasonable parts.
The code for checking patch files is such a part since it is independent
of the rest of pkglint, and its specialized routines take quite a bit
of space.
Using regular expressions provides more uniform code, but at the cost of
higher runtime, since Perl doesn't optimize them away, even if they are
very simple, like those emulating the startswith() or endswith() functions
that other languages provide.
This warning isn't supposed to fire on macro code, so this is either
something subtly odd in pkgin or broken in OS X's clang. This still
needs fixing, but in a way that's more limited to the problematic
platform.
At least on OS X with clang, pkgin fails to build because of extra
parens around ==. See https://github.com/NetBSDfr/pkgin/issues/64
for details.
This seems to be a new issue with something in the pkgsrc build
environment (bsd makefiles or compat libs), not in pkgin proper, but
pkgin's use of bsd makefiles leads to Werror.
builds. Introduce hooks for sending bulklog and package explicitly the
master. The default bulklog action is a nop and the package action
mirrors the normal package step, i.e. copying to ${packages}/All and
adding the category symlinks.
patchdiff. It is often useful to have tools in one prefix and reach-over
patch creation with a different make and different WRKOBJDIR settings,
e.g. when developing in a bulk build environment.
Bitrig uses ELF on amd64 & arm and does not have any legacy dependency on a.out.
Remove if statement to check $MACHINE_ARCH is x86_64 in-order to set $OBJECT_FMT
to ELF, preventing $OBJECT_FMT being set to a.out by mistake.
Reviewed by joerg@
