Commit graph

10 commits

Author SHA1 Message Date
rillig
3444dbc941 The package x11/gdm embeds ${exec_prefix} into a macro containing a
PATH, in which it is not directly preceded by a quote character:

	#define GDM_USER_PATH "/usr/bin:/bin:${exec_prefix}"

Catch this by complaining about "${" also when it appears after a colon.

Since this check is still disabled by default, it will not surprise anyone.
2008-01-21 06:11:09 +00:00
rillig
b12d590e3e Removed the need to define the PKGSRCDIR environment variable. 2007-01-02 17:58:11 +00:00
rillig
1a51080155 Refined the pattern for lines containing bad macros. White-space is
allowed between the "#" and the "define", and the value must be of the
form "${varname}/...", that is, starting with a double quote, followed
by "${" and a variable name, and directly behind the closing brace must
be a slash. This should catch most false positives while still being
useful.
2006-11-10 07:59:01 +00:00
rillig
05707c80dc This is also an FAQ of autoconf, so provide a link to there. 2006-11-09 21:07:25 +00:00
rillig
e49f88c9ef Fixed the SKIP_FILTER command so that NetBSD's ksh can handle it as well. 2006-11-09 14:41:18 +00:00
rillig
24675f34ff Added a function cs_explain() to check-subr.sh that prints an
explanation for an error message, nicely formatted.

Added explanations for the checks in check-portability.sh.
2006-11-09 10:52:21 +00:00
rillig
649c0754d5 Added another sentence that explains how to disable this check for
individual files.
2006-11-09 10:31:54 +00:00
rillig
3dfe0787ed Added an explanation how to fix the errors reported by this check. 2006-11-09 10:26:50 +00:00
rillig
c4cb1de1ee Made the code simpler. 2006-11-09 09:51:46 +00:00
rillig
3911155e2f Moved the portability checks from the configure/ directory to checks/,
since according to the comment in check/bsd.check.mk, they belong there.

Added a new check for all C and C++ header files to make sure they don't
contain strings like ${prefix} or ${exec_prefix}, which is currently a
problem with sysutils/dbus and has been noticed in PR 35019. This check
is disabled by default since I don't know anything about possible false
positives, but I plan to enable it for PKG_DEVELOPERs after some
testing.

Added two names for hooks that are placed in the configure and in the
build phase. Now the checks look more like becoming something one could
call a framework, sharing a common structure and a documented interface.
2006-11-09 02:53:15 +00:00