Commit graph

2154 commits

Author SHA1 Message Date
rillig
4907cb1168 - In resolve_relative_path, the depth of the path should only be adjusted
in about half the cases -- added an additional parameter.
2006-01-11 12:25:19 +00:00
rillig
271edbd2ec Fixed spacing issue. 2006-01-11 11:42:27 +00:00
rillig
53e93b0ab9 - Renamed PkgLint::FileUtil::Line to PkgLint::Line in preparation to some
upcoming changes.
2006-01-11 04:29:12 +00:00
christos
cd18fc91dc Use ${ABI} for library files, patterned after what SGI does. This makes
X11 packages work on amd64 linux boxes. From Benjamin Shi.
2006-01-10 16:56:42 +00:00
rillig
2cd8334aa7 Updated pkglint to 4.52.
Changes since 4.51:
- The occurence of a symlink other than work* inside the pkgsrc tree is
  not an error, just a warning.
- SUBST_MESSAGE should not be quoted.
- If -Wextra is enabled, all make variables that are used in shell commands
  are checked for proper quoting.
- Improved the parser for shell commands.
- Some other minor changes.
2006-01-10 00:52:00 +00:00
rillig
c24a72897b Fixed the simple part of the pkglint -Wall warnings. 2006-01-09 23:39:55 +00:00
rillig
1d78045e51 - Even in an unquoted shell word, variables should be quoted. For example,
${PREFIX:Q}/foo.
- The semicolon after the "for" loop in the shell does not mean that some
  exitcode is ignored, so don't print warnings for it.
2006-01-09 23:14:45 +00:00
rillig
9bb9aae442 - Only check make variables for deprecation and $(...) instead of ${...}. 2006-01-09 03:22:45 +00:00
rillig
043613d277 - Added "Please use ${FOO} instead of $(FOO)."
- It is an error if the COMMENT has the default value from url2pkg.
2006-01-09 02:47:56 +00:00
joerg
a32d8f5c53 Unbreak by adding NO_BUILD=yes. 2006-01-08 21:00:22 +00:00
rillig
2464072040 - Rewrote the state transition of the shell command parser. The source
code now needs less lines than before. For unknown state/shellword
  combinations, warnings are printed (currently none).
2006-01-08 15:55:13 +00:00
rillig
74e4928049 - In shell commands, "case" statements are parsed properly. (Fixes a false
positive warning in mk/subst.mk.)
- Improved debugging support for parsing shell commands by printing the
  current state and word in -vv mode.
2006-01-08 14:14:36 +00:00
wiz
d182d0d618 Sync with usr.sbin/pkg_install 1.58:
Use MaxPathSize instead of PATH_MAX.
2006-01-08 12:25:06 +00:00
rillig
4d0e362738 - Enabled the quoting warning for SUBST_MESSAGE (this time the other
direction: it had been quoted too much in the past).
2006-01-07 23:29:23 +00:00
rillig
6e63ea31f3 - Added SUBST_MESSAGE to the list of checked variables. The plan is to
remove the quoting from the definitions in the Makefiles.
- When checking with -Wall, print warnings about possibly misquoted
  variables in the various states of the shell word parser.
2006-01-07 20:00:00 +00:00
seb
5ad846112f Update to version 1.25.
Fix libkver support for pkg_comp's build, auto and install targets,
Reported broken and fix tested by salo@.

Also ensure libkver is built, if needed, even before digest.

Approved by jmmv@
2006-01-06 23:08:51 +00:00
rillig
6bf7eb18c8 - Moved the code for checking macro names in patch lines into its own
subroutine, as it has no code that is specific to patch files.
2006-01-06 21:06:06 +00:00
rillig
dcf63d1b4b Fixed pkglint warnings about incorrect quoting and unsorted PLIST. 2006-01-06 19:46:26 +00:00
rillig
d66e28a8c5 - s/existant/existent/ 2006-01-06 18:02:05 +00:00
rillig
b29b41bfc1 - Renamed checkfile_patches_patch to checkfile_patch. 2006-01-06 17:43:18 +00:00
joerg
90ac0fb998 Use SUBST framework. 2006-01-06 17:28:20 +00:00
rillig
7fa0c4e8e9 Added an RCS Id and an introductory comment. 2006-01-06 17:24:38 +00:00
joerg
a11c0f7879 Use SUBST framework. Use PERL5 instead of ${PREFIX}/bin/perl to get
the location of the interpreter.
2006-01-06 17:10:58 +00:00
joerg
98faef6634 Use SUBST framework. 2006-01-06 16:58:32 +00:00
rillig
8005613009 - It is not an error to have symlinks in pkgsrc -- just a warning. Any
directory entry besides regular files, directories and symlinks is still
  an error.
2006-01-06 13:42:47 +00:00
wiz
dc560ec778 Depend on cdrtools instead of cdrecord. Bump PKGREVISION.
Update some messages/comments.
2006-01-05 23:29:04 +00:00
xtraeme
a429287789 Remove GNU Autoconf's configure.lineno file if it's there. 2006-01-05 17:42:24 +00:00
xtraeme
40bf851429 Move the PKGCONFIG_OVERRIDE lines after USE_TOOLS, GNU_CONFIGURE, etc. 2006-01-05 17:32:50 +00:00
xtraeme
6c95a6da67 Update to 1.32:
* Don't use ${WRKSRC} for PKGCONFIG_OVERRIDE (it's assigned automatically)
* If there are pkg-config files, now it will add "USE_TOOLS+= pkg-config".
2006-01-05 17:26:54 +00:00
christos
c6761ed17e Handle newer versions of Berkeley DB. Our algorithm is:
- if you have > db1 the probably you have db_185.h which means
  that dbopen is really __db185_open, and we'll prefer that.
- else if you have db1, then you have db1/db.h and dbopen
- else if you have db.h, then this is either the one from db1 and it will
  work with -ldb having dbopen, or it will not.

Note that the compatibility option on __db185_open() will actually not create
or update db1.85/1.86 files, but it will use the current format of the db
library. This compatibility layer is source code only.
2006-01-04 23:33:23 +00:00
joerg
a485b489e3 Ask for warnings so that e.g. CONFIGURE_DIRS has overrides for
config.guess and config.sub as well.
2006-01-03 20:52:27 +00:00
abs
9ca94e98c0 update pkg_chk to 1.64
- Allow -U of filenames on the commandline
2006-01-03 19:00:09 +00:00
rillig
1c0702676a Cleaned up the TODO list. 2006-01-02 10:12:09 +00:00
rillig
0ff3a14888 - For possibly misquoted variables the current shellword state is
printed (-vv only).
- TODO: Decide which variables may be used in which quoting states.
2006-01-02 10:09:03 +00:00
rillig
862032689f * record with each substring its source location to be able to make
even more precise diagnostics
2006-01-02 09:42:52 +00:00
rillig
83f5dee91f Updated pkglint to 4.51. Welcome to the Fahrenheit release.
Changes since 4.50:
- Extended the quoting checks for make variables to shell commands.
- Added a check for unquoted shell variables (only with -Wextra).
- Some other minor changes.
2006-01-02 08:29:55 +00:00
rillig
11b91ee6d2 - Fixed the wording of the message when CONFIGURE_DIRS and friends are
prefixed with ${WRKSRC}. It had been plainly wrong.
2006-01-02 03:02:29 +00:00
rillig
d3a90242d3 - Removed the type guessing code for variables with unknown type, as
this code has led to duplicate diagnostics. It had been misplaced as
  well.
2006-01-02 01:20:31 +00:00
rillig
b42c46442f - Added MESSAGE_SUBST, PKG_GROUPS, PKG_USERS. 2006-01-02 01:18:24 +00:00
rillig
bc5fc19c6f - Unquoted shell variables may appear in for loops. 2006-01-01 22:08:22 +00:00
rillig
08274c2f69 - Uncommented the note that CONFIGURE_DIRS, BUILD_DIRS and INSTALL_DIRS
don't need to be prefixed with ${WRKSRC}, now that there will be no
  more pullups to 2005Q3.
2006-01-01 21:58:12 +00:00
rillig
2d6877dcb0 - Added a check for unquoted shell variables (only with -Wextra). 2006-01-01 21:55:44 +00:00
rillig
bab261e700 - Integrated checklines_patches_patch back into checkfile_patches_patch. 2006-01-01 19:58:36 +00:00
rillig
54171b1096 - Fixed typo: It's __NetBSD_Version__, not __NetBSD_Version_. 2006-01-01 19:07:20 +00:00
wiz
faf65456ad Remove stuff that was marked for removal after 2005Q4. 2006-01-01 18:53:03 +00:00
rillig
be3a661d5b - Added a parser for shell words.
- Added warnings for imperfect quoting style inside double quotes.
- All shell commands are checked for correct quoting of make(1) variables
  in shell assignments like --prefix=${PREFIX:Q} and TMPDIR=${WRKSRC:Q}.
2006-01-01 18:40:12 +00:00
rillig
ea3cb56d30 - Moved the code that checks for valid shell words into its own subroutine
because it will be extended soon.
2005-12-31 15:00:15 +00:00
rillig
068c3c65d5 Updated pkglint to 4.50.
Changes since 4.49:
- Added checks for shell commands whose exitcodes are ignored.
- Added checks for CFLAGS, CPPFLAGS and CXXFLAGS.
- Improved diagnostics.
- Various bugfixes.

Changes to lintpkgsrc:
- Avoided double occurrence of pkg_install.
2005-12-31 14:09:51 +00:00
rillig
816ce58996 Added some variables, strengthened the checks for some other variables. 2005-12-31 14:02:28 +00:00
rillig
5b0ebb51c6 - Restructured the header comment.
- Rewrote the message formatting.
- The indentation of explanations is changed to be always a tabulator
  character instead of depending on the last message.
- In verbose mode, statistics about the frequency of the individual
  messages are printed before exiting.
- The command line option -Wextra enables additional warnings that are
  not enabled by default because I have been told that Alistair would kill
  me for them. :)
- Improved the shell tokenizer by recognizing parentheses.
- Improved checking of pkgsrc-internal files (mostly in pkgsrc/mk).
- Added a (trivial) spellchecker.
- Added checks for shell code that ignores the exitcode of commands.
- Added checks for CFLAGS, CPPFLAGS and CXXFLAGS.
- Avoided false positive warnings for absolute filenames in AWK code.
- Added checks for .for variables.
- Pkglint can check single files in directories that are three levels deep.
  This is mostly useful for checking patch files.
2005-12-31 14:01:46 +00:00