Commit graph

80 commits

Author SHA1 Message Date
tnn
146da1286c Teach pkgsrc about HP-UX. 2007-04-14 14:17:49 +00:00
heinz
5f663ce08e Made this check work again. The regular expression did not match relative
paths from .PLIST.

Changed the working directory to ${DESTDIR}${PREFIX} so files can be
accessed correctly.

Extended the relative paths to absolute paths again for better clarity.

Improved (IMHO) some wording.
2007-03-24 18:23:54 +00:00
heinz
68d8d088d8 More DESTDIR fixes in warnng/error messages 2007-03-24 18:12:08 +00:00
heinz
ae77e8ea18 Removed unnecessary shell code:
p|p) is the same as p)
2007-03-24 18:03:09 +00:00
joerg
28be10b7b5 Fix check-interpreter when using USE_DESTDIR. From Klaus Heinz on
tech-pkg.
2007-03-20 16:21:10 +00:00
rillig
953092259f Typo. 2007-03-18 19:37:12 +00:00
rillig
185782f13a Added the variable declarations for the "show-all" target. 2007-03-16 10:29:22 +00:00
rillig
dc3b9d6541 Don't check files in ${PACKAGES} and ${DISTDIR}. 2007-03-16 10:17:13 +00:00
rillig
66bf916302 For all those who are interested in the inner workings of pkgsrc, there
is a new target "show-all" that fits to the existing "debug",
"show-tools", "show-vars" targets. It prints a list of the variables
that make up the public interface to pkgsrc. Running this target is
especially useful if you want to do some things, you know that they must
have been implemented but you don't know what it is called. It also
shows the "class" of a variable (user-defined, package-defined,
system-defined).
2007-03-15 22:54:24 +00:00
rillig
d61f4b03b7 The CHECK_WRKREF variable has changed type: It is now a list of
directory aliases. That makes it possible to check for references into
TOOLS_DIR and WRKSRC, but to leave out the other infrastructure
directories.

On IRIX, x11/gtk2 failed to build because of an unknown library
-lharfbuzz. That library turned out to be an internal dependency of
graphics/cairo, which had made it into the installed libpangocairo.la
file.

With this change, that bug would have been caught earlier.
2007-03-15 01:06:02 +00:00
rillig
8dd9cf3d41 Renamed some more flavor-specific targets to have the form _flavor-*.
Split check-vulnerable into a general an a flavor-specific part, for
consistence with all the other targets.
2007-03-09 00:39:54 +00:00
rillig
38de695082 Documented how to use checkperms in bulk builds. 2007-03-08 22:49:05 +00:00
wiz
fc3f7b9811 Remove support for obsolete and unused NO_PKG_REGISTER. 2007-03-02 05:54:18 +00:00
rillig
5c8a2d4f08 Fixed the mismatch between absolute and relative paths. 2007-01-07 11:21:24 +00:00
rillig
06e2f03ee1 Moved the code that installs check-files on the hook from install.mk to
check-files.mk, for two reasons:

1. It belongs there.
2. Now check-files is run before check-perms and check-interpreter.
2007-01-06 20:15:26 +00:00
rillig
e4a09fc74a Reformatted the help text to be more human-readable instead of
pkglint-readable.
2007-01-06 14:11:16 +00:00
rillig
b12d590e3e Removed the need to define the PKGSRCDIR environment variable. 2007-01-02 17:58:11 +00:00
rillig
216918d333 Made the portability check more portable by not using a hard-coded
"/dev/stderr" in the AWK programs. That device file doesn't exist on
IRIX, and it isn't required by POSIX either.
2006-12-31 13:35:10 +00:00
martti
e2610fb8c8 Remove trailing tabs. 2006-12-15 13:15:06 +00:00
rillig
914dd9cda3 Made all .include lines look the same. 2006-12-12 21:37:20 +00:00
rillig
32b86a6076 On Solaris 5.9, the ksh cannot handle null bytes in the input. It's
documented in a SunSolve document, but that document is not accessible
to the public.

There's no better way than to start a subshell executing sed(1) in this
case. This makes the test even slower on these machines, and is not even
guaranteed to work in all cases. That's life.
2006-12-12 21:10:41 +00:00
rillig
e2e94b2719 On Interix, the -c option of checkperms is disabled, as checkperms does
not know about Interix yet. This is a temporary work-around for
PR 34968.
2006-11-17 01:05:47 +00:00
rillig
1639b3587b Instead of $0 and $1 .. $NF, the function check_test_eqeq should test
the string in the ''line'' variable. This will make koffice build again.
2006-11-13 23:21:53 +00:00
rillig
66982a6030 Added a missing line continuation in the code for CHECK_FILES_STRICT.
Apparently no one has been using that code since June 2006.
2006-11-12 20:57:55 +00:00
rillig
c879441de5 Moved the test whether this check should be enabled to this file.
Removed the dependency to NO_PKG_REGISTER.

Renamed the check-interpreter target to _check-interpreter.
2006-11-12 00:49:57 +00:00
rillig
918d65cc09 Added the CHECK_PERMS_AUTOFIX variable, which allows packages to say
that the file permissions should be fixed automatically.

Moved the test whether this check should be enabled from
../install/install.mk to here.

Renamed the target from check-perms to _check-perms.
2006-11-12 00:44:24 +00:00
rillig
b7ceab86aa Improved the formatting of the comment and made the code a little
shorter.
2006-11-12 00:37:44 +00:00
rillig
5644aacf25 Moved the check for whether check-wrkref should be run from
install/install.mk to check/check-wrkref.mk.

Renamed the check-wrkref target to _check-wrkref.
2006-11-12 00:13:26 +00:00
rillig
bd41165b43 Improved the readability of the header comment.
CHECK_WRKREF may be set to "wrkobjdir" to check for references to
WRKOBJDIR.

Added some error checking.

Removed the dependency on NO_PKG_REGISTER.
2006-11-12 00:09:50 +00:00
rillig
53ee7b45c5 Fixed the comment. 2006-11-11 23:59:56 +00:00
rillig
06e3596610 Moved the check whether check-shlibs should be run from
install/install.mk to check/check-shlibs.mk.

Renamed check-shlibs to _check-shlibs. Since it had been declared as
"private" before, this will not break anything.
2006-11-11 23:31:38 +00:00
rillig
8589d49821 Added the usual header comment.
Removed the special case handling of NO_PKG_REGISTER. What does checking
for shared libraries have to do with whether the package is registered
in the package database or not?

Removed the check on CHECK_SHLIBS_SUPPORTED, which will be reintroduced
soon.
2006-11-11 23:27:51 +00:00
rillig
1a7d02851e Improved a comment. 2006-11-11 23:08:00 +00:00
rillig
d9096da9ad Fixed the warning from GNU awk that in strings, \$ is the same as a
plain $.
2006-11-10 08:17:06 +00:00
rillig
1a51080155 Refined the pattern for lines containing bad macros. White-space is
allowed between the "#" and the "define", and the value must be of the
form "${varname}/...", that is, starting with a double quote, followed
by "${" and a variable name, and directly behind the closing brace must
be a slash. This should catch most false positives while still being
useful.
2006-11-10 07:59:01 +00:00
rillig
d43645467b Added documentation. 2006-11-09 21:29:26 +00:00
rillig
05707c80dc This is also an FAQ of autoconf, so provide a link to there. 2006-11-09 21:07:25 +00:00
rillig
0a17361ac7 Documented the ksh-compatible form of the SKIP_FILTER. 2006-11-09 15:12:46 +00:00
rillig
a226b89651 Added a little comment.
The program now exits with the correct exit status in case of errors.
2006-11-09 15:12:15 +00:00
rillig
085172dcd3 Greatly simplified the code and added documentation. 2006-11-09 15:10:16 +00:00
rillig
e49f88c9ef Fixed the SKIP_FILTER command so that NetBSD's ksh can handle it as well. 2006-11-09 14:41:18 +00:00
rillig
ffe459f4de Rewrote check-portability in awk instead of shell, since the shell has a
huge performance problem: When reading files, it calls read(2) for every
single byte. awk instead reads a whole line at a time. For the lang/php5
package, the execution time changed from (7.8 real 4.5 user 3.1 sys) to
(1.6 real 1.5 user 0.4 sys).
2006-11-09 14:36:18 +00:00
rillig
24675f34ff Added a function cs_explain() to check-subr.sh that prints an
explanation for an error message, nicely formatted.

Added explanations for the checks in check-portability.sh.
2006-11-09 10:52:21 +00:00
rillig
649c0754d5 Added another sentence that explains how to disable this check for
individual files.
2006-11-09 10:31:54 +00:00
rillig
3dfe0787ed Added an explanation how to fix the errors reported by this check. 2006-11-09 10:26:50 +00:00
rillig
c4cb1de1ee Made the code simpler. 2006-11-09 09:51:46 +00:00
rillig
3911155e2f Moved the portability checks from the configure/ directory to checks/,
since according to the comment in check/bsd.check.mk, they belong there.

Added a new check for all C and C++ header files to make sure they don't
contain strings like ${prefix} or ${exec_prefix}, which is currently a
problem with sysutils/dbus and has been noticed in PR 35019. This check
is disabled by default since I don't know anything about possible false
positives, but I plan to enable it for PKG_DEVELOPERs after some
testing.

Added two names for hooks that are placed in the configure and in the
build phase. Now the checks look more like becoming something one could
call a framework, sharing a common structure and a documented interface.
2006-11-09 02:53:15 +00:00
joerg
144c44a4ac Look into DESTDIR when checking for WRKDIR references. 2006-11-05 14:46:50 +00:00
rillig
74d127ee88 Adjusted the check-perms target to the recent update of
sysutils/checkperms.

Regular files are now checked if they needlessly have the executable bit
set.
2006-11-02 02:44:17 +00:00
rillig
ce502552c2 Moved the check whether checkperms(1) exists from load time to run time. 2006-10-21 11:13:10 +00:00