the linker flag should be filtered out by a rule in builtin.mk, but
apparently this doesn't always work. If in builtin.mk, it doesn't get
defined unnecessarily.
This changes the buildlink3.mk files to use an include guard for the
recursive include. The use of BUILDLINK_DEPTH, BUILDLINK_DEPENDS,
BUILDLINK_PACKAGES and BUILDLINK_ORDER is handled by a single new
variable BUILDLINK_TREE. Each buildlink3.mk file adds a pair of
enter/exit marker, which can be used to reconstruct the tree and
to determine first level includes. Avoiding := for large variables
(BUILDLINK_ORDER) speeds up parse time as += has linear complexity.
The include guard reduces system time by avoiding reading files over and
over again. For complex packages this reduces both %user and %sys time to
half of the former time.
and add a new helper target and script, "show-buildlink3", that outputs
a listing of the buildlink3.mk files included as well as the depth at
which they are included.
For example, "make show-buildlink3" in fonts/Xft2 displays:
zlib
fontconfig
iconv
zlib
freetype2
expat
freetype2
Xrender
renderproto
RECOMMENDED is removed. It becomes ABI_DEPENDS.
BUILDLINK_RECOMMENDED.foo becomes BUILDLINK_ABI_DEPENDS.foo.
BUILDLINK_DEPENDS.foo becomes BUILDLINK_API_DEPENDS.foo.
BUILDLINK_DEPENDS does not change.
IGNORE_RECOMMENDED (which defaulted to "no") becomes USE_ABI_DEPENDS
which defaults to "yes".
Added to obsolete.mk checking for IGNORE_RECOMMENDED.
I did not manually go through and fix any aesthetic tab/spacing issues.
I have tested the above patch on DragonFly building and packaging
subversion and pkglint and their many dependencies.
I have also tested USE_ABI_DEPENDS=no on my NetBSD workstation (where I
have used IGNORE_RECOMMENDED for a long time). I have been an active user
of IGNORE_RECOMMENDED since it was available.
As suggested, I removed the documentation sentences suggesting bumping for
"security" issues.
As discussed on tech-pkg.
I will commit to revbump, pkglint, pkg_install, createbuildlink separately.
Note that if you use wip, it will fail! I will commit to pkgsrc-wip
later (within day).
automatically by pthread.buildlink3.mk. Also, factor out the pthread
library out of PTHREAD_LDFLAGS into a standalone variable PTHREAD_LIBS
and use it in packages where necessary (usually the ones that don't
have a GNU configure script).
"Your tests in configure to decide if you need each of the functions are
testing a different variable name from the one that gets set so you always
create an rfuncs.h that has all three definitions even if you dont need them,
which leads to problems on systems that provide some but not all of them
natively." Correction by Mark Davies.
Update to revision 1.0.3 to correct mistake where config subdirectory
contained symbolic links:
config.guess -> /usr/pkgsrc/mk/gnu-config/config.guess
config.sub -> /usr/pkgsrc/mk/gnu-config/config.sub
that were a consequence of the tarball being created after a build
inm pkgsrc (files were replaced with symbolic links).
the header file <rfuncs.h> through a compiler flag along with some
unnecessary linker flags. This should hopefully resolve pkg/27631,
security/gpgme dies on configure.
strerror_r(). These are thread safe versions of the corresponding functions
without the "_r". The package is implemented so that it may be used simply
by including it's buildlink3.mk file.
