Commit graph

2523 commits

Author SHA1 Message Date
rillig
410ca72280 When checking a Pathlist, split $value instead of $value_novar. This avoids
many false positive warnings for paths like ${PREFIX}/foo.
2006-06-18 08:43:35 +00:00
rillig
a2e036b02d HEADER_TEMPLATE is deprecated. Added permissions for several JAVA_*
variables.
2006-06-18 08:42:16 +00:00
rillig
097e1b8371 Pathnames should generally not start with a slash. 2006-06-18 08:20:19 +00:00
rillig
9f833e47e8 {DE,}INSTALL_TEMPLATE are deprecated in favor of {DE,}INSTALL_TEMPLATES. 2006-06-18 08:18:18 +00:00
rillig
8ef36cf71a Don't emit a note for missing SUBST_MESSAGE. It's too hard to find a
nice description text for most of the SUBST blocks.
2006-06-18 01:08:08 +00:00
rillig
26dacda906 Don't treat comments as paragraph separators for the SUBST check. See
graphics/xfig for an example where it makes a difference.
2006-06-18 01:01:40 +00:00
rillig
161e740029 Bugfix: Always count the SUBST_SED and SUBST_FILES lines. 2006-06-18 00:51:34 +00:00
rillig
82083b5f83 Added a new check for SUBST blocks. In contrast to all other checks,
this one is defined in PkgLint::SubstContext instead of the main
package. Time will show whether this was a good decision. Since the
checking subroutines heavily modify the fields of the SubstContext, it
seems to be Done Right.
2006-06-18 00:48:47 +00:00
rillig
c4ebc55087 Added OVERRIDE_GNU_CONFIG_SCRIPTS and PYPKGPREFIX. 2006-06-18 00:45:45 +00:00
rillig
88fdf60193 - autofix() may only be called from the checkfile_*() subroutines to avoid
duplicate calls.
2006-06-17 22:46:45 +00:00
rillig
6967adcd13 {DE,}INSTALL_SRC are deprecated because they interfere with the
pkginstall framework.
2006-06-17 19:24:49 +00:00
rillig
551317ca44 - Fixed variable definitions of BUILDLINK_RPATHDIRS.* and PKGPATH.
- The macro __sparc_v9__ is neither defined by gcc nor by SunPro. But
  __sparcv9 is.
- Added some more commands that may be hidden using the "@" character.
- Don't let pkglint get confused by additional magic in the use of
  MASTER_SITES. For example, devel/nspr uses ${MASTER_SITE:S/../../:=foo/}.
2006-06-17 17:09:48 +00:00
rillig
e99786db65 Fixed the adjustment of the directory depth. The last commit to it
(1.611) had broken the check of pkgsrc infrastructure files.
2006-06-17 16:17:12 +00:00
rillig
31c4f77541 Typo (FileMask instead of Filemask). 2006-06-17 16:16:26 +00:00
seb
73311e458f Update to version 1.29
Ensure that libkver.so is loaded if needed via LD_PRELOAD
for all kind of commands run via the chroot target.

This fix PR pkg/32921.

Approved by MAINTAINER.
2006-06-17 12:18:24 +00:00
rillig
7332b1c2cc ${CP} should not be used to install files, since it cannot overwrite
read-only files.
2006-06-17 10:03:09 +00:00
rillig
ed8b654c6f The shell commands ${SED} and ${TR} should not be used in the install
phase.
2006-06-17 09:51:19 +00:00
rillig
43a6e0937f Added the shell commands DELAYED_{ERROR,WARNING}_MSG and SHCOMMENT. 2006-06-16 12:01:38 +00:00
rillig
23797bd2eb USE_TOOLS may be modified in buildlink3.mk. 2006-06-16 09:34:19 +00:00
rillig
25d6c134b4 "exec" is a known shell command. It is one way to suppress the pkglint
warning, but there will be better ones.
2006-06-15 22:50:31 +00:00
rillig
b99fb1367b Since I don't know yet what is the best way to fix the "Unknown shell
command" warnings, they are not enabled by default.
2006-06-15 22:22:13 +00:00
rillig
a1701c2271 In pax(1) command lines, -pe is deprecated in favor of -pp. 2006-06-14 07:44:30 +00:00
jlam
5f9a3a1b99 This package overrides the "update" target (is that wise?) and runs
its own set of commands.  One of these invoked "deinstall" with
UPDATE_RUNNING set to "YES"; however, UPDATE_RUNNING was made into a
pkgsrc private variable a little while ago.  Fix "update" by setting
_UPDATE_RUNNING instead.  This fixes PR pkg/33716.
2006-06-13 13:57:10 +00:00
reed
ca6f7bd78c Update for change of location of sites.mk. 2006-06-12 17:02:23 +00:00
adrianp
8186b1b3a0 Minor typo. 2006-06-10 17:13:11 +00:00
abs
d4dac6f718 update pkg_chk to 1.75
- match bsd.own.mk logic for determining MAKECONF, as requested by Joerg
2006-06-09 16:43:33 +00:00
rillig
37c752009e - Added "read" to the list of allowed shell commands.
- Added an explanation for the ${WRKSRC}/.. warning, since it is not
  documented anywhere else.
- Improved two diagnostics for buildlink3.mk files.
- Added a check to discover package name mismatches in
  BUILDLINK_{ABI,API}_DEPENDS, as well as the version numbers.
2006-06-09 16:21:26 +00:00
jlam
2cc3f64abb Add a new variable CHECK_FILES_SUPPORTED which is a package-settable
variable to show whether the package supports running the check-files
target.

Set CHECK_FILES_SUPPORTED to "no" in pkgtools/pkg_install in the case
where the PREFIX does not match ${LOCALBASE} it's likely the tools are
being installed in some place that's completely outside pkgsrc control,
and check-files fails horribly in that case.
2006-06-09 16:12:08 +00:00
joerg
cd7e14d312 Uses libintl, so depend on it. Bump revision. 2006-06-09 10:45:54 +00:00
rillig
ec002f76a4 I prefer #none over #empty in USE_LANGUAGES. 2006-06-09 10:27:09 +00:00
rillig
0de71f46c0 In the SCST_COND state, a shell command is expected, so check here for
known and unknown commands, too.
2006-06-09 08:53:28 +00:00
rillig
57bc43dae5 Minor improvements. 2006-06-09 07:29:15 +00:00
rillig
250173f09c The old syntax for List+ and InternalList+ does not exist anymore. 2006-06-08 22:31:25 +00:00
rillig
80caf0f15b - Fixed a typo in a diagnostic message from the buildlink3.mk check.
- Added a warning for "Preformatted manual page without unformatted one".
2006-06-08 18:22:46 +00:00
rillig
d4ada473b5 Contrary to my (and maybe to others') expectations, INFO_FILES does
_not_ have the data type "List of Pathname", but "Yes".
2006-06-08 18:21:14 +00:00
rillig
e3fac959be Renamed $plist, $descr and $message to $lines, as it already is in the
other checkfile_* subroutines.
2006-06-08 17:59:23 +00:00
rillig
ac0b15a263 Packages that install info files should set INFO_FILES. 2006-06-08 17:38:56 +00:00
rillig
ef2af6d8a6 Added explanations for two issues Tron stumbled upon when fixing the
warnings in devel/glib. Also, made the diagnostics for buildlink3.mk
files clearer.
2006-06-08 17:21:28 +00:00
rillig
5a8c02e2ea The ">&" shell operator is recognized correctly. A warning is printed
for every shell command that is not known in the tools framework.
2006-06-08 15:56:00 +00:00
rillig
ce495ca3b0 Minor improvements. 2006-06-08 15:50:54 +00:00
rillig
9f330148b3 Some things from the TODO list have been done. 2006-06-08 15:14:22 +00:00
rillig
c75f288cbd Only adjust the directory depth if there are exactly two leading ".."
path components. The old behavior has led to error messages while
checking the files in mk/flavor/pkg.
2006-06-08 07:15:27 +00:00
rillig
61eb32c234 PKGREVISION does not need the :Q operator. The various *_MSG shell
commands may be hidden with "@".
2006-06-08 07:11:26 +00:00
rillig
9863ec1f94 Replaced the explicit permission [*:a] with [$list], which prevents
buildlink3.mk and builtin.mk files from  modifying these variables.
2006-06-08 07:10:19 +00:00
abs
867a7377dc Update pkg_chk to 1.74
1.73 was completely broken.. but only after checking in.
	ahh... Unwanted expansion of RCS tags, I know ye well...
2006-06-07 16:27:14 +00:00
abs
b1ee560908 update pkg_chk to 1.73:
- Handle new way of building BUILD_VERSION, by doing less ourselves
  and (ab)using the pkgsrc infrastrafructure. Jump through some
  hoops to ensure a package is not reported as different due to
  BUILD_VERSION format versions (assuming the package is identical
  otherwise). Only -B affected.
2006-06-07 13:52:39 +00:00
rillig
119924e6f3 The .include lines in mk/tools/bsd.tools.mk changed, hence pkglint
didn't know the tools from the TOOLS framework anymore. Fixed that and
added some code that will detect such a change in the future.
2006-06-06 16:00:49 +00:00
rillig
3ee159f988 Completed the recent change by Stoned, who overlooked a second instance
of bsd.sites.mk in a comment.
2006-06-06 11:41:40 +00:00
rillig
1e457582de A variable that appears as a whole shell word may either be used as a
list of shell words, or sometimes as a single shell word. Compare: ${LD}
${LDFLAGS} and ./configure -libs ${LDFLAGS:Q}. So in this case, the :Q
operator cannot be checked reliably.
2006-06-06 11:39:25 +00:00
rillig
281a32dde2 Some small refinements. 2006-06-06 11:37:31 +00:00