Performing substitutions during post-patch breaks tools such as mkpatches,
making it very difficult to regenerate correct patches after making changes,
and often leading to substituted string replacements being committed.
pkglint -Wall -r --autofix --only aligned
After running the above command, three packages had to be adjusted
manually:
In maelstrom-x11, pkglint didn't see that a commented variable
assignment should have been re-aligned as well.
In netmaze, there was a single line that didn't align well with all the
others, but pkglint decided to adjust the whole paragraph to this single
line. The result would have been ok, but not good.
In tscp, there was a paragraph where some of the lines were indented
one space more than the others. This rule is useful when one variable
name is very long compared to the others, but not in this case.
either because they themselves are not ready or because a
dependency isn't. This is annotated by
PYTHON_VERSIONS_INCOMPATIBLE= 33 # not yet ported as of x.y.z
or
PYTHON_VERSIONS_INCOMPATIBLE= 33 # py-foo, py-bar
respectively, please use the same style for other packages,
and check during updates.
Use versioned_dependencies.mk where applicable.
Use REPLACE_PYTHON instead of handcoded alternatives, where applicable.
Reorder Makefile sections into standard order, where applicable.
Remove PYTHON_VERSIONS_INCLUDE_3X lines since that will be default
with the next commit.
Whitespace cleanups and other nits corrected, where necessary.
to address issues with NetBSD-6(and earlier)'s fontconfig not being
new enough for pango.
While doing that, also bump freetype2 dependency to current pkgsrc
version.
Suggested by tron in PR 47882
upstream change announcement:
December 04, 2009: PySolFC v.2.0 (1061 games) and PySolFC-Cardsets v.2.0 (153 cardsets)
the license was changed to the GPLv3 or newer
13 new games
migration to new python-ttk module
improved look of the deck (required python-imaging v.1.1.7)
fixed Hanafuda games (ticket)
new config-file option: sound_sample_buffer_size (ticket)
portable version for windows (ticket)
many other bugfixes
problem wiz stumbled upon only occurs if py-imaging is installed and
py-imagingtk is not. pysolfc assumed that if py-imaging was installed,
py-imagingtk was also installed. patch-ac corrects this by simply
disabling the runtime detection of these optional dependencies.
The real issue, it seems to me, is that py-imaging installs ImageTk.py,
which needs py-imagingtk to be useful. This is why pysolfc got
confused. pkgsrc should probably be changed to install ImageTk.py in
the py-imagingtk package instead, but I'd rather not audit all
py-imaging users right now, so I'll leave that for someone else.
Bump PKGREVISION to 4.
