Upstream changes:
[1.109] Released on 2010-08-29
Bug Fixes:
* ValuesAndExpressions::RequireInterpolationOfMetachars fix due to
changes in Email::Address 1.890. Note that this may find problems
in code that it didn't before, e.g. q<'@foo'>.
to trigger/signal a rebuild for the transition 5.10.1 -> 5.12.1.
The list of packages is computed by finding all packages which end
up having either of PERL5_USE_PACKLIST, BUILDLINK_API_DEPENDS.perl,
or PERL5_PACKLIST defined in their make setup (tested via
"make show-vars VARNAMES=..."), minus the packages updated after
the perl package update.
sno@ was right after all, obache@ kindly asked and he@ led the
way. Thanks!
pkgsrc changes:
- adjust dependencies
Upstream changes:
[1.108] Released on 2010-06-22
This is the "Give Shawn Moore what we promised him a year ago and hurry up
and get this out before Brad Oaks gives his YAPC::NA talk" release.
New Policies:
* Documentation::RequirePodLinksIncludeText
* Subroutines::ProhibitUnusedPrivateSubroutines
New Features:
* There is a new global configuration item, 'program-extensions', which
configures Perl::Critic's idea of which file name extensions represent
programs. The desired extensions are specified as a space-separated list,
with leading '.' on each if that is desired. Files whose names end in
'.PL' will always be considered programs. This can be overridden by
command option --programs-extensions, which can be specified multiple
times.
* There is now a perlcritic --allow-unsafe switch. Without this switch,
Perl::Critic will silently refuse to load any Policy that is marked
unsafe. Unsafe Policies are usually ones that may compile or execute
untrusted code (see Perl::Critic::DynamicPolicy for an example); Policy
authors can mark their policies as unsafe by overriding the is_safe()
method.
* The framework that we use to test Perl::Critic Policies has been
packaged into a convenient module that you can use to test your own
Policies. See Test::Perl::Critic::Policy and Perl::Critic::TestUtils
for details.
Policy Changes
* BuiltInFunctions::ProhibitLvalueSubstr no longer complains when there
is a low-precedence operator between the substr() and the assignment
operator.
* CodeLayout::ProhibitParensWithBuiltins now allows 'state ($foo)'. RT
#52029
* ErrorHandling::RequireCarping now has an
allow_in_main_if_not_in_subroutine option to allow "die" directly in
the default namespace.
* InputOutput::RequireBriefOpen now recognizes CORE::open(),
CORE::close(), CORE::GLOBAL::open(), and CORE::GLOBAL::close(). RT
#52391
* Modules::ProhibitEvilModules now complains by default about the modules
deprecated by the Perl 5 Porters in 5.12.
* Modules::RequireVersionVar documentation updated to make clear that "my
$VERSION" does not work as a module version declaration. RT #56667
* The RegularExpressions::* policies have been converted from using
Regexp::Parser to using PPIx::Regexp for their heavy lifting.
* RegularExpressions::ProhibitCaptureWithoutTest now allows capture
variables inside when() {}. RT #36081.
* RegularExpressions::ProhibitUnusedCapture now checks for unused named
captures.
* Subroutines::ProhibitManyArgs revised to count only characters in the
prototype that represent arguments. RT #56627
* Subroutines::ProhibitNestedSubs no longer complains about scheduled
blocks (BEGIN, etc.) inside subroutines and vice versa.
* Subroutines::RequireFinalReturn should now understand a final given/when
statement, and declare an error if there is no 'default' block or if any
branch does not return.
* TestingAndDebugging::RequireUseStrict now accepts 'use 5.011' or greater
as equivalent to 'use strict'.
* ValuesAndExpressions::ProhibitMismatchedOperators false positive with
"'foo' x 15 . 'bar'". RT #54524
* Variables::ProhibitPunctuationVars gave false positives on qr// regexp's
ending in '$'. RT #55604
Bug Fixes:
* The "## no critic" annotations now respect #line directives.
* Annotations on statements spanning more than one line (e.g.
my $foo =
'$bar'; ## no critic (RequireInterpolationOfMetachars)
) are now handled as single-line annotations, not block annotations.
* All instances of L<Foo> in the POD have been changed to L<Foo|Foo>.
L</bar> and L<Foo/bar> were allowed to stand. RT #37485
* Spaces are now allowed immediately inside the enclosing parentheses in
"## no critic ( Foo )". RT #52038
* With the introduction of PPIx::Regexp, Perl::Critic no longer dies
when it encounters a Perl 5.010 regexp. RT #49442.
* DEVELOPER.pod typo in link to
ValuesAndExpressions::ProhibitConstantPragma policy. RT #57818
* Spelling errors in documentation. RT #57375
* "die" used instead of "croak". RT #56619
* Fixed regex test that caused test failures on every Perl 5.11
(credit Tom Wyant).
* t/20_policy_pod_spelling.t now works (or at least no longer fails)
in non-English locales (again). RT #43291 and RT #48986.
* Perldoc hae broken link for McCabe score definition. RT #53219
* RT #33935 and #49679 were fixed by upgrading to PPI 1.208
Other Changes:
* Perl::Critic::Utils::is_unchecked_call() updated to include chmod in the
set of things covered by autodie (this happened in autodie v2.08). The
primary effect of this is on InputOutput::RequireCheckedSyscalls.
* Now depends upon Task::Weaken to ensure that we only install with perls
where Scalar::Util::weaken() works.
* Email::Address was optional, but is now required. So everyone
gets the optimal behavior from RequireInterpolationOfMetachars.
* Some infrastructure has been extracted to the new PPIx-Utilities
distro. It is also a required dependency here. Over time a good
portion of Perl::Critic::Utils* will be migrated to this distribution.
* Perl::Critic::Utils::PPI::get_constant_name_element_from_declaring_statement()
is deprecated because it doesn't handle multiple constants being
declared within a single "use constant" statement. Use
PPIx::Utilities::Statement::get_constant_name_elements_from_declaring_statement()
instead.
* Removed all uses of Perl::Critic::Utils::PPIRegep. Since the
PPIx::Regexp update, Perl::Critic only used get_match_string() and
friends, which were superseded by the corresponding PPI methods.
Perl::Critic now depends on PPI-1.208 or newer.
* Moved Perl::Critic::Utils::PPIRegexp to the Perl-Critic-Deprecated.
* The PolicySummary.pod file is now generated when the distribution
is created, rather than when you install it. This ensures the file
will be available on http://search.cpan.org. Thanks to Bear Longyear
for bringing this to our attention.
[1.107_001] Released on 2010-06-20
Changes summarized into 1.108 above. For exact details, see Changes on
BackPAN.
Pkgsrc changes:
- adjust dependencies wrt to minimum required perl package version
Upstream changes:
[1.106] Released on 2010-05-10
Bug Fixes:
* NamingConventions::Capitalization fix for PPI 1.212. RT #57348
Upstream changes:
[1.105] Released on 2009-09-07
Bug Fixes:
* Variables::ProhibitPunctuationVars would complain about "%-" appearing
anywhere in a string. RT #49016
Policy Changes:
* InputOutput::RequireCheckedSyscalls now complains about unchecked "say"
by default. RT #37487
Pkgsrc changes:
- Adjust/fix dependencies
Upstream changes:
[1.104] Released 2009-08-23
This release is dedicated to Tom Wyant in appreciation of the amount of
effort he put into the enhancements and bug fixes in this release, for
having the patience to wait for the amount of time that it took to get
them out, and for overall awesomeness. Thank you, Tom.
New Policies:
Objects::ProhibitIndirectSyntax
ValuesAndExpressions::ProhibitComplexVersion
ValuesAndExpressions::RequireConstantVersion
New Optional Requirement:
* Email::Address, if you want
ValuesAndExpressions::ProhibitInterpolationOfLiterals to properly ignore
emaila addresses.
New Features:
* Perlcritic will list the names of files with violations if given the
--files-with-violations option, or the names of files without
violations if given the --files-without-violations options. These
have synonyms -l and -L respectively.
* Perlcritic has a new --list-enabled option, which lists the Policies
that will be enforced, given the current configuration. This is
useful if you've written a complex command-line or modified your
.perlcriticrc file and you want to see which Policies *would*
be used with the current configuration, if you were actually going
to critque a file with it.
* Perl::Critic::Violation now takes #line directives into account in the
%F, %f, and %l formats. You can get the old values via the new %G, %g,
and %L formats.
Policy Changes:
* CodeLayout::ProhibitParensWithBuiltins was complaining in certain cases
where parentheses are required due to operator precedence. RT #46862.
* ControlStructures::ProhibitMutatingListFunctions no longer complains
about uses of tr/// that don't modify the operand. Reported by EDAVIS,
RT #44515.
* Miscellanea::RequireRcsKeywords now accepts "qw$Keyword: ...$". RT
#45196.
* Modules::RequireFilenameMatchesPackage now respects logical filenames
defined by the "#line" directives. This allows the Policy to work
properly with IDEs and code generators.
* NamingConventions::Capitalization now allows fully qualified subroutine
declarations ( e.g. "sub Foo::Bar::baz {...}" ). However, the
non-package part of the subroutine name must still conform to whatever
capitalization rule you have chosen.
* RegularExpressions::ProhibitCaptureWithoutTest no longer complains if
the regex is followed by an "or die" or similar. Reported by EDAVIS,
RT #36081.
* RegularExpressions::ProhibitComplexRegexes no longer counts variable
substitutions in the length. Reported by EDAVIS, RT #36098.
* RegularExpressions::ProhibitUnusedCapture now considers the body of
while loops and not just their condition. Reported by EDAVIS, RT
#38942.
* ValuesAndExpressions::ProhibitInterpolationOfLiterals can now properly
ignore email addresses if you have Email::Address installed.
* ValuesAndExpressions::ProhibitVersionStrings was getting confused by
comments. Reported by Kevin Ryde, RT #44986.
* ValuesAndExpressions::RequireInterpolationOfMetachars now allows sigils
in the arguments to "use vars". Contributed by Kevin Ryde, RT #47318.
* ValuesAndExpressions::RequireInterpolationOfMetachars now properly
ignores email addesses, if you have Email::Address installed. Inspired
by the Kevin Ryde contribution in RT #47318.
* Variables::ProhibitPunctuationVars gained the ability to look inside
interpolated strings. Doing this correctly is challenging and things
may not work out right; how the policy does this can be controlled via
the new "string_mode" option. Contributed by Edgar Whipple
<perlmonk at misterwhipple dot com>.
* Variables::ProhibitPunctuationVars now ignores $] by default since there
is no English.pm equivalent.
Other Bug Fixes:
* Perl::Critic::Utils::parse_arg_list() was slurping up the "or die ..."
portion of "open my $foo, 'somefile' or die ...", causing
InputOutput::ProhibitTwoArgOpen to not complain about this example.
Reported by Alexandr Ciornii, RT #44554.
Minor Changes
* The line count emitted by the --statistics option is further broken down
by line content.
Minor Documentation Fixes:
* ValuesAndExpressions::ProhibitInterpolationOfLiterals. Reported by
Debian in http://bugs.debian.org/542814, RT #48936
Build Fixes:
* There wasn't a specific version given for the List::MoreUtils dependency
and we're using features that weren't avialable until 0.19. So, we now
require version 0.19. Noticed by John J. Trammell, RT #48917.
* Some tests were tied to the specific "true" and "false" values that some
functions were returning. Reported by Michael Schwern, RT #43910.
Other News:
* Komodo version 5.1.1 now has built-in support for Perl-Critic,
if you have the Perl::Critic and criticism modules installed.
Both should be available through the ActiveState Perl Package
Manager ppm(1).
pkgsrc changes:
- Adjusting dependency information according to META.yml
Upstream changes:
[1.103] Released on 2009-08-03
Fix configure_require prerequisite on Module::Build 0.34_02.
[1.102] Released on 2009-08-03
Bug fixes:
* Works with PPI 1.205. Yay for 5.10 support!
* Variables::RequireLexicalLoopIterators didn't work correctly on foreach
loops with labels.
[1.101_003] Released on 2009-07-22
[1.101_002] Released on 2009-07-21
[1.101_001] Released on 2009-07-21
Changes summarized into 1.102 above. For exact details, see Changes on
BackPAN.
- Updating package for p5 module Perl::Critic from 1.098 to 1.100
- removing options for recommended dependencies - require them all
- Adding license (perl license)
Upstream changes:
[1.100] Released on 2009-07-17
This is a POD fix release to deal with issues identified by Test::POD
1.40. There is no functional difference between this release and 1.098.
This is the last release of Perl::Critic that will be compatible with PPI
1.203. PPI's parsing of for(each)? loops is changing in its next release
in an incompatible manner and there will be a release in the near future
to make Perl::Critic compatible with that change.
- Updating module to 1.098
- Allow to select recommended dependencies using options framework
Upstream changes:
[1.098] Released on 2009-03-07
Some Exciting News:
The Perl Development Kit (PDK 8.0) from ActiveState now includes a
very slick graphical interface to Perl-Critic. I highly recommend
that you check it out. Here's a link to screenshots and docs:
http://docs.activestate.com/pdk/8.0/PerlCritic_gui.html
New Features:
* Violation coloring is now configurable via command line or profile. The
profile entries are color-severity-highest, -high, -medium, -low, or
-lowest. Numbers are accepted in lieu of named severities (e.g.
'color-severity-5' for 'color-severity-highest'), and 'colour' is
accepted in lieu of 'color'.
* Handling of unrecognized policy configuration items is now controlled by
the profile_strictness. The default is to warn about them. The previous
default was that they were fatal.
* -p is now a synonym for --profile.
* The --verbose option for perlcritic now supports a %C format that will
displays the class of PPI::Element that caused the violation.
Policy Changes:
* ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions
didn't include "pbp" in its default themes even though it is derived
from the book. Now it does. :]
* ErrorHandling::RequireCarping now allows a here document as the last
element if the "allow_messages_ending_with_newlines" option is true.
* Fix Subroutines::ProhibitAmpersandSigils so it allows "defined(&x)" as
well as "defined &x". Patch from Kevin Ryde, RT #38855.
* Subroutines::ProtectPrivateSubs now has an "allow" option to specify
subroutines which are exempt from this policy. RT #38678.
Additionally, a "private_name_regex" option has been added that allows
you to specify what a private subrouting name looks like.
* Subroutines::RequireArgUnpacking now has an "allow_subscripts" option
to allow array slices and elements. RT #34009.
* Subroutines::RequireArgUnpacking now has an "allow_delegation_to" option
to allow the usual delegation idiom. Delegation to 'SUPER::' and
'NEXT::' are allowed by default. RT #33839.
* Subroutines::RequireArgUnpacking no longer generates a false positive
for '$$_[]', which is an obfuscated way of saying '$_->[]'. RT #37713.
* ValuesAndExpressions::ProhibitMagicNumbers now has an
allow_to_the_right_of_a_fat_comma option, which defaults to true. Note
that it currently only works /directly/ to the right of a fat comma.
* Variables::ProhibitMatchVars had its default themes changed to "core
performance pbp", instead of "core bugs pbp" because, while the match
variables make regular expressions slow, it doesn't cause them to not
work correctly.
* Variables::ProhibitPackageVars has had FindBin and Log::Log4perl added
to the default exemptions.
* Variables::ProhibitReusedNames now has an "allow" option to specify
names that can be reused. It defaults to enabling $self and $class. RT
#42767.
* Variables::RequireLocalizedPunctuationVars has a customizable set of
exemptions via the "allow" option.
New Developer Features:
* The guts of perlcritic have been moved to Perl::Critic::Command. You
can invoke Perl::Critic::Command::run() to get the equivalent of running
the command. (Note, however, this interface WILL change, so don't count
on the current one.)
* Modules have had a "INTERFACE SUPPORT" section added which states
whether the Perl::Critic developers consider the particular module is
public or not. Any removal of functionality from a public module will
go through a deprecation cycle. Non-public modules may have their
interfaces changed without notice.
* P::C::Policy now has an is_enabled() method.
* P::C::Violation now has an element_class() method.
Bug Fixes:
* CodeLayout::ProhibitTrailingWhitespace didn't notice cases where PPI
would produce instances of PPI::Token::Whitespace that contained
multiple lines.
* Subroutines::ProtectPrivateSubs no longer regards the exportable POSIX
subroutines whose names begin with underscore as private. RT #38678.
* Subroutines::RequireArgUnpacking mishandled a complicated sitation with
$_ being an array reference. RT #39601.
* Variables::RequireLocalizedPunctuationVars now applies to subscripted
names. RT #29384.
Internals:
* The guts of Build.PL and Makefile.PL have been rearranged.
[1.097_002] Released on 2009-03-01
[1.097_001] Released on 2009-03-01
Changes summarized into 1.098 above. For exact details, see Changes on
BackPAN.
[1.096] Released on 2009-02-01
New Policies:
* ValuesAndExpressions::ProhibitSpecialLiteralHeredocTerminator
Policy Changes:
* Documentation::PodSpelling now has a stop_words_file option.
* Modules::ProhibitEvilModules now has a modules_file option.
Bug Fixes:
* ErrorHandling::RequireCarping will now allow a literal newline
as well as "\n". Fixed by Kyle Hasselbacher, RT #25046
* Fix InputOutput::ProhibitTwoArgOpen so it allows '-|' or '|-' as the
second of two arguments. Patches from Kyle Hasselbacher and Leland
Johnson, RT #42384.
* InputOutput::RequireBracedFileHandleWithPrint applies to printf as well
as print. Fixed by Kyle Hasselbacher, RT #42537.
* TestingAndDebugging::RequireUseStrict and
TestingAndDebugging::RequireUseWarnings are no longer fooled by a
block-scoped pragma. RT #42310.
* ValuesAndExpressions::RequireInterpolationOfMetachars allows for escaped
backslashes. Fixed by Tom Wyant, RT #38530.
* Fix for problem in P::C::Document in dealing with underscores in
expressions like "use 5.009_001". Patch by Kevin Ryde, RT #36570 and
#42089.
* Fix in extras/perlcritic.el for a radio button. Patch by Kevin Ryde, RT
#42190.
* Fix distclean target in Makefile.PL. Patch by Richard Soderberg,
RT #42088.
* Fix temporary files not being cleaned up after tests. Patch by Kyle
Hasselbacher, RT #41443.
* Deal with changes in Pod::Parser v1.36 in test in t/05_utils_pod.t.
Documentation improvements contributed by Mark Grimes in response to RT
#41942.
[1.095_001] Released on 2009-01-18
Changes summarized into 1.096 above. For exact details, see Changes on
BackPAN.
Oked by rhaen@
Pkgsrc changes:
o Change to Module::Build
Upstream changes:
[1.094001] Released on 2009-01-01
Bug Fixes:
* Tests would fail on systems without Regexp::Parser installed.
[1.094] Released on 2009-01-01
Incompatible Changes:
* The way that "## no critic" markers was refactored. As
a result, we discovered that the syntax for the markers was pretty
vague. If you didn't do it just right, it would disable all policies,
and not just the specific ones that you wanted. So we've tightened this
up a bit. If you followed the examples that have been in the docs for
the last couple years, then you should be fine. But if you've been
using certain other variations in your "## no critic" markers, then you
might suddenly find yourself violating the new
ProhibtUnrestrictedNoCritic policy. To fix this, just make sure your
Policy names appear in parentheses:
## no critic Foo, Bar, Baz # wrong!
## no critic Foo Bar Baz # wrong!
## no critic (Foo, Bar, Baz) # ok!
## no critic qw(Foo Bar Baz) # also ok!
* The deprecated $FORMAT variables for Perl::Critic::Policy and
Perl::Critic::Violation no longer exist. Use the corresponding
get_format() and set_format() functions instead.
New Policies:
* Miscellanea::ProhibitUnrestrictedNoCritic
* Miscellanea::ProhibitUselessNoCritic
* NamingConventions::Capitalization
* Subroutines::ProhibitReturnSort
* Variables::ProhibitReusedNames
Removed Policies:
* NamingConventions::ProhibitMixedCaseSubs and
NamingConventions::ProhibitMixedCaseVars have been moved to a separate
Perl-Critic-Deprecated distribution. The
NamingConventions::Capitalization policy does everything they do, plus
more.
Policy Changes:
* BuiltinFunctions::ProhibitStringyEval now has an allow_includes option
that makes it behave (mostly) like Ricardo SIGNES'
Perl::Critic::Policy::Lax::ProhibitStringyEval::ExceptForRequire.
* InputOutput::RequireCheckedClose, InputOutput::RequireCheckedOpen, and
InputOutput::RequireCheckedSyscalls now all support autodie.
Unfortunately, autodie is currently treated like a module and not a
pragma, which means that the lexical scoping is not taken into account.
* InputOutput::RequireCheckedSyscalls now has an exclude_functions
parameter.
* Modules::ProhibitEvilModules now allows you to specify what the
description of a use of a bad module should be, to, say, suggest that
people use autodie instead of Fatal.
* Subroutine::ProhibitExcessComplexity violation descriptions now include
the name of the subroutine, thanks to Andreas Koenig, RT #40070.
* TestingAndDebugging::RequireUseStrict and
TestingAndDebugging::RequireUseWarnings now have equivalent_modules
parameters that allow you to designate other modules as being equivalent
to the strict and warnings pragmata. This one is for all you Moose fans
out there. :]
Bug Fixes:
* ControlStructures::ProhibitUnreachableCode would treat package
statements as unreachable. Fixed by Kevin Ryde. RT #41734
* Fix warning from InputOutput::ProhibitOneArgSelect when select was
called with no arguments. RT #41926
* Miscellanea::RequireRcsKeywords couldn't find keywords after __END__
that didn't look like part of POD.
* Modules::RequireFilenameMatchesPackage would incorrectly complain about
programs. Yet more greatness contributed by Schwern. RT #39024.
* If a perlcriticrc file referred to a policy that wasn't installed and
the profile-strictness option was set to "fatal",
Perl::Critic::PolicyFactory fell over instead of reporting the
problematic policy name.
Miscellanea:
* Perl::Critic::Violation will automatically strip trailing periods
from your Policy description and explanation strings. This ensures that
the punctuation is consistent with the format specified by the user via
the -verbose formatting options.
New Developer Features:
* Perl::Critic::Policy::prepare_to_scan_document() is now checked and a
Policy can disable itself for just a single document, which can speed
things up.
[1.093_03] Released on 2008-12-11
[1.093_02] Released on 2008-10-30
[1.093_01] Released on 2008-09-07
Changes summarized into 1.094 above. For exact details, see Changes in
1.093_003 on BackPAN.
Pkgsrc changes:
o Re-order DEPENDS to match META.yml from package
Upstream changes:
[1.092] Released on 2008-09-02
Bug Fixes:
* Fixed POD errors that were causing build failures. Sorry
about that.
[1.091] Released on 2008-09-01
New Policies:
* RegularExpressions::RequireDotMatchAnything
New Features:
* perlcritic now supports a -pager option, so you can more easily
send the output to your favorite pager. You can set this option
on the command-line or in your .perlcriticrc file. See the
perlcritic perldoc for more details. Credit to Michael Schwern.
* The output from "perlcritic -doc PATTERN" will be automatically
sent to your pager if you have set the -pager option.
Policy Changes:
* CodeLayout::ProhibitQuotedWordLists no longer applies if the list
contains any non-words, by default. A non-word is anything that does
not match /[\w-]+/. You can restore the former behavior by setting the
"strict" option. RT #37886.
* CodeLayout::ProhibitQuotedWordLists also now applies to the import
arguments of a C<use> statement. RT #24467.
* ErrorHandling::RequireCheckingReturnValueOfEval now recognizes ternary
left-sides as valid checks.
* RegularExpressions::RequireExtendedFormatting gains a
minimum_regex_length_to_complain_about option. Also, regexes that
contain only word and whitespace characters are now exempt from this
policy, by default; you can make it complain about them by turning on
the new strict option. Contributed by Michael Schwern. RT #38531.
* TestingAndDebugging::ProhibitNoWarnings now supports a
allow_with_category_restriction option, thanks to Michael Schwern.
RT #38514.
* CodeLayout::ProhibitHardTabs now allows leading tabs in qw() word lists
and regexes with the /x modifier. You can still configure this
policy to forbid all hard tabs, if you like. RT #32440
Bug Fixes:
* perlcritic should now work under PAR. RT #38380.
* URL for our repository in META.yml now works for anonymous
checkout. The password is "" (empty). RT #38628.
* color for high-severity violations is now magenta because
it is more redable than yellow on white backgrounds. RT #38511.
to trigger/signal a rebuild for the transition 5.8.8 -> 5.10.0.
The list of packages is computed by finding all packages which end
up having either of PERL5_USE_PACKLIST, BUILDLINK_API_DEPENDS.perl,
or PERL5_PACKLIST defined in their make setup (tested via
"make show-vars VARNAMES=...").
Pkgsrc changes:
o Adjust dependencies to match new requirements
Upstream changes:
[1.090] Released on 2008-07-22
Bug Fixes:
* Test was incorrectly failing when Regexp::Parser wasn't installed.
[1.089] Released on 2008-07-21
Minor Enhancements:
* -s is now a synonym for --single-policy.
Policy Changes:
* Subroutines::ProhibitBuiltinHomonyms now also prohibits subroutines
with the same name as a Perl keyword (e.g. if, foreach, while).
Inspired by RT #37632.
* Subroutines::ProtectPrivateSubs now allows expressions like
"shift->_some_private_method();". Note that this *only* applies
to the "shift" function -- a private method call on the right of any
other bareword still causes a violation. RT #34713.
* Subroutines::RequireFinalReturn now includes exec in the set of things
that mark a successful return. RT #37672
* ValuesAndExpressions::ProhibitInterpolationOfLiterals now takes a
allow_if_string_contains_single_quote option. Contributed by Ed
Avis <ed@membled.com>. RT #36125.
* ValuesAndExpressions::RequireInterpolationOfMetachars now supports a
rcs_keywords option to allow for the common case where those require
dollar signs.
Bug Fixes:
* BuiltinFunctions::ProhibitSleepViaSelect would complain if there were
three undefs as arguments to select(), but one of them was the timeout.
RT #37416.
* Reduced false positives in
RegularExpressions::ProhibitSingleCharAlternation. Thanks to
Andy Lester and Elliot Shank test cases.
* RegularExpressions::ProhibitUnusedCapture would complain if there were
multiple captures used in a substitution, e.g. s/(.)(.)/$2$1/.
* Subroutines::ProhibitAmpersandSigils no longer complains about
"sort &foo(...)".
* Makefile.PL, Build.PL and other ".PL" scripts which typically do not
have a shebang are no longer mistaken as modules. This prevents
spurious warnings from Modules::RequireEndWithOne. RT #20481.
Internals:
* Tests are now self compliant.
[1.088] Released on 2008-07-04
New Policies
* ErrorHandling::RequireCheckingReturnValueOfEval
Policy Changes:
* ValuesAndExpressions::ProhibitLeadingZeros now accepts octal numbers
for the Unix permissions argument to chmod, dbmopen, mkdir, sysopen, or
umask, by default. Use the "strict" option to get the old behavior.
RT #31977.
* Due to the consensus at YAPC::NA 2008,
Variables::ProhibitUnusedVariables default severity has been raised to
medium/3.
Minor Changes:
* The perlcritic "--Version" option is now "--version" in order to act
like the rest of the world.
[1.087] Released on 2008-06-21
Policy Changes:
* CodeLayout::ProhibitParensWithBuiltins no longer complains about
sort(foo(@x)).
* TestingAndDebugging::RequireUseWarnings will not complain about files
that contain a "use 5.005" statement or similar for perls prior to 5.6.
Lesson of the day: computer conferences where you can meet in the real
world can clarify conversations greatly. Good to finally meet you Adam.
* InputOutput::ProhibitTwoArgOpen similarly will not complain if there's
a "use/require 5.005" statement in the file. RT #34385.
Bug fixes:
* Perl::Critic can now critique a file named "0". However, PPI will give
a parse error until the next version comes out. Fixes RT #36127.
* Moved detection of the lack of any enabled Policies from P::C::Config
to Perl::Critic. This was causing the perlcritic.t in Parrot to fail.
Note, however, there are plans afoot to change how Perl::Critic is
configured and things that depend upon that may break. Please contact
users@perlcritic.tigris.org and tell us how you're using P::C::Config
directly so that we can take your needs into account.
[1.086] Released on 2008-06-12
Policy Changes:
* NamingConventions::ProhibitAmbiguousNames now specifies the name that
it had problems with in its violation descriptions.
Bug fixes:
* The color option wasn't being correctly set from a .perlcriticrc.
RT #36569.
Minor changes:
* --colour is now a synonym for --color.
[1.085] Released on 2008-06-07
New Policies:
* Documentation::RequirePackageMatchesPodName
Policy Changes:
* Variables::ProhibitUnusedVariables detects a few more cases. It's
still very limited, though.
Bug fixes:
* ControlStructures::ProhibitUnreachableCode didn't notice "until" was an
conditional expression.
Minor documentation updates.
[1.084] Released on 2008-05-24
New Features:
* perlcritic now supports a --list-themes option.
* You can specify the maximum number of violations you want per Policy
per document. Developers can give a default value for this for a
Policy by overriding default_maximum_violations_per_document().
See RequireUseStrict and ProhibitMagicNumbers for examples.
Policy Moved:
* The ValuesAndExpressions::ProhibitMagicNumbers policy has been moved
from Perl::Critic::More into the primary Perl::Critic distribution.
New Policies:
* Variables::ProhibitUnusedVariables (very dumb, limited initial
implementation.)
* ControlStructures::ProhibitLabelsWithSpecialBlockNames
Contributed by Mike O'Regan. Kickin' ass, Mike.
Policy Changes:
* ControlStructures::ProhibitUnreachableCode now handles the perl 5.10
"//" and "err" operators. RT #36080
* InputOutput::RequireBriefOpen now ignores opens of STDIN, STDOUT,
and STDERR. You're generally trying to make long-lasting global
effects when manipulating these. (RT #35774)
* RegularExpressions::ProhibitUnusualDelimiters now supports an
"allow_all_brackets" option.
* RegularExpressions::RequireBracesForMultiline now supports an
"allow_all_brackets" option.
* TestingAndDebugging::RequireUseStrict now accepts "use Moose::Role"
as equivalent to "use strict". (RT #34838)
* TestingAndDebugging::RequireUseWarnings now accepts "use Moose::Role"
as equivalent to "use warnings". (RT #34838)
* ValuesAndExpressions::ProhibitMagicNumbers now accepts constant
subroutines.
* Variables::ProhibitMatchVars no longer detects "use English;".
This problem is detected in a more clear way by
Modules::RequireNoMatchVarsWithUseEnglish.
* Variables::ProhibitPerl4PackageNames no longer complains about
$'/$POSTMATCH. RT #36059
* Variables::RequireLocalizedPunctuationVars now allows the use of "my".
RT #33937
Bug Fixes:
* No longer falls over if a single file has a parse error.
New Developer Features:
* If a document specifies a minimum perl version, e.g. "use 5.008003",
P::C::Document::highest_explicit_perl_version() will tell you what it
is.
* The parameter to P::C::Policy::initialize_if_enabled is now a
P::C::PolicyConfig object instead of a hash reference.
Minor Changes:
* LOTS of documentation updates.
* A few more statistics are emitted by perlcritic with the --statistics
option.
* perlcritic --profile-proto now includes policy abstracts in its
output.
Prerequisites:
* Now depends upon PPI 1.203.
* New dependency upon version.
[1.083_006] Released on 2008-05-20
[1.083_005] Released on 2008-05-19
[1.083_004] Released on 2008-05-18
[1.083_003] Released on 2008-05-17
[1.083_002] Released on 2008-05-17
[1.083_001] Released on 2008-04-13
Changes summarized into 1.084 above. For exact details, see Changes in
1.083_006 on BackPAN.
[1.082] Released on 2008-03-08
New Features:
* A new metadata system for defining policy parameters/options has been
added. This makes the life of policy authors easier because
configuration validation and parsing can be taken care of
automatically, in most cases. This allows greater integration with
IDEs and allows the perlcritic "--profile-proto" option to produce
better output.
Note: This change does NOT REQUIRE ANY CHANGES to policies outside of
this distribution; they should continue to work as is. However, use
of this facility can reduce the size of your code and provide the
means for tools to discover more about your policy. If this change
does break any of your policies, please let us know.
To learn how to take advantage of this facility, read
Perl::Critic::DEVELOPER and look at the source of any of the
configurable policies included in this distribution.
There is a discussion of the design considerations for this facility in
the source repository under doc/PolicyParameter_Notes.pod.
* Added support for "criticism-fatal" option in your perlcriticrc
file. This will be used by the criticism pragma to cause execution
to abort if the file contains any violations.
New Policy:
* Module::RequireNoMatchVarsWithUseEnglish
Policy Changes:
* Added an allow_last_statement_to_be_comma_separated_in_map_and_grep
option to ValuesAndExpressions::ProhibitCommaSeparatedStatements.
Partial response to http://rt.cpan.org/Public/Bug/Display.html?id=27654.
* ControlStructures::ProhibitPostfixControls gains the ability to have
the flow control statements allowed to be modified. This in response
to RT #29540.
* TestingAndDebugging::RequireUseStrict now accepts "use Moose" as
equivalent to "use strict".
* TestingAndDebugging::RequireUseWarnings now accepts "use Moose" as
equivalent to "use warnings".
Bug Fixes:
* RT #31281 perlcritic doesn't recognize "#!/bin/env perl" shebang
* Replace usage of Unicode property escapes with POSIX character classes
order to restore 5.6 compatability.
* RT #30388 ValuesAndExpressions::ProhibitVersionStrings complained
about numbered directories in "use lib".
* Fixed handling of badly behaved spelling programs in PodSpelling.
[1.081_006] Released on 2008-03-02
[1.081_005] Released on 2007-12-29
[1.081_004] Released on 2007-12-20
[1.081_003] Released on 2007-12-16
[1.081_002] Released on 2007-12-16
[1.081_001] Released on 2007-12-15
Changes summarized into 1.082 above. For exact details, see Changes in
1.081_006 on BackPAN.
[1.080] Released on 2007-11-11
New Features:
* Allow a "## no critic" statement after a shebang on line 1 of a
file. This allows users to block violations that apply to
whole files and still allow shebangs.
New Policies: (funded by a Perl Foundation grant)
* InputOutput::ProhibitExplicitStdin
* RegularExpressions::ProhibitFixedStringMatches
* RegularExpressions::RequireBracesForMultiline
* RegularExpressions::ProhibitUnusualDelimiters
* RegularExpressions::ProhibitUnusedCapture
* RegularExpressions::ProhibitComplexRegexes
* RegularExpressions::ProhibitSingleCharAlternation
* RegularExpressions::ProhibitEscapedMetacharacters
* RegularExpressions::ProhibitEnumeratedClasses
* InputOutput::RequireBriefOpen
* InputOutput::RequireCheckedSyscalls
Other New Policies
* ControlStructures::ProhibitNegativeExpressionsInUnlessAndUntilConditions
Policy Changes:
* Variables::ProhibitConditionalDeclarations now permits you to local-ize
variables in conditional declarations. This makes sense, since
C<local> is actually a variable modifier, rather than a declaration.
Thanks to David Golden for reporting this.
New Developer Features:
* Perl::Critic::Utils::PPIRegexp encapsulates interaction with
the PPI Regexp token classes. Those classes have very sparse
APIs, so this package hides away the ugly fiddling with PPI
internals.
* Added a new optional_modules parameter for the .run syntax.
Bug fixes:
* PPI::Structure::List can now contain multiple children,
so P::C::Utils::parse_arg_list() needs to handle it.
This was done in the process of fixing
http://rt.cpan.org/Ticket/Display.html?id=24924, which was a problem
with TestingAndDebugging::RequireTestLabels.
* ValuesAndExpressions::ProhibitLongChainsOfMethodCalls wasn't resetting
chain length when it ran into the end of a sub-expression.
http://rt.cpan.org/Public/Bug/Display.html?id=30040
* ValuesAndExpressions::ProhibitCommaSeparatedStatements was reporting
false positives when builtins which accept both no and multiple
arguments were involved.
http://rt.cpan.org/Public/Bug/Display.html?id=27654
Internals:
* Removed all use of Carp in favor of exceptions.
Prerequisites:
* Now requires PPI 1.201. A number of workarounds for PPI bugs have been
removed.
* New dependency upon Exception::Class.
Installation:
* Use Devel::CheckOS to see whether Perl::Critic is being installed on
a Solaris system and warn about tar(1) chopping file names off if it
is.
[1.079_003] Released on 2007-10-22
[1.079_002] Released on 2007-10-21
[1.079_001] Released on 2007-10-09
Changes summarized into 1.080 above. For exact details, see Changes in
1.079_003 on BackPAN.
[1.078] Released on 2007-09-19
Restore Perl::Critic::TestUtils::should_skip_author_tests() and
get_author_test_skip_message(). Some Perl::Critic add-on distributions
are using them.
[1.077] Released on 2007-09-15
Note: if you don't have any problems installing Perl::Critic 1.076, there
is no need to upgrade to this version. There are no functionality
changes. This release only contains changes related to installation that
a few people were experiencing.
Minor changes:
* Removed build-time use of Readonly, again, due to problems some people
were having when trying to compile the code by hand, rather than using
CPAN(PLUS)?.
* Don't run author tests if there's a .svn directory present because
users who grabbed the code from the source repository were executing
them and getting failures.
* Don't generate optional, module-hiding test wrappers if author tests
are not enabled.
[1.076] Released on 2007-09-07
It appears from reports on the 1.075_001 release that the subroutine
sigils were indeed the problem. Release to the general populace.
[1.075_001] Released on 2007-09-06
Bug Fixes:
Undo the changes in 1.073 and 1.074. Instead, stop using the subroutine
sigil in import and export lists. It is suspected that the problem lies
with Exporter stripping off ampersands.
[1.074] Released on 2007-09-04
Bug Fixes:
Repeat the Makefile.PL change on
t/generate_without_optional_dependencies_wrappers.PL.
I love CPAN Testers.
[1.073] Released on 2007-09-04
Bug Fixes:
Work around problems with the combination of Exporter & Readonly in
Makefile.PL on some machines.
[1.072] Released on 2007-09-03
Bug Fixes:
* The Makefile generated by Makefile.PL was not syntactically correct
according to some versions of Solaris. Thanks to Diab Jerius
(DJERIUS) for discovery and testing.
* Fixed mis-definition of "quiet" value for the "--profile-strictness"
option.
* Enhanced testing with the absence of optional modules.
[1.071] Released on 2007-08-24
The "Brown Paper Bag" Release
Bug Fixes:
* Tests would not pass in environments that did not have all optional
dependencies installed.
Packages Collection.
The Perl 5 module Perl::Critic is an extensible framework for
creating and applying coding standards to Perl source code.
Essentially, it is a static source code analysis engine. Perl::Critic
is distributed with a number of Perl::Critic::Policy modules that
attempt to enforce various coding guidelines. Most Policy modules
are based on Damian Conway's book Perl Best Practices. However,
Perl::Critic is not limited to PBP and will even support Policies
that contradict Conway. You can enable, disable, and customize
those Polices through the Perl::Critic interface. You can also
create new Policy modules that suit your own tastes.
A front-end script, perlcritic, is provided.
sno
seb
he
joerg