Commit graph

2218 commits

Author SHA1 Message Date
rillig
5fab31e375 - Reworded two occurrences of "unportable". They sounded too harsh. 2006-02-06 10:07:23 +00:00
rillig
f017b5590f - Don't emit an extra warning if a tool should be added to USE_TOOLS. Just
append it to the previous line.
2006-02-06 09:46:42 +00:00
joerg
5911def816 Recursive revision bump / recommended bump for gettext ABI change. 2006-02-05 23:08:03 +00:00
rillig
e47296e901 Readded almost all variables that had been here in the past. We cannot
force the developers to learn all pkgsrc changes every three months, so
it's better to keep the warnings for a much longer time. I don't know
yet what "much longer" exactly means.
2006-02-05 00:05:39 +00:00
rillig
8b2f8a458e Pinned down the collected problems of the current pkglint development. 2006-02-04 04:10:12 +00:00
rillig
0514bb16a6 * Many of the checking routines need some context to provide better
warnings. For example, checkline_foo() may need to know what has
  happened in the file before that line.
2006-02-04 03:39:40 +00:00
rillig
abd8089cf7 - Some tools that are often used as ${TOOLNAME} need to be explicitly
added to the USE_TOOLS variable. When complaning about their direct
  use, add a proper advice.
2006-02-04 03:37:08 +00:00
rillig
05451e4af6 - bsd.prefs.mk does not need to be included before BUILDLINK_DEPMETHOD gets
assigned using the "?=" operator, since these variables are not meant to
  be set by the user.
- Restricted the files that are checked for absolute pathnames in patch
  files.
2006-02-02 20:50:02 +00:00
joerg
41ad43f789 Wish for warning about BUILD_USES_MSGFMT being used without
devel/gettext-lib/buildlink3.mk being included. This is often,
but not always incorrect.
2006-02-02 17:41:57 +00:00
rillig
619bb5ab6e Updated createbuildlink to 3.10.
The last line is now indented with <tab> instead of six spaces. This
prevents many pkglint warnings and also looks better.
2006-01-31 03:35:35 +00:00
rillig
8ade92fcb2 Updated pkglint to 4.55.
Changes since 4.54:
- -Wvarorder works now as expected.
- distinfo files are checked more strictly.
- Reduced the number of false positives.
- Make(1) variables of the form $(...) are detected properly.
2006-01-30 09:35:13 +00:00
rillig
75562fa202 - Added a hack to be able to parse nested make(1) variables like
${TOOL.${t}}. They just extend up to, but not including the next space or
  quote character.
- log_debug() is used for printing debugging info, not log_error().
- Even if NO_CHECKSUM is set, distinfo files may exist if the package has
  patches. Noted by salo.
2006-01-30 01:26:04 +00:00
rillig
16bdee598a - Variables whose name end in DIR, DIRS, FILE, FILES, as well as PATH,
PREFIX, LOCALBASE and PKGNAME may appear in single quotes.
2006-01-29 01:29:38 +00:00
rillig
c99dd61732 - PkgLint::String::substring accepts an undefined second argument.
- Added PkgLint::String::match_all.
- Make(1) variables of the form $(...) are detected properly.
- The shellword parser's state is printed in --debug mode.
- In double quoted strings, normal text is processed faster.
- The proof of concept for match_all is done with finding absolute
  pathnames in patch files.
2006-01-28 12:24:20 +00:00
rillig
6282c39496 - Added a comment above get_regex_plurals, explaining what it does. 2006-01-28 11:19:07 +00:00
rillig
20511917c5 - Added PkgLint::Util::min and PkgLint::Util::max.
- Rewrote PkgLint::String::substring to make it look less like a Brainf***
  program. I guess this will greatly improve execution speed.
2006-01-28 11:18:17 +00:00
rillig
6af5ebf4c7 - Removed PkgLint::Util::match.
- Added PkgLint::Match, which represents the result of matching a regular
  expression against a PkgLint::String.
- Fixed the arguments to substr in PkgLint::String::substring.
- Added PkgLint::String::match.
- Added a proof of concept in checkfile_patch, in the warning about RCS
  tags. Run pkglint -s --klickibunti to see it.
2006-01-28 11:11:49 +00:00
rillig
0d54162e3d - Found the one variable that slipped through when renaming $file to
$fname.
2006-01-27 02:25:52 +00:00
rillig
a45550b4ce - Fixed inconsistent use of white-space. 2006-01-27 00:56:26 +00:00
rillig
825e4abfb6 - Reformatted simple getter/setter methods to save some space. 2006-01-27 00:55:08 +00:00
rillig
48fa42a5a7 - Globally renamed all variables called $file into $fname. The identifier
$file is reserved for variables of the type PkgLint::File.
2006-01-27 00:48:57 +00:00
rillig
f833e97ec7 - Added the two data types PkgLint::File and PkgLint::Location. I will need
them soon.
2006-01-27 00:07:07 +00:00
rillig
3a4982c5f2 - Added the PkgLint::Util::match function that matches a string against a
regular expression and saves the values of the volatile @- and @+ arrays.
2006-01-26 23:05:49 +00:00
rillig
482bedac8b Even in quick-install mode, the self test should be run. 2006-01-26 16:20:45 +00:00
rillig
95d3203cb2 Added a ``quick-install'' target that allows me to install pkglint in three
seconds instead of 40.
2006-01-25 22:04:26 +00:00
xtraeme
391437abe6 Fix false positives about the test that checks for pkg-config files
in WRKSRC. Now it works properly.

Bump to 1.33.
2006-01-25 05:10:00 +00:00
rillig
f43a67d266 - In --debug mode, all variable assignments that occur when the package
Makefile is read in are logged to give further aid in debugging.
- Warnings about PKGNAME and DISTNAME are anchored at line numbers instead
  of the package Makefile.
2006-01-25 00:23:48 +00:00
joerg
fa0e987ec8 Add conditional code to ignore the non-numeric part of an OS version
for the sake of compatibility tests in pkg_add.
E.g. DragonFly versions like
        1.4.0-RELEASE
are reduced to
        1.4.0

This code is currently enabled for DragonFly only.
2006-01-25 00:20:09 +00:00
rillig
365204f1fe - As "set -- $i" is often used for splitting variables, don't warn if shell
variables appear unquoted here.
2006-01-24 20:41:07 +00:00
rillig
4dfa584a87 - In shell variable assignments, no quoting is needed. 2006-01-24 20:26:11 +00:00
rillig
ec6e11887d - Accept "\"...\"" as valid CPP macro, as some old configure scripts need
it that way. In --debug mode, a warning is printed.
2006-01-24 20:07:54 +00:00
rillig
972b1c15e8 - Made the parser for distinfo files stricter. It can catch mismatched
filenames now.
- MD5 checksums are marked as deprecated.
- Warnings from distinfo files now appear correctly sorted.
2006-01-23 01:51:46 +00:00
rillig
f08ac4fcfb - Made -Wvarorder work like stated in the documentation. I had replaced the
wrong ``false'' with $opt_warn_varorder.
- Fixed the detection of $seen_Makefile_common.
2006-01-23 00:04:50 +00:00
rillig
bc1f74eace - Instead of only allowing the :Q modifier for quoting, allow any modifier
that ends in :Q.
- When NO_CONFIGURE ist defined, REPLACE_PERL does not work.
2006-01-22 23:35:04 +00:00
tron
393e2ba708 Update "rpm2pkg" package to version 2.1.1. Changes since 2.1:
- Fixed GCC 4.x build warning (which would have resulted in an error
  with future GCC versions).
- Depend on newer version of "rpm" package to fix build under Mac OS X.
2006-01-21 20:46:29 +00:00
jlam
758d912e33 Update package Makefile now that bsd.pkg.extract.mk is using the
"extract" script for extraction.  Many cases where a custom EXTRACT_CMD
simply copied the distfile into the work directory are no longer
needed.  The extract script also hides differences between pax and
tar behind a common command-line interface, so we no longer need code
that's conditional on whether EXTRACT_USING is tar or pax.
2006-01-21 18:57:40 +00:00
rillig
6abf92a1f4 Updated pkglint to 4.54.
Changes since 4.53:
- Added about 50 new variables to be type-checked.
- For unknown variables, the type is guessed from the variable name.
- In patch files that patch Makefiles, added lines are checked for
  absolute pathnames.
- Replaced the -Wdebug option with --debug, so that the debugging warnings
  don't show up when using -Wall.
- Many minor improvements.
2006-01-20 13:46:04 +00:00
rillig
46b20cd5dc - Added the -d|--debug command line option, which replaces -Wdebug. The
latter has been removed.
- Added -Wvarorder (default: disabled) to check the ordering of variables
  in simple packages.
- Using ${WRKSRC}/.. is only considered a warning, not an error, because
  there are packages that work nevertheless. Using this construct remains
  discouraged.
- Replaced most of the TODOs in the source code with code that prints
  a warning in --debug mode.
- The characters '.' and '+' are allowed in BuildlinkPackages.
- Variables *_FLAGS and *_ARGS that have their type guessed based on the
  name don't have to be assigned using the += operator.
- Variables that are assigned using the != operator are not checked for
  type compliance.
- README files are not marked as unknown when they appear in a package
  directory.
2006-01-20 13:33:37 +00:00
rillig
07a40aebce Setting BROKEN_GETTEXT_DETECTION to "no" really means "no", so allow it. 2006-01-20 13:03:10 +00:00
rillig
e6e1a0b8eb Despite its name, BUILTIN_FIND_FILES_VAR is a _list_ of variable names. 2006-01-20 12:35:51 +00:00
reed
6491d05a69 Add include/X11/XlibConf.h to xorg list. I noticed and added that
a few weeks ago when I was doing some builds using modular-xorg.
(Now that new Xorg is in, maybe there are some others to add?)

Update version.
2006-01-19 01:05:24 +00:00
rillig
de8b313520 - Added some more state transitions and warnings to the shellword parser.
It has come to the point where almost any further improvement means to
  adopt a real recursive parser.
2006-01-17 23:01:17 +00:00
rillig
97e5b5c2cd - In -Wextra mode, emit warnings if a "?=" operator occurs before
../../bsd.prefs.mk is included. (It is only shown in -Wextra mode
  because it is still quite unreliable.)
2006-01-16 01:37:39 +00:00
abs
59b795ff54 Update pkgtools/pkg_chk to 1.66
Fix incorrect quotation in test
2006-01-15 12:32:56 +00:00
rillig
d2bf446cb1 - Implemented a first prototype of the diagnostics with character-wise
precision in checkfile_patch for the warning for context diffs.
- The --source option produces more condensed output than before.
- The diagnostics with character-wise precision are colored using
  ANSI/VT100 color sequences. Support for other output formats will be
  added later.
2006-01-15 01:35:55 +00:00
rillig
76967e1b58 - The pkgdir variable is only defined when checking a pkgsrc package. For
other directories it is undefined. This avoids some false warnings when
  checking files in pkgsrc/mk/.
2006-01-14 11:56:09 +00:00
rillig
fa01b55c47 - Reduced the number of false warnings for relative directories. 2006-01-14 11:44:04 +00:00
rillig
03370d625a - Unquoted make variables in shell words can be fixed automatically. As
with the change from December 2005, when using this feature, care should
  be taken for variables that are pre-quoted.
- In patch files that patch Makefiles, added lines are checked for
  absolute pathnames.
2006-01-14 01:48:08 +00:00
rillig
a1ca3d5c5a Added LIBTOOL_OVERRIDE. 2006-01-13 00:59:39 +00:00
rillig
913ad8e379 - When guessing the type of variables, *_DIRS and *_FILES are both of the
type List of Pathmask.
2006-01-13 00:42:08 +00:00