Problems found with existing distfiles:
distfiles/javascript-2.1b1.el
distfiles/yEd-3.14.2.zip
No changes made to the javascript-mode or yEd distinfo files.
Otherwise, existing SHA1 digests verified and found to be the same on
the machine holding the existing distfiles (morden). All existing
SHA1 digests retained for now as an audit trail.
Now passes gcc -Wall -Wextra -Wmissing-declarations -Wwrite-strings on gcc45.
May build with clang now too.
Changes:
- use standard headers
- don't declare own errno, fopen(), getenv(), or malloc()
- declare own functions
- declare void functions void
- avoid implicit int
- use C89
- use some const
- use some static
- fix signed/unsigned mismatches
- call execl() properly
- don't cast return value of malloc
- initialize struct sigaction correctly
- use <ctype.h> functions correctly
- don't index arrays with (signed) char
- don't put function declarations inside function bodies
- patch up two uninitialized variables
- silence some compiler warnings that are not bugs
- remove some unused objects
and:
- add patch comments for preexisting patches
- correct some minor pkglint
As a couple of these things fixed bugs (e.g. the execl calls), bump
PKGREVISION.
