Commit graph

904 commits

Author SHA1 Message Date
rillig
752797eed3 Some ideas about the contexts in which variables may be used. 2006-05-11 09:05:33 +00:00
rillig
2c922e44cc - ACL subjects may contain * as a placeholder. 2006-05-10 17:14:08 +00:00
rillig
4c76990d32 The := or != operators can be used for unconditional assignment, too. 2006-05-10 17:01:44 +00:00
rillig
c9d4049caf clean up after doing a quick-install. 2006-05-10 15:42:03 +00:00
rillig
e5bfdfbb0a - Improved ACL definitions in makevars.map.
- Added checks for deprecated and nonexistent licenses. (suggested by gdt)
- Added detection for /foo/s/bar/baz/ sed command that appears without a
  leading "-e" in a SedCommands variable. (suggested by wiz)
2006-05-10 15:31:41 +00:00
rillig
1ecffb1d73 ACL entries are separated by a comma and optional white-space, since that
looks nicer.
2006-05-10 13:52:49 +00:00
rillig
8f57ebdf56 - Removed the types Readonly and Userdefined.
- Aligned the ACL permission letters with the documentation. The old "c"
  letter has been removed because from the definition's point of view,
  there is no difference between the "=" and the ":=" operator. All the
  differences lie on the right hand side, which will be covered later.
- Updated the variables in makevars.map with mk/defaults/mk.conf, 1.118.
2006-05-10 11:34:52 +00:00
rillig
e4b8bd8ff5 Rewrote the section on ACLs. Now I must adjust the implementation to
this specification.
2006-05-10 10:06:03 +00:00
rillig
c0f3775f92 * In the vartypes.map, distinguish FOO and FOO.*. 2006-05-10 09:01:15 +00:00
rillig
3bb1ece210 - Added the class PkgLint::Type.
- Added the -Wacl command line option, which is disabled by default.
- Extended the type definitions in makevars.map by ACLs, which specify
  in which files the variables may be defined.
- Trailing white-space in DESCR files can be fixed automatically.
- Use of the $$ shell variable is not flagged as "strange" anymore.
- Added ACL-based checks for variable definitions.
- PKGREVISION should not be set to 0.
- Improved the diagnostics text for RESTRICTED.
- Added the types Unchecked and Version.
- Dashes are allowed in library names in wrapper reordering commands.
- More than one DISTFILES definition is allowed in the variable ordering
  check.
2006-05-10 08:17:25 +00:00
rillig
edba88d675 In Makefiles, the level of indentation of directives should not be
affected by multiple-inclusion guards.
2006-05-02 10:12:10 +00:00
rillig
ae1b142935 Non-optimal white-space is not worth a warning. A note is enough. 2006-05-02 07:12:19 +00:00
rillig
9854211ccd It is an error if a RESTRICTED package does not have a LICENSE. 2006-05-01 22:01:21 +00:00
rillig
1b6d4ec0f2 The only valid value for NO_{SRC,BIN}_ON_{CDROM,FTP} is ${RESTRICTED},
as documented in the pkgsrc guide.
2006-05-01 20:19:04 +00:00
rillig
0d6b6cd6d9 Don't warn about unknown lines in paragrpah five of buildlink3.mk files
by default. Just skip them and only issue diagnostics when in --debug
mode.
2006-05-01 18:08:00 +00:00
rillig
f7786d5700 - Added specific checks for buildlink3.mk files.
- Found a bug in the SimpleMatch and StringMatch classes, which had worked
  up to now, although I knew that the code was wrong.
2006-05-01 13:47:54 +00:00
rillig
4a59ee2b78 - Added the shell command that is hidden to the diagnostics, so they
look more precise.
- Added checks for proper indentation of make(1) directives.
2006-05-01 00:15:04 +00:00
rillig
b5f475eed2 Marked all variables from mk/defaults/mk.conf as Readonly. 2006-05-01 00:13:47 +00:00
rillig
9edb975e6d List! has been replaced by InternalList. 2006-04-30 21:43:42 +00:00
rillig
dc39fd32e2 Added a warning that shell commands should not be hidden unconditionally
(by starting with the @ character).
2006-04-30 21:31:32 +00:00
rillig
60583f9991 Distinguish the variables pkgname and effective_pkgname. The latter can
also be derived from distname. Added more checks for PLIST files.
2006-04-29 10:12:36 +00:00
rillig
f6f2976090 Removed the word "possible" from the diagnostics, as the number of false
positives is near epsilon.
2006-04-23 09:48:53 +00:00
rillig
3c80b2e1e5 Determining the tool names automatically does not work without cheating,
as not all necessary files are included by bsd.tools.mk. Instead,
defaults.mk is included by bsd.prefs.mk.
2006-04-23 08:59:55 +00:00
rillig
6ad02eac06 The list of files that define the TOOLS is extracted from bsd.tools.mk
instead of specifying it explicitly.
2006-04-22 11:22:40 +00:00
rillig
fff7c773b6 Updated pkglint to 4.60.
Changes since 4.59:
- For many variables the :Q operator is not needed (by definition), for
  example some pathnames, user names, group names.
- Improved the diagnostics for planned package updates.
- Various catch-ups to recent changes in the infrastructure, among them
  BUILDLINK_ABI_DEPENDS and gettext.mk.
- When the PLIST contains a libtool archive, the *.a and *.so files don't
  have to be mentioned explicitly.
2006-04-21 10:37:51 +00:00
rillig
0b63ee04f7 - Added checks for wrapper transformation and reordering rules.
- Added checks for redundant library files in PLISTs.
2006-04-21 09:42:01 +00:00
joerg
7633711ecd Possible warnings if the PLIST contains libtool archives, but the
package doesn't say it uses libtool. Warn for redundant libraries,
when the libtool archive is also included in the PLIST.
2006-04-19 15:05:34 +00:00
rillig
20898fe52d Files called "manual-*" in the patches directory are not checked at all. 2006-04-18 00:35:18 +00:00
rillig
0f20f9fa28 In PLIST files, "share/locale" isn't deprecated anymore. 2006-04-18 00:01:48 +00:00
rillig
fbf3c9f5f0 Added gettext.mk to the list of files that define the tool names. 2006-04-14 12:27:00 +00:00
rillig
74e526d67d The variables *OWN, *GRP, *MODE don't need the :Q operator. The :Q operator
is also not needed for certain variables when adding to a list.
2006-04-14 10:26:41 +00:00
rillig
52edce7df5 BUILD_USES_MSGFMT and USE_MSGFMT_PLURALS are deprecated. 2006-04-13 21:04:00 +00:00
rillig
5ebd59d833 - The variables *_USER and *_GROUP don't need the :Q operator.
- Fixed a bug in the regular expression that detects sed(1) commands that
  don't start with "-e".
2006-04-13 01:57:35 +00:00
rillig
1c43c9af47 Removed an extra ". 2006-04-12 21:35:02 +00:00
rillig
e5cbb29b1e BUILDLINK_PREFIX.* does not need the :Q operator. 2006-04-12 20:28:03 +00:00
rillig
fade1f44b0 Removed superfluous :Q operators. 2006-04-12 20:25:06 +00:00
rillig
b407c541f2 The variables RECOMMENDED and BUILDLINK_RECOMMENDED are deprecated. 2006-04-12 09:23:36 +00:00
rillig
63f86ff4c5 The diagnostics for package updates now include the reason that is given
in doc/TODO, which is often a reference to a PR.
2006-04-12 08:49:57 +00:00
rillig
554064de83 Some variables, like WRKSRC, PREFIX, LOCALBASE and *DIR don't need the :Q
operator, since we expect them to never contain special characters. This
change reduces the number of -Wall warnings by approximately 28000.
2006-04-12 08:23:49 +00:00
rillig
e6072202fd Added an explanation for the state names of the patch file parser. 2006-04-11 18:41:50 +00:00
rillig
c2adb09c7a Don't warn about the misnamed variables *_TEMPLATE, which are actually
lists of files. Don't warn about files named "manual-*" in the patches
directory.
2006-04-11 17:44:29 +00:00
rillig
2fbd4ebed2 Updated pkglint to 4.59.
Changes since 4.58:
- Improved checking of patch files.
- Adjusted the variable names to the recent pkgsrc changes.
- Print a note if the pkglint version does not match the one from the
  checked pkgsrc tree.
2006-03-14 14:24:14 +00:00
rillig
e39db93190 Added HEADER_TEMPLATE. 2006-03-14 14:20:13 +00:00
rillig
2cb1b0aed5 {DE,}INSTALL_EXTRA_TMPL have been renamed to {DE,}INSTALL_TEMPLATE. 2006-03-14 14:18:55 +00:00
rillig
b13fb33101 {DE,}INSTALL_EXTRA_TMPL do not always need the += operator. 2006-03-13 01:03:59 +00:00
rillig
e680623f2c - Added a bunch of variables to makevars.map.
- Removed the specialized spell checker for NO_*_ON_*, since the generic
  one catches these quite well.
- SITES_* is deprecated in favor of SITES.*.
- Don't warn if variable alignment is done with exactly one space
  character, since this is common when one line from a group has an
  overly lengthy variable.
- Added support for checking whether the number of leading lines of context
  matches the number of trailing lines of context in patch files of the
  unified diff format. The MacOS X patch utility cannot handle these. As
  there are quite a number of false positives here (especially when the
  hunk is applied at the end of a file), this warning only shows up in
  --debug mode.
2006-03-12 16:55:51 +00:00
rillig
bd0e3a1e45 Added the BrokenIn data type. All BROKEN_IN lines generate an additional
note that tells the user to remove the line if the package builds.
2006-03-12 13:34:53 +00:00
rillig
9df67ca189 - Renamed "List!" to "InternalList".
- When ${SED} and ${MV} are used in a single shell command, print a note
  that the SUBST framework is preferred over the direct use of these
  commands.
2006-03-11 18:38:35 +00:00
rillig
d2e0cfbc92 Added CHECK_FILES_SKIP, DEVOSSSOUND, DLOPEN_REQUIRE_PTHREAD. 2006-03-11 00:01:28 +00:00
rillig
2099d2013d Don't check the quoting in backticks. This is a misdesign of pkglint. 2006-03-10 22:30:25 +00:00