if no eol is found in the string we set "next" to NULL, assign it
to "buf" and then check the loop condition by dereferencing it - which
does not work well.
Change the loop condition to first check for buf == NULL.
pkg_src_summary:
- Option -t was added. If applied a value of TOOL_DEPENDS
is added to BUILD_DEPENDS. This option works just like -b
does for BOOTSTRAP_DEPENDS.
pkg_cmp_summary:
- Fixes for -A and -O. Now they output an empty line after each
compared package even if it appeares multiple times in
pkg_summary1. So, the output is now consistent.
Last change time was updated for manual pages
File too long (should be no more than 24 lines).
Line too long (should be no more than 80 characters).
Trailing empty lines.
Trailing white-space.
Trucated the long files as best as possible while preserving the most info
contained in them.
COMMENT should not be longer than 70 characters.
COMMENT should not begin with 'A'.
COMMENT should not begin with 'An'.
COMMENT should not begin with 'a'.
COMMENT should not end with a period.
COMMENT should start with a capital letter.
pkglint warnings. Some files also got minor formatting, spelling, and style
corrections.
* In test, match the "make makesum" warning more loosely.
* In test, find packages to run against in $PKGSRCDIR explicitly.
* Bump version.
This is the last commit in a set developed for my "Rehabilitating
pkglint" talk at pkgsrcCon 2013.
Reviewed-at-pkgsrcCon-and-approved-during-the-freeze-by: wiz
Leave the silly self-grep in place, adjusting to also match the
lines that initialize the dispatch table. The underlying code is
better and the tests still pass. (No functional change intended.)
pkglint greps itself (really) to generate this list of types. Test
exhaustively for all types in the list today, so that the tested
code can become more civilized tomorrow. Adds a test-time dependency
on Test::Deep for cmp_bag().
In the configure stage, tell pkglint to find *.map in ${FILESDIR}.
That lets tests run even when pkglint isn't installed (which means
it also makes the tests less wrong when pkglint is installed!).
In the install stage, tell pkglint to find *.map under ${PREFIX},
as before (no functional change to the installed package).
Specify USE_TOOLS=perl to quell pkglint. :-)
These bits of non-main functionality are distracting to the casual
reader, and also to your intrepid refactorer. Since we recently
added some characterization tests that run the pkglint executable
against real packages, we can safely extract bits of code to separate
files and prove nothing broke in the move.
Instead of installing the new Perl modules where pkglint can find
them at runtime, I've added a build step to inline them right back
where they used to be (same order and everything). This is a little
annoying, but less annoying than suddenly needing to deal with Perl
runtime paths just for these few tiny modules. Also, loading modules
at runtime would affect pkglint's performance, and I don't yet have
performance tests to prove that this would be fine (or not), so I
can't safely do it.
No functional change intended.
This is the first commit in a set developed for my "Rehabilitating
pkglint" talk at pkgsrcCon 2013.
Reviewed-at-pkgsrcCon-and-approved-during-the-freeze-by: wiz
nih install:
- Order of packages does matter
("nih install emacs- editors/emacs22" is correct)
- Option -P and new config variable NO_REQPROV_CHECK were added
- Option -L and new config variable NO_REMOVE_LEAVES were added
- "Nothing to be done" message is output if everything is up-to-date
- Download failures and cksum failures are handled differently
- Handling CONFLICTS between installed packages and packages to
install are handled differently. Now package splits and similar
problems are resolved with a help of "fake" packages. Fake
packages are always marked for updates.
New option -f for "nih list" was added in order to list them
- Improvemed download progress messages
nih uninstall:
- Option -L was added, see "nih install -L"
- Options -p and -P were added. See "nih install"
nih leaf:
- Command was reimplemented and simplified
- Option -t option was removed
pkg_status doesn't have -ltRn options anymore
- Option -r was added
nih search:
- Option -I uses pkg_digger_installed provided by pkg_summary-utils
pkg_update_plan:
- Fixes in error messages
nih search|meta|info:
- Option -p was added. With a help of it one may search in
pkgsrc packages offline. Also see "nih refresh -p" and man page
Now nih works correctly if REPOSITORY is a directory
Fixes for shell's "trap" command.
Let to expand libtool archive (.la) automatically, so no need to mainain X11
file list manually anymore (every OS update may include shlib version change),
if the OS provide .la file (and no need to mind shlib type).
