Commit graph

1307 commits

Author SHA1 Message Date
rillig
74b09b8f70 Documented the most recent change. 2009-06-13 06:33:35 +00:00
rillig
70153a79c6 Introduced the emulation framework to pkglint. 2009-06-13 06:30:25 +00:00
rillig
8447379c6f Shell comments may be hidden using @, as they have no side effects. 2009-05-26 21:40:42 +00:00
rillig
5be066d680 Removed unnecessary code. 2009-04-26 16:08:40 +00:00
rillig
f0de3ee1bb Optimized the doc/CHANGES handling to get the get_doc_CHANGES function
out of the top-15 time consumers, as measured by DProf. The execution
time decreased by about 15 percent.
2009-04-26 12:51:35 +00:00
rillig
8a91bf95da Documented the recent addition of the PkgPath type. 2009-04-26 11:27:42 +00:00
rillig
7342b186a9 Added a check that ensures that all types in makevars.map actually exist
in the code, avoiding "Type not found" fatal errors at runtime. In this
case, only the variables *_SPECIFIC_PKGS were affected.

The real problem that induced the above change was the unknown type
"List of Pathname", which was a bug in the pkglint code itself,
introduced three years ago (revision 1.574).
2009-04-26 11:24:23 +00:00
rillig
5ba303ebb0 Added <para> tags so the document validates again. 2009-04-26 11:00:17 +00:00
rillig
7b522b5274 Removed unused functions. 2009-04-26 08:44:42 +00:00
joerg
8857e1e1dc NO_MTREE and NO_PACKAGE are obsolete. 2009-04-09 00:55:12 +00:00
joerg
368d71b62e Remove redundant NO_CHECKSUM and EXTRACT_ONLY definitions. 2009-04-09 00:48:06 +00:00
rillig
195fbce98e take case-insensitive filesystems into account. 2009-04-05 13:05:16 +00:00
rillig
6d0f18a109 Added a warning for the old buildlink3.mk format. 2009-04-04 18:36:04 +00:00
wiz
db21e9345c Improve explanation for missing man pages for sbin/ programs. 2009-03-25 16:33:25 +00:00
rillig
13996e96d2 Added explanations for all warnings that currently appear in wip/dcc. 2009-03-25 14:12:58 +00:00
rillig
1feaf9ef94 + LICENSE_FILE 2009-03-25 14:12:04 +00:00
rillig
f02a5aab68 Added BUILDLINK_CONTENTS_FILTER.* 2009-03-22 08:17:02 +00:00
rillig
840cc6e053 Fixed the .if/.endif handling in the new buildlink3.mk format. 2009-03-22 05:57:40 +00:00
rillig
2a2a5da56d Oops. :) 2009-03-22 05:50:12 +00:00
rillig
744e7354f2 Updated pkglint to 4.91.
Important changes since 4.90:
- Fixed some issues with "package has been downgraded" warnings.
- The doc/CHANGES-* files can be checked individually now.
- Emit a warning if a package does not define PKG_DESTDIR_SUPPORT.
- In patch files, warnings about absolute pathnames, CPP macros and the
  like are only emitted if the line starts with a "+". If the -Wextra
  option is given, the context lines (starting with a " ") are also
  checked.
- Added support for the new buildlink3.mk format.
2009-03-22 05:47:25 +00:00
rillig
102e800816 Adjusted pkglint to the new format of the buildlink3.mk files, which is
pretty neat.
2009-03-22 05:41:44 +00:00
rillig
542fef01a4 Implemented the suggestion by abs@ of reducing the number of warnings in
patch files. Up to now, the lines that only provide the context for the
patches have been checked for absolute pathnames and the like. Now, only
those lines that really add something to the patched file are checked.
The context lines are checked when the -Wextra option is given.

While here, added some comments to help me understand the code that I
wrote years ago.
2009-03-10 19:41:21 +00:00
rillig
f01f63d281 Remind the package developers that AUTO_MKDIRS is more convenient than
using the INSTALL_*_DIR commands or the INSTALLATION_DIRS variable.
Suggested by abs@ on tech-pkg@.
2009-02-14 10:42:20 +00:00
joerg
e2107c85f6 Remove Python 2.1 support. 2009-02-09 21:09:20 +00:00
rillig
115f8bca6b Packages that install *.desktop files should include
sysutils/desktop-file-utils/desktopdb.mk. Suggested by Matthias
Drochner.
2009-01-26 16:14:45 +00:00
rillig
21cac04813 Added but disabled a check that tests whether the PKGNAME and the
package directory match. There is much work to do until this can be
enabled.
2009-01-26 15:44:15 +00:00
wiz
1c2d59c2d6 Recognize CMAKE_ARGS. 2009-01-04 20:28:51 +00:00
rillig
ea2694451d Warn about missing PKG_DESTDIR_SUPPORT definition. Every package should
have one.
2008-12-21 10:34:59 +00:00
rillig
03b5233b74 TOOLS_DEPENDS.* names a dependency, and all the directories that are
mentioned in it must actually contain a Makefile.
2008-12-15 12:47:31 +00:00
rillig
41f53c4dd5 Changed one of the explanations to be more permissive. Fixed a
grammatical mistake in the same sentence.
2008-12-14 18:46:58 +00:00
wiz
b4f7fd588d Make complaints about hicolor icon themes directories errors.
Ok rillig
2008-12-05 06:48:05 +00:00
rillig
549bd2d94b Added explicit checks for share/icons/hicolor directories in PLISTs, as
suggested by wiz.
2008-12-04 18:07:52 +00:00
rillig
7359b60f45 Removed unused code. Changed one constructor call to match the pattern
of all the others. Explained how to get an overview of the code.
2008-12-02 09:00:28 +00:00
rillig
5614873bfe Banned the warnings about SUBST_* groups into the -Wextra option, since
they are used less strict than pkglint wants them.
2008-11-30 22:19:01 +00:00
rillig
f85556e344 more to do. 2008-11-25 19:11:39 +00:00
rillig
359895ef14 Allowed pkglint to check doc/CHANGES-* files individually. 2008-11-24 14:59:28 +00:00
rillig
f66a7f1777 Fixed the (hopefully) last issue with the downgrading warning. 2008-11-19 07:46:35 +00:00
rillig
30458d7406 It's pretty tricky to get the bmake substitution right. At least if
you're a lazy programmer. Now the ${DISTNAME:S...} is interpreted
correctly.
2008-11-18 21:17:53 +00:00
rillig
25f7fc3110 Updated pkglint to 4.90.
Changes since 4.89:
- Packages are checked whether they are being downgraded.
- Several small fixes and improvements.
2008-11-18 19:43:32 +00:00
rillig
a3a3f7f775 Get rid of the false positive warnings for downgrading, by doing more
magic to the PKGNAME and DISTNAME in the package Makefile. Thanks, wiz,
for insisting on this.
2008-11-18 19:39:49 +00:00
rillig
88db5cd30e Emit a note instead of a warning when the :Q operator is used in places
where it isn't necessary.

The :Q operator is necessary for URLs, since they may contain ampersands.
2008-11-18 19:18:51 +00:00
rillig
39f4738073 It is not necessary to save the whole text of the package Makefile
including all included files. By now, all checks are done by checking
individual lines, not the whole text.
2008-11-18 18:59:36 +00:00
rillig
f568f6dcea The PKGREVISION is included in the version comparison, to fix the bogus
warning that a package "is being downgraded from 1.0.0nb5 to 1.0.0".

Disabled the note saying that in shell variable assignments, there don't
need to be double quotes around backticks. In some cases they need to be
there.
2008-11-18 08:18:29 +00:00
rillig
d24f8d2bf7 DIST_SUBDIR may contain slashes. Found in www/firefox3-bin. 2008-11-18 08:04:35 +00:00
rillig
411a485a0d Only check doc/CHANGES-* starting with 2008, as suggested by OBATA Akio
on pkgsrc-changes.

TODO: Discuss whether the old files should be converted to the common
format or just be left as they are.
2008-11-06 14:46:51 +00:00
rillig
37dbfbc809 Fixed three warnings, which have been reported by Mark Davies. 2008-11-04 23:13:05 +00:00
rillig
507581677b The macro __NetBSD_Prereq__ should not be used.
Extended the spell checker for variants of __NetBSD_Version__.
2008-11-04 22:27:00 +00:00
rillig
3bc83926b1 Added a check that detects a downgrade of a package. To do this, it
loads the changes in doc/CHANGES-*.
2008-11-04 21:45:13 +00:00
rillig
6208c4238d Moved all explaining texts to the beginning of a line, so they stand out
from the rest of the code.
2008-10-20 11:09:07 +00:00
rillig
fe5245c568 Removed the experimental --klickibunti option and everything that was
only there to support this option. Maybe I will reinvent the advanced
autofix code someday, hopefully in a programming language that provides
more error checking than Perl.
2008-10-20 10:56:18 +00:00