rillig
9edb975e6d
List! has been replaced by InternalList.
2006-04-30 21:43:42 +00:00
rillig
dc39fd32e2
Added a warning that shell commands should not be hidden unconditionally
...
(by starting with the @ character).
2006-04-30 21:31:32 +00:00
rillig
60583f9991
Distinguish the variables pkgname and effective_pkgname. The latter can
...
also be derived from distname. Added more checks for PLIST files.
2006-04-29 10:12:36 +00:00
rillig
f6f2976090
Removed the word "possible" from the diagnostics, as the number of false
...
positives is near epsilon.
2006-04-23 09:48:53 +00:00
rillig
3c80b2e1e5
Determining the tool names automatically does not work without cheating,
...
as not all necessary files are included by bsd.tools.mk. Instead,
defaults.mk is included by bsd.prefs.mk.
2006-04-23 08:59:55 +00:00
rillig
6ad02eac06
The list of files that define the TOOLS is extracted from bsd.tools.mk
...
instead of specifying it explicitly.
2006-04-22 11:22:40 +00:00
rillig
fff7c773b6
Updated pkglint to 4.60.
...
Changes since 4.59:
- For many variables the :Q operator is not needed (by definition), for
example some pathnames, user names, group names.
- Improved the diagnostics for planned package updates.
- Various catch-ups to recent changes in the infrastructure, among them
BUILDLINK_ABI_DEPENDS and gettext.mk.
- When the PLIST contains a libtool archive, the *.a and *.so files don't
have to be mentioned explicitly.
2006-04-21 10:37:51 +00:00
rillig
0b63ee04f7
- Added checks for wrapper transformation and reordering rules.
...
- Added checks for redundant library files in PLISTs.
2006-04-21 09:42:01 +00:00
joerg
7633711ecd
Possible warnings if the PLIST contains libtool archives, but the
...
package doesn't say it uses libtool. Warn for redundant libraries,
when the libtool archive is also included in the PLIST.
2006-04-19 15:05:34 +00:00
rillig
20898fe52d
Files called "manual-*" in the patches directory are not checked at all.
2006-04-18 00:35:18 +00:00
rillig
0f20f9fa28
In PLIST files, "share/locale" isn't deprecated anymore.
2006-04-18 00:01:48 +00:00
rillig
fbf3c9f5f0
Added gettext.mk to the list of files that define the tool names.
2006-04-14 12:27:00 +00:00
rillig
74e526d67d
The variables *OWN, *GRP, *MODE don't need the :Q operator. The :Q operator
...
is also not needed for certain variables when adding to a list.
2006-04-14 10:26:41 +00:00
rillig
52edce7df5
BUILD_USES_MSGFMT and USE_MSGFMT_PLURALS are deprecated.
2006-04-13 21:04:00 +00:00
rillig
5ebd59d833
- The variables *_USER and *_GROUP don't need the :Q operator.
...
- Fixed a bug in the regular expression that detects sed(1) commands that
don't start with "-e".
2006-04-13 01:57:35 +00:00
rillig
1c43c9af47
Removed an extra ".
2006-04-12 21:35:02 +00:00
rillig
e5cbb29b1e
BUILDLINK_PREFIX.* does not need the :Q operator.
2006-04-12 20:28:03 +00:00
rillig
fade1f44b0
Removed superfluous :Q operators.
2006-04-12 20:25:06 +00:00
rillig
b407c541f2
The variables RECOMMENDED and BUILDLINK_RECOMMENDED are deprecated.
2006-04-12 09:23:36 +00:00
rillig
63f86ff4c5
The diagnostics for package updates now include the reason that is given
...
in doc/TODO, which is often a reference to a PR.
2006-04-12 08:49:57 +00:00
rillig
554064de83
Some variables, like WRKSRC, PREFIX, LOCALBASE and *DIR don't need the :Q
...
operator, since we expect them to never contain special characters. This
change reduces the number of -Wall warnings by approximately 28000.
2006-04-12 08:23:49 +00:00
rillig
e6072202fd
Added an explanation for the state names of the patch file parser.
2006-04-11 18:41:50 +00:00
rillig
c2adb09c7a
Don't warn about the misnamed variables *_TEMPLATE, which are actually
...
lists of files. Don't warn about files named "manual-*" in the patches
directory.
2006-04-11 17:44:29 +00:00
rillig
2fbd4ebed2
Updated pkglint to 4.59.
...
Changes since 4.58:
- Improved checking of patch files.
- Adjusted the variable names to the recent pkgsrc changes.
- Print a note if the pkglint version does not match the one from the
checked pkgsrc tree.
2006-03-14 14:24:14 +00:00
rillig
e39db93190
Added HEADER_TEMPLATE.
2006-03-14 14:20:13 +00:00
rillig
2cb1b0aed5
{DE,}INSTALL_EXTRA_TMPL have been renamed to {DE,}INSTALL_TEMPLATE.
2006-03-14 14:18:55 +00:00
rillig
b13fb33101
{DE,}INSTALL_EXTRA_TMPL do not always need the += operator.
2006-03-13 01:03:59 +00:00
rillig
e680623f2c
- Added a bunch of variables to makevars.map.
...
- Removed the specialized spell checker for NO_*_ON_*, since the generic
one catches these quite well.
- SITES_* is deprecated in favor of SITES.*.
- Don't warn if variable alignment is done with exactly one space
character, since this is common when one line from a group has an
overly lengthy variable.
- Added support for checking whether the number of leading lines of context
matches the number of trailing lines of context in patch files of the
unified diff format. The MacOS X patch utility cannot handle these. As
there are quite a number of false positives here (especially when the
hunk is applied at the end of a file), this warning only shows up in
--debug mode.
2006-03-12 16:55:51 +00:00
rillig
bd0e3a1e45
Added the BrokenIn data type. All BROKEN_IN lines generate an additional
...
note that tells the user to remove the line if the package builds.
2006-03-12 13:34:53 +00:00
rillig
9df67ca189
- Renamed "List!" to "InternalList".
...
- When ${SED} and ${MV} are used in a single shell command, print a note
that the SUBST framework is preferred over the direct use of these
commands.
2006-03-11 18:38:35 +00:00
rillig
d2e0cfbc92
Added CHECK_FILES_SKIP, DEVOSSSOUND, DLOPEN_REQUIRE_PTHREAD.
2006-03-11 00:01:28 +00:00
rillig
2099d2013d
Don't check the quoting in backticks. This is a misdesign of pkglint.
2006-03-10 22:30:25 +00:00
rillig
4800cacdde
Added PKG_SYSCONFDIR and PKG_SYSCONFVAR. The latter is not a Varname, as
...
the name might suggest, but an Identifier.
2006-03-10 22:14:52 +00:00
rillig
7022e13801
Added SITES.
2006-03-10 12:33:49 +00:00
rillig
7aece09dff
Added the REPLACE.* and REPLACE_FILES.* variables.
2006-03-09 17:34:17 +00:00
rillig
7201eefb04
- In unified diffs, the hunk header must not end in a CR character.
...
- Unmaintained packages should have pkgsrc-users instead of tech-pkg.
2006-03-08 21:15:31 +00:00
rillig
b93decabd7
When in context diff mode, as soon as the add-hunk header is seen, the
...
number of deleted lines is irrelevant. This fixes one false positive.
2006-03-02 19:47:03 +00:00
rillig
f148735d7c
- Make sure that at the end of a patch file, the state of the parser is
...
PST_TEXT. Otherwise the last hunk may not be checked completely.
2006-03-02 13:23:28 +00:00
rillig
ecf6e1d019
- It is an error if a hunk in a patch contains fewer lines that what is
...
specified in the hunk header.
2006-03-02 13:08:37 +00:00
rillig
8ed7d59f7b
- At startup, pkglint checks against the package version in
...
pkgtools/pkglint. If a newer version is available, it outputs a note.
If the pkgtools/pkglint version is older than the currently running one,
it outputs an error, since it is not a good idea to check and old tree
with a new pkglint. Suggested by Alistair.
2006-03-02 10:37:43 +00:00
rillig
27f583a2a7
Updated pkglint to 4.58.
...
Changes since 4.57:
- New parser for patch files.
- New command line options -Wplist-depr and -Wstyle.
- Variable assignments are no longer allowed in variables that should only
contain identifiers.
- builtin.mk files must not be included directly.
- Better checks for sed commands.
- Some commands like ktrace should never appear in Makefiles.
- The package version is compared to the requested update in file doc/TODO.
2006-03-01 22:19:13 +00:00
rillig
8da147b378
Debian's lintian has many ideas for things that pkglint could also check.
...
Maybe we can use some of them.
2006-03-01 22:11:15 +00:00
rillig
a8dcf62608
Added DEVOSSAUDIO and LIBOSSAUDIO.
2006-03-01 20:57:39 +00:00
rillig
6bd06c9cd1
The rant on Perl has moved to the pkglint book.
2006-02-28 23:32:47 +00:00
rillig
582603326f
Added more documentation on the format of the diagnostics.
2006-02-28 23:25:23 +00:00
rillig
74f99bcc5a
Added a rant on the Perl programming language.
2006-02-28 23:22:49 +00:00
rillig
d08250bc70
- Added the -Wstyle command line option, which enables warnings that don't
...
affect the build process but are of more stylistic nature.
- Enabled the warnings on missing explanatory comments for patch files when
-Wstyle is enabled.
2006-02-28 15:25:44 +00:00
rillig
0e3587880a
The section on the pkglint type system has been moved to the pkglint book.
2006-02-28 15:21:09 +00:00
rillig
23e011bdd5
Added the chapter ``Design goals''.
2006-02-28 11:40:15 +00:00
rillig
d9bf133bb0
- The :Q operator should not be applied to tools.
2006-02-28 00:20:23 +00:00