The actual fix as been done by "pkglint -F */*/buildlink3.mk", and was
reviewed manually.
There are some .include lines that still are indented with zero spaces
although the surrounding .if is indented. This is existing practice.
(in addtion to backported patches, dropped prototype patch of kakasi_do().
Its committer doesn't know the reason anymore, and implemented part patches
had been merged long time ago with
"patch-aa and patch-ac patched the same file. Merge them"
but patch-aa was for lib/libkakasi.c, and patch-ac is for src/kakasi.c.
From no problem reportes, it is considered this patch set is not relevant).
Changes from KAKASI 2.3.5 to 2.3.6
* Check runtime environment for test codes, and skip impossible tests.
* With configure, check compiler supported option.
(for the issue old gcc cannot accept -Wno-unused-result option)
* Fixed to check iconv availability at configure instead of autconf.
* Fixed and added manual (by Osamu Aoki).
* Fixed a bug to ouput redundant delimiter at wakatigaki if the line
start with ASCII character.
* Changed unitptr_t from macro to typedef (to avoid the issue that
come compilers cannot handle such macro)
* Fixed missing iconv related casts.
Changes from KAKASI 2.3.4 to 2.3.5
* Added UTF-8 input/output support (iconv is required)
* Improve handling of japanese long-vowel.
* Fixed bug of do_kakasi(), may return invald memory area.
* Fixed a wrong entriy in kakasidict.
* Fixed bad hepburn romaji table.
* Added use_old_romaji_table variable and -t option.
* Fixed segfault on invalid SS2 sequences.
* Fixes warnings at compile.
* Added a test script.
* Added -S option for mutable separator (with -w or -s option).
* Added -l and -L option for level furigana and hiragana conversion.
(See doc/README.level for more information)
* Newly added -F option for mutable parentheses around furigana
(with -JH -f or -L option).
* Added -y option to display all yomi per one Kanji.
* Add endian independent dictionary format support.
* Fixed bad hepburn romaji table.
(specify -t option fo use old romaji table)
This changes the buildlink3.mk files to use an include guard for the
recursive include. The use of BUILDLINK_DEPTH, BUILDLINK_DEPENDS,
BUILDLINK_PACKAGES and BUILDLINK_ORDER is handled by a single new
variable BUILDLINK_TREE. Each buildlink3.mk file adds a pair of
enter/exit marker, which can be used to reconstruct the tree and
to determine first level includes. Avoiding := for large variables
(BUILDLINK_ORDER) speeds up parse time as += has linear complexity.
The include guard reduces system time by avoiding reading files over and
over again. For complex packages this reduces both %user and %sys time to
half of the former time.
and add a new helper target and script, "show-buildlink3", that outputs
a listing of the buildlink3.mk files included as well as the depth at
which they are included.
For example, "make show-buildlink3" in fonts/Xft2 displays:
zlib
fontconfig
iconv
zlib
freetype2
expat
freetype2
Xrender
renderproto
RECOMMENDED is removed. It becomes ABI_DEPENDS.
BUILDLINK_RECOMMENDED.foo becomes BUILDLINK_ABI_DEPENDS.foo.
BUILDLINK_DEPENDS.foo becomes BUILDLINK_API_DEPENDS.foo.
BUILDLINK_DEPENDS does not change.
IGNORE_RECOMMENDED (which defaulted to "no") becomes USE_ABI_DEPENDS
which defaults to "yes".
Added to obsolete.mk checking for IGNORE_RECOMMENDED.
I did not manually go through and fix any aesthetic tab/spacing issues.
I have tested the above patch on DragonFly building and packaging
subversion and pkglint and their many dependencies.
I have also tested USE_ABI_DEPENDS=no on my NetBSD workstation (where I
have used IGNORE_RECOMMENDED for a long time). I have been an active user
of IGNORE_RECOMMENDED since it was available.
As suggested, I removed the documentation sentences suggesting bumping for
"security" issues.
As discussed on tech-pkg.
I will commit to revbump, pkglint, pkg_install, createbuildlink separately.
Note that if you use wip, it will fail! I will commit to pkgsrc-wip
later (within day).
in the process. (More information on tech-pkg.)
Bump PKGREVISION and BUILDLINK_DEPENDS of all packages using libtool and
installing .la files.
Bump PKGREVISION (only) of all packages depending directly on the above
via a buildlink3 include.
