kpriv/pkgsrc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
83621 commits 166 branches 0 tags 1.5 GiB
Commit graph

443 commits

Author SHA1 Message Date
rillig
a5453ed697 Removed all references to the -B/contblank command line option. 2005-08-25 07:24:00 +00:00
rillig
06693d3602 Removed the -p flag from the usage message. It hasn't been implemented 
for quite some time. I don't know when it had been removed, but
apparently no-one had used it anyway.
 2005-08-24 17:32:43 +00:00
rillig
d6720c2287 Removed the check for contiguous blank lines completely. As long as 
pkglint does not catch the important facts correctly it shouldn't be
nitpicking about white-space. I doubt that anyone has used the -B# and
the -Wwhitespace options at all, so there's no harm removing them.
 2005-08-24 17:29:52 +00:00
rillig
3497c6f0f7 Added a -Wwhitespace flag that is off by default to control whether 
multiple contiguous blank lines should result in warnings.
 2005-08-24 16:50:13 +00:00
rillig
5a878cee18 Sorted the regular expression constants alphabetically. Renamed two of them. 2005-08-22 13:51:40 +00:00
rillig
fb408275e2 Don't warn about unsorted PLIST entries that contain ${foo}. Only make 
sure the others are sorted.
 2005-08-22 05:12:01 +00:00
rillig
f1209e71c7 Reduced the number of warnings for replacing ":=" with "=". Added a command 
line flag -Winternal to enable checking of the pkgsrc infrastructure files.
By default these files are not checked.
 2005-08-21 23:05:01 +00:00
rillig
c4c597dc44 Buildlink files may use the := assignment operator for variable names that 
contain "BUILDLINK". All other uses are still flagged.
 2005-08-21 18:25:27 +00:00
rillig
a68e869480 Added a flag -g or --gcc-output-format that makes the messages parseable by 
the Emacs compile.el program. Changed the keyword for errors from FATAL to
ERROR. Sorted command line options alphabetically in the source code.
 2005-08-21 15:33:45 +00:00
rillig
cf0abff1fe This is pkglint-4.20. Changes since 4.19 include: 
- Very much code cleanup
- Introduction of the --autofix flag for category Makefiles
- Rewrite of the code to check the DISTNAME section in package Makefiles
- Rewrite of the code to check category Makefiles
 2005-08-21 10:31:43 +00:00
rillig
815d49418b Generally warn about the use of the := operator in Makefiles. 2005-08-21 10:20:13 +00:00
rillig
b5a201135e Rewrote the checking of the Makefile variables in the DISTNAME section. 
This reduces the number of false warnings.
 2005-08-21 08:55:52 +00:00
rillig
ed097917ca Fixed a syntax error (a string had not been enclosed in double quotes). 2005-08-20 10:53:44 +00:00
rillig
0493ce98e5 The default values for some variables in checkfile_package_Makefile are 
chosen more carefully to avoid false warnings. The local variables are
sorted by categories. Unnecessary variables have been removed.
 2005-08-20 10:05:00 +00:00
rillig
e956158a4e Added the command line option -CDESCR, for consistency. 2005-08-19 17:32:13 +00:00
rillig
fc379838f0 The --help message was wrong. The progress messages are not printed on 
STDERR but on STDOUT.
 2005-08-19 16:08:08 +00:00
rillig
0045e32bfa Reduced two errors to warnings for the category Makefiles: The sort 
order and  subdirectories which are commented out without giving a
reason.
 2005-08-19 15:58:30 +00:00
rillig
36d44c0a34 Don't check the distinfo twice if it is defined as ./distinfo in the 
package Makefile. This occurs for example in multimedia/gmplayer.
 2005-08-19 15:32:50 +00:00
rillig
eeaeeeb8f3 Changed the way how the direct use of tools is detected in Makefiles. 
Now the valid sequences are deleted from the string. If after the
deletion the string contains a tool name, a warning is printed.
 2005-08-17 19:06:41 +00:00
rillig
c604bf96f3 Moved the checkdir_package subroutine directly before the main subroutine 
to reduce the number of necessary forward declarations. Subsequently,
removed those forward declarations.
 2005-08-17 11:28:12 +00:00
rillig
88a92d894a Renamed check_{package,category} to checkdir_{package,category} to 
distinguish them from the checkfile_* and checklines_* subroutines.
 2005-08-17 10:55:22 +00:00
rillig
7a65dc8e0e Fixed some bugs that appeared while checking the databases/ category 
Makefile.
 2005-08-17 10:49:59 +00:00
rillig
b800379954 When checking category Makefiles, avoid false warnings about 
subdirectories that are in one of filesystem/Makefile, but not in the
other.
 2005-08-17 10:42:51 +00:00
rillig
8b7294f45e Don't require the second line of a category Makefile to contain an empty 
comment. Instead, allow arbitrary comments at the beginning of the file.
This change required a major rewrite of the code, which had been quite
inflexible before.
 2005-08-17 09:43:29 +00:00
rillig
d287119b6d Added an experimental --autofix or -F command line option. It currently 
has only effects for category Makefiles. While implementing it I
probably fixed some other bugs in the category Makefile checking code.
 2005-08-07 00:14:22 +00:00
rillig
e5aadae863 Fixed a bug which led to an endless loop. While happily changing the 
code, I had forgotten one assumption I made. It was that in the ifelse
chain the case ( && ) couldn't occur because
the outer loop already cought that. And then I had inserted code that
violated exactly this assumption. Fixed.
 2005-08-06 22:41:07 +00:00
rillig
810752a20e Fixed the indentation. Replaced a nested if with an &&. Noticed that I 
had put the closing indentation FIXME comment at a wrong place. But as
it is removed now, this doesn't matter.
 2005-08-06 22:24:07 +00:00
rillig
49fa8bb914 The check_category subroutine has been converted to a one-pass checker. 
The new code, which is not as nice as the old code, will hopefully allow
the --autofix option to be implemented really easily. If that will not
become true, I will probably revert to the old code. There's an
indentation FIXME in the code to keep this patch small. I will remove
that FIXME in a minute.
 2005-08-06 22:20:10 +00:00
rillig
4b3ddd1d43 Don't be too strict to the "wip" category Makefile. It may have a 
different second line and additional targets after the SUBDIR entries.
 2005-08-06 21:08:05 +00:00
rillig
f312ca3921 Made the checks for category Makefiles much stricter. Only the "category 
normal form" passes all checks.
 2005-08-06 20:32:35 +00:00
rillig
b8d49d75b7 Run a quick self-test after installation. 2005-08-06 19:36:54 +00:00
rillig
fb0d0037c9 White-space fixes. 2005-08-06 19:10:37 +00:00
rillig
71d66a2ecb Code beautification: %{$foo} instead of %$foo. 2005-08-06 08:08:33 +00:00
rillig
4b97d64081 Checking for C/C++ comments is not necessary for Makefiles. No-one uses 
them. All pathnames are already interpreted as being relative to the
package's directory. Added a reminder that ONLY_FOR_PLATFORM should be
changed to NOT_FOR_PLATFORM where appropriate.
 2005-08-06 08:00:14 +00:00
rillig
b9e3b22ee1 Moved the checks that had been done while loading Makefiles into a 
subroutine checklines_Makefile, which is called by
checkfile_package_Makefile and check_category.
 2005-08-06 02:26:47 +00:00
rillig
2bce08d2bc Print warnings if the values of ${PKGNAME}, ${SVR4_PKGNAME}, 
${DISTNAME}, ${DISTFILES}, ${EXTRACT_SUFX} cannot be resolved
completely. It's better than proceeding with definitely unusable values.
 2005-08-02 08:33:31 +00:00
rillig
5cf3e67b43 Some more speed optimization. 2005-08-01 23:54:09 +00:00
rillig
ddc2bad236 Converted PkgLint::FileUtils::Line to use an array instead of a hash for 
saving the fields. This gives a 5 percent speed-up.
 2005-08-01 22:29:13 +00:00
rillig
347db3598b Sppeded up the subroutines read_makefile and check_for_multiple_patches. 2005-08-01 21:28:06 +00:00
rillig
3496d25434 Added a new command line option --debug|d. It is currently used for 
measuring the time spent in the main checking subroutines. Using that
function I discovered that method calls like $line->text are awfully
slow. The subroutine checkfile_PLIST spent half of its time in this
function call. Now it is almost twice as fast as before.
 2005-08-01 21:02:30 +00:00
rillig
452f1079ac Simplified the code---no user-visisble changes. 2005-08-01 18:39:40 +00:00
rillig
656b775a63 More code cleanup. This time it's only white-space issues. 2005-08-01 18:03:37 +00:00
rillig
03037814cd Internal cleanup: moved some subroutines so that fewer forward 
references are needed. As the return value of the checkfile_*
subroutines is not needed, it is not provided anymore. Some other small
changes, which all do not affect the actual output or behavior of
pkglint.
 2005-08-01 17:06:56 +00:00
wiz
42cc128e46 Remove (commented out) USE_DB2 here too. 2005-08-01 15:40:19 +00:00
wiz
5347dad73a Remove another legacy var that was removed from pkgsrc before the previous branch. 2005-08-01 11:40:56 +00:00
wiz
e3990d3f87 Remove some legacy vars that were removed from pkgsrc before the previous branch. 2005-08-01 11:37:38 +00:00
wiz
9dc4f9590b Remove obsolete USE_PAM. 2005-08-01 10:55:42 +00:00
rillig
23eea97776 Inserted empty lines before elsif to make the code more readable. 2005-07-30 23:39:33 +00:00
rillig
8091e8ca7d The global variables are only needed when checking a package, not a 
package category.
 2005-07-30 23:35:24 +00:00
he
829942b695 Allow PATCH_DIST_CAT in the PATCH_SITES section. 
Bump version to 4.19.
 2005-07-29 16:01:12 +00:00