The actual fix as been done by "pkglint -F */*/buildlink3.mk", and was
reviewed manually.
There are some .include lines that still are indented with zero spaces
although the surrounding .if is indented. This is existing practice.
Problems found with existing distfiles:
/pub/pkgsrc/distfiles/amp-0.7.6.tgz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-music-32000-1.0.8.tar.gz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-music-48000-1.0.8.tar.gz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-en-us-callie-32000-1.0.22.tar.gz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-en-us-callie-48000-1.0.22.tar.gz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-fr-ca-june-32000-1.0.18.tar.gz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-fr-ca-june-48000-1.0.18.tar.gz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-ru-RU-elena-16000-1.0.12.tar.gz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-ru-RU-elena-32000-1.0.12.tar.gz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-ru-RU-elena-48000-1.0.12.tar.gz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-ru-RU-elena-8000-1.0.12.tar.gz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-fr-ca-june-32000-1.0.18.tar.gz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-fr-ca-june-48000-1.0.18.tar.gz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-ru-RU-elena-32000-1.0.13.tar.gz
/pub/pkgsrc/distfiles/freeswitch/freeswitch-sounds-ru-RU-elena-48000-1.0.13.tar.gz
/pub/pkgsrc/distfiles/kid3-3.3.0.tar.gz
/pub/pkgsrc/distfiles/libdca-0.0.5.tar.bz2
/pub/pkgsrc/distfiles/mp3to.gz
/pub/pkgsrc/distfiles/squeezeboxserver-7.5.1-noCPAN.tgz
No changes made to these file.
Otherwise, existing SHA1 digests verified and found to be the same on
the machine holding the existing distfiles (morden). All existing
SHA1 digests retained for now as an audit trail.
This changes the buildlink3.mk files to use an include guard for the
recursive include. The use of BUILDLINK_DEPTH, BUILDLINK_DEPENDS,
BUILDLINK_PACKAGES and BUILDLINK_ORDER is handled by a single new
variable BUILDLINK_TREE. Each buildlink3.mk file adds a pair of
enter/exit marker, which can be used to reconstruct the tree and
to determine first level includes. Avoiding := for large variables
(BUILDLINK_ORDER) speeds up parse time as += has linear complexity.
The include guard reduces system time by avoiding reading files over and
over again. For complex packages this reduces both %user and %sys time to
half of the former time.
Changes for libmusicbrainz 2.1.5
-------------------------------------
- Fix for CD TOC reading on Solaris, thanks to Brian Cameron. (#2009)
- Fixed compilation on GCC 4.3. (http://bugs.debian.org/417352)
- Fix the patch for buffer overflows in rdfparse.c (2066)
- Support for Debian GNU/kFreeBSD in configure.in (patch from the
libmb package in Debian)
- Patch to allow manually entering the CD TOC information, thanks
to sbooth. (#2193)
- Fixed configure.in to work with newer versions of autoconf. (#1829)
- Buffer overflow in MBHttp::WriteToBuffer. (#2273)
- Python bindings:
- No shebang in non-executable scripts.
changes:
- Fixed buffer overflows in the RDF parsing and HTTP code.
- Fixed memory leaks in RDFExtract.
- Fixed invalid memory access in the HTTP code.
(CVE-2006-4197)
Changes for libmusicbrainz 2.1.3
-------------------------------------
- New queries for selecting album artists:
- MBS_SelectAlbumArtist
- MBE_AlbumGetAlbumArtistName
- MBE_AlbumGetAlbumArtistSortName
- New query MBE_AlbumGetCdindexId
- Using size_t instead of int in networking code
- Little fixes in the API documentation
- Python bindings:
- Using the new ctypes 0.9.9.x API, with support to fallback to
the old API if only an old ctypes version is installed
- Removed dependency on ctypes in setup.py
and add a new helper target and script, "show-buildlink3", that outputs
a listing of the buildlink3.mk files included as well as the depth at
which they are included.
For example, "make show-buildlink3" in fonts/Xft2 displays:
zlib
fontconfig
iconv
zlib
freetype2
expat
freetype2
Xrender
renderproto
RECOMMENDED is removed. It becomes ABI_DEPENDS.
BUILDLINK_RECOMMENDED.foo becomes BUILDLINK_ABI_DEPENDS.foo.
BUILDLINK_DEPENDS.foo becomes BUILDLINK_API_DEPENDS.foo.
BUILDLINK_DEPENDS does not change.
IGNORE_RECOMMENDED (which defaulted to "no") becomes USE_ABI_DEPENDS
which defaults to "yes".
Added to obsolete.mk checking for IGNORE_RECOMMENDED.
I did not manually go through and fix any aesthetic tab/spacing issues.
I have tested the above patch on DragonFly building and packaging
subversion and pkglint and their many dependencies.
I have also tested USE_ABI_DEPENDS=no on my NetBSD workstation (where I
have used IGNORE_RECOMMENDED for a long time). I have been an active user
of IGNORE_RECOMMENDED since it was available.
As suggested, I removed the documentation sentences suggesting bumping for
"security" issues.
As discussed on tech-pkg.
I will commit to revbump, pkglint, pkg_install, createbuildlink separately.
Note that if you use wip, it will fail! I will commit to pkgsrc-wip
later (within day).
Changes for libmusicbrainz 2.1.2
-------------------------------------
- Since expat is now installed on most systems we removed our internal copy
and now rely on the system installed version.
- Juergen Kreileder Supplied minimal patch for making sure that mb_client sti
ll works
when CDO_CHECK_TYPE is defined
- Fixed a C++ style variable declaration inside the album.c C module
- On linux the cdrom drive is now opened in non-blocking mode
- Fixed bug #834541: Tagger setting track no. is 0 - possibly due to trm mixu
p?
- Added support for parsing AdvancedRelationship date. Also added new
getrels.c example program.
- Re-added the python bindings and changed the binding's version number to
match the version of this lib.
- Fixed bug # 1224562: libmusicbrainz fails to post large RDF. This fixes
problems looking up CDs with large numbers of tracks. (This was also
bug # 725701 ignores blank tracks)
The included perl bindings had the following changes:
- Updated bindings to match up to 2.1.1
- Fixed int size cast warning
- Fixed#6431: unmatched bootstrap parameter
- Updated req for MusicBrainz::Queries to 0.07
The included python bindings had the following changes:
- Fixed#957393: Python Bindings type bug
- Fixed#1206514: Python bindings to select release not up-to-date
file's sole purpose was to provide a dependency on pkg-config and set
some environment variables. Instead, turn pkg-config into a "tool"
in the tools framework, where the pkg-config wrapper automatically
adds PKG_CONFIG_LIBDIR to the environment before invoking the real
pkg-config.
For all package Makefiles that included pkg-config/buildlink3.mk, remove
that inclusion and replace it with USE_TOOLS+=pkg-config.
in the process. (More information on tech-pkg.)
Bump PKGREVISION and BUILDLINK_DEPENDS of all packages using libtool and
installing .la files.
Bump PKGREVISION (only) of all packages depending directly on the above
via a buildlink3 include.
All library names listed by *.la files no longer need to be listed
in the PLIST, e.g., instead of:
lib/libfoo.a
lib/libfoo.la
lib/libfoo.so
lib/libfoo.so.0
lib/libfoo.so.0.1
one simply needs:
lib/libfoo.la
and bsd.pkg.mk will automatically ensure that the additional library
names are listed in the installed package +CONTENTS file.
Also make LIBTOOLIZE_PLIST default to "yes".
Changes for libmusicbrainz 2.1.1
-------------------------------------
- Return special TRMs for special conditions for TRM generation:
c457a4a8-b342-4ec9-8f13-b6bd26c0e400 -- Sigserver busy and overloaded
f9809ab1-2b0f-4d78-8862-fb425ade8ab9 -- Source file is too short to
calculate TRM
7d154f52-b536-4fae-b58b-0666826c2bac -- File is slience
- If the TRM signature server becomes overloaded, it will now start
returning HTTP 503 error codes and the TRM generator will catch that
and return the Sigserver busy TRM shown above.
Changes for libmusicbrainz 2.1.0
-------------------------------------
- moved the python bindings into a new seperate project
- rewrote the mp3 duration detection code to be more robust
by making it vastly easier. In the process the bitzi
related code has been tossed. This should make the libary
smaller and the mp3 duration checking faster.
- Due to the bitzi code being removed, the SHA1 and Bitprint
related functions have been removed.
- Added query items for Release Dates/Countries, Amazon Asins and
Amazon cover art URLs
- Move include files into include/musicbrainz so that the example
files will compile outside of the libmusicbrainz client
source tree.
by moving the inclusion of buildlink3.mk files outside of the protected
region. This bug would be seen by users that have set PREFER_PKGSRC
or PREFER_NATIVE to non-default values.
BUILDLINK_PACKAGES should be ordered so that for any package in the
list, that package doesn't depend on any packages to the left of it
in the list. This ordering property is used to check for builtin
packages in the correct order. The problem was that including a
buildlink3.mk file for <pkg> correctly ensured that <pkg> was removed
from BUILDLINK_PACKAGES and appended to the end. However, since the
inclusion of any other buildlink3.mk files within that buildlink3.mk
was in a region that was protected against multiple inclusion, those
dependencies weren't also moved to the end of BUILDLINK_PACKAGES.
Changes are:
Changes for libmusicbrainz 2.0.2
-------------------------------------
- Added support for Mac OS X
- Improved build system
- Added build files for Visual Studio .NET (VC7)
Changes for libmusicbrainz 2.0.1
-------------------------------------
- Added patch for pkgconfig
- Threading handled correctly in python wrapper
- New perl bindings
- Had client use HTTP 1.0 rather than HTTP 1.1
Addresses PR pkg/20446 by Matthias Friedrich.
Changes:
2.0.0:
======
- Removed some spurious C++ comments from mb_c.h
- Fixes and improvements to the python language bindings and tools
- Updated NetBSD cdrom reading code
2.0.0-pre4:
===========
- Two new functions have been added:
mb_GetFragmentFromURL - Retrieve a fragment from a URI
mb_GetOrdinalFromList - Retrieve a list ordinal from a given list --
this is sometimes needed to determine the
location of an item in a list. (e.g. a track
in an album in order to find the track number)
- The TRM code has been updated for TRM B#er.
- New queries have been added to queries.h in order to support the improved
FileLookupInterface.
- The client library now uses the mm-2.1 and mq-1.1 namespaces.
- The client library will now be referred to as libmusicbrainz
2.0.0-pre1:
===========
- Added authentication support
- Added new queries
- Added support for submitting client version to the server during TRM
submits
- Updated client code for TRM B#er
