Commit graph

1770 commits

Author SHA1 Message Date
jlam
cf4dfe44a5 Use REQD_DIRS instead of MAKE_DIRS for directories under ${PREFIX} so
that these directories will be conditionally removed (based on reference
counts), regardless of the value of PKG_CONFIG.  Bump the PKGREVISION
for packages that were modified as a result.
2005-08-20 19:16:21 +00:00
rillig
ed097917ca Fixed a syntax error (a string had not been enclosed in double quotes). 2005-08-20 10:53:44 +00:00
rillig
0493ce98e5 The default values for some variables in checkfile_package_Makefile are
chosen more carefully to avoid false warnings. The local variables are
sorted by categories. Unnecessary variables have been removed.
2005-08-20 10:05:00 +00:00
rillig
e956158a4e Added the command line option -CDESCR, for consistency. 2005-08-19 17:32:13 +00:00
rillig
fc379838f0 The --help message was wrong. The progress messages are not printed on
STDERR but on STDOUT.
2005-08-19 16:08:08 +00:00
rillig
0045e32bfa Reduced two errors to warnings for the category Makefiles: The sort
order and  subdirectories which are commented out without giving a
reason.
2005-08-19 15:58:30 +00:00
rillig
36d44c0a34 Don't check the distinfo twice if it is defined as ./distinfo in the
package Makefile. This occurs for example in multimedia/gmplayer.
2005-08-19 15:32:50 +00:00
rillig
eeaeeeb8f3 Changed the way how the direct use of tools is detected in Makefiles.
Now the valid sequences are deleted from the string. If after the
deletion the string contains a tool name, a warning is printed.
2005-08-17 19:06:41 +00:00
rillig
c604bf96f3 Moved the checkdir_package subroutine directly before the main subroutine
to reduce the number of necessary forward declarations. Subsequently,
removed those forward declarations.
2005-08-17 11:28:12 +00:00
rillig
88a92d894a Renamed check_{package,category} to checkdir_{package,category} to
distinguish them from the checkfile_* and checklines_* subroutines.
2005-08-17 10:55:22 +00:00
rillig
7a65dc8e0e Fixed some bugs that appeared while checking the databases/ category
Makefile.
2005-08-17 10:49:59 +00:00
rillig
b800379954 When checking category Makefiles, avoid false warnings about
subdirectories that are in one of filesystem/Makefile, but not in the
other.
2005-08-17 10:42:51 +00:00
rillig
8b7294f45e Don't require the second line of a category Makefile to contain an empty
comment. Instead, allow arbitrary comments at the beginning of the file.
This change required a major rewrite of the code, which had been quite
inflexible before.
2005-08-17 09:43:29 +00:00
xtraeme
b274e3ade5 Don't install the manpage on FreeBSD. 2005-08-08 21:40:48 +00:00
rillig
d287119b6d Added an experimental --autofix or -F command line option. It currently
has only effects for category Makefiles. While implementing it I
probably fixed some other bugs in the category Makefile checking code.
2005-08-07 00:14:22 +00:00
rillig
e5aadae863 Fixed a bug which led to an endless loop. While happily changing the
code, I had forgotten one assumption I made. It was that in the ifelse
chain the case ( && ) couldn't occur because
the outer loop already cought that. And then I had inserted code that
violated exactly this assumption. Fixed.
2005-08-06 22:41:07 +00:00
rillig
810752a20e Fixed the indentation. Replaced a nested if with an &&. Noticed that I
had put the closing indentation FIXME comment at a wrong place. But as
it is removed now, this doesn't matter.
2005-08-06 22:24:07 +00:00
rillig
49fa8bb914 The check_category subroutine has been converted to a one-pass checker.
The new code, which is not as nice as the old code, will hopefully allow
the --autofix option to be implemented really easily. If that will not
become true, I will probably revert to the old code. There's an
indentation FIXME in the code to keep this patch small. I will remove
that FIXME in a minute.
2005-08-06 22:20:10 +00:00
rillig
4b3ddd1d43 Don't be too strict to the "wip" category Makefile. It may have a
different second line and additional targets after the SUBDIR entries.
2005-08-06 21:08:05 +00:00
rillig
f312ca3921 Made the checks for category Makefiles much stricter. Only the "category
normal form" passes all checks.
2005-08-06 20:32:35 +00:00
rillig
b8d49d75b7 Run a quick self-test after installation. 2005-08-06 19:36:54 +00:00
rillig
fb0d0037c9 White-space fixes. 2005-08-06 19:10:37 +00:00
rillig
71d66a2ecb Code beautification: %{$foo} instead of %$foo. 2005-08-06 08:08:33 +00:00
rillig
4b97d64081 Checking for C/C++ comments is not necessary for Makefiles. No-one uses
them. All pathnames are already interpreted as being relative to the
package's directory. Added a reminder that ONLY_FOR_PLATFORM should be
changed to NOT_FOR_PLATFORM where appropriate.
2005-08-06 08:00:14 +00:00
jlam
7fbb8d9527 Bump the PKGREVISIONs of all (638) packages that hardcode the locations
of Perl files to deal with the perl-5.8.7 update that moved all
pkgsrc-installed Perl files into the "vendor" directories.
2005-08-06 06:19:03 +00:00
rillig
b9e3b22ee1 Moved the checks that had been done while loading Makefiles into a
subroutine checklines_Makefile, which is called by
checkfile_package_Makefile and check_category.
2005-08-06 02:26:47 +00:00
xtraeme
126dda9bde Bump to 20050804:
When using the -M flag, look in Makefile and Makefile.common files.

Ok'ed by Peter Postma.
2005-08-04 22:21:33 +00:00
abs
2799fb73cd missed in last 2005-08-04 18:01:37 +00:00
abs
04c8e2ea5d update pkgtools/pkg_chk to 1.60:
Make -b work without any access to pkgsrcdir
2005-08-04 17:55:51 +00:00
seb
a47d96ceb9 Update to version 0.118: pkgdiff fix and tuning.
Fix the automagic tuning of the number of unified diff context
lines.  It was broken since previous commit to files/pkgdiff.

Also arguments '-u' and '-U NUM' to GNU diffutils 2.8.1, as seen
in NetBSD 2.0_STABLE and current, are not intended to be used
together. Hence only '-U NUM' is now specified. I did not reverted
to the '-u -NUM' form used before as it seems undesirable.

Please note that if PKGDIFF_FMT is specified in the environment,
for testing or debugging purposes, we skip the automagic tuning of
the number of unified diff context lines.  The user probably wants
to try another diff format, as suggested in the commit log of
revision 1.12 of files/pkgdiff. So there is no point in adding '-U
NUM' to PKGDIFF_FMT: it may just not work. See:

$ diff -c -U 1 /dev/null /dev/null
diff: conflicting output style options
diff: Try `diff --help' for more information.

While here save a few basename(1) runs.
2005-08-02 12:16:19 +00:00
rillig
2bce08d2bc Print warnings if the values of ${PKGNAME}, ${SVR4_PKGNAME},
${DISTNAME}, ${DISTFILES}, ${EXTRACT_SUFX} cannot be resolved
completely. It's better than proceeding with definitely unusable values.
2005-08-02 08:33:31 +00:00
rillig
5cf3e67b43 Some more speed optimization. 2005-08-01 23:54:09 +00:00
rillig
ddc2bad236 Converted PkgLint::FileUtils::Line to use an array instead of a hash for
saving the fields. This gives a 5 percent speed-up.
2005-08-01 22:29:13 +00:00
dmcmahill
c0d9814d89 update to cdpack-1.6.
- add -m, -o, and -r flags to optionally specify the machine-architecture
  operating system, and os version to be displayed in the generated README
  file.  From Greg Woods via private email.

- White space fixes from Greg Woods.

- Clean up the generated README file as well as several of the messages
  to reflect if the collection is a CD-ROM or DVD set.  Some patches from
  Greg Woods, more from me.

- List the tools used at runtime.
2005-08-01 21:47:43 +00:00
rillig
347db3598b Sppeded up the subroutines read_makefile and check_for_multiple_patches. 2005-08-01 21:28:06 +00:00
rillig
3496d25434 Added a new command line option --debug|d. It is currently used for
measuring the time spent in the main checking subroutines. Using that
function I discovered that method calls like $line->text are awfully
slow. The subroutine checkfile_PLIST spent half of its time in this
function call. Now it is almost twice as fast as before.
2005-08-01 21:02:30 +00:00
rillig
452f1079ac Simplified the code---no user-visisble changes. 2005-08-01 18:39:40 +00:00
rillig
656b775a63 More code cleanup. This time it's only white-space issues. 2005-08-01 18:03:37 +00:00
rillig
03037814cd Internal cleanup: moved some subroutines so that fewer forward
references are needed. As the return value of the checkfile_*
subroutines is not needed, it is not provided anymore. Some other small
changes, which all do not affect the actual output or behavior of
pkglint.
2005-08-01 17:06:56 +00:00
wiz
42cc128e46 Remove (commented out) USE_DB2 here too. 2005-08-01 15:40:19 +00:00
wiz
5347dad73a Remove another legacy var that was removed from pkgsrc before the previous branch. 2005-08-01 11:40:56 +00:00
wiz
e3990d3f87 Remove some legacy vars that were removed from pkgsrc before the previous branch. 2005-08-01 11:37:38 +00:00
wiz
9dc4f9590b Remove obsolete USE_PAM. 2005-08-01 10:55:42 +00:00
agc
f889f01b22 Update digest to version 20050731:
Pull in a patch from Vsevolod Stakhov via FreeBSD:

	Because that the 55-bytes input-message becomes just 64 bytes
	block after `the message terminator code(0x80)' and
	`size-field(8-bytes field)' are added.  Perhaps, I think the
	block of a lot of one be made at this time.

Fixes PR 30857
2005-07-31 22:45:24 +00:00
rillig
23eea97776 Inserted empty lines before elsif to make the code more readable. 2005-07-30 23:39:33 +00:00
rillig
8091e8ca7d The global variables are only needed when checking a package, not a
package category.
2005-07-30 23:35:24 +00:00
wiz
56e1c19167 Remove pkgconflict here too. 2005-07-30 21:28:06 +00:00
rillig
8250b297f7 Removed the package as it has not been working since 2001. Ok'ed by
wennmach.
2005-07-30 20:38:30 +00:00
he
829942b695 Allow PATCH_DIST_CAT in the PATCH_SITES section.
Bump version to 4.19.
2005-07-29 16:01:12 +00:00
reed
1014a5d2a8 Add xorg file which has common Xorg file entries.
Forgot in commit a few moments ago.

This was discussed on tech-pkg on July 7.
2005-07-25 20:54:00 +00:00