with building on Irix. The changes applied to 'configure' introduce
some quite ugly quote nesting that not all shells (E.g. ksh) can
comprehend.
After discussion, prefer to roll back what looks like undesirable and
unnecessary changes, and drop the 'bash' dependency. My suspicion is
that the old 'configure' patch is unhelpful even for Irix.
The reason for the PR/48587 changes are not clear, given that part of
that patch also selected 'bash' as the shell to use - which should
have made editing the script unnecessary in the first place.
Demonstrating the problem bringing all this to attention, this is what
happens if you are using ksh as the Pkgsrc shell on MacOS X:
===> Building for libffi-3.3nb2
/bin/ksh: : cannot execute [Is a directory]
<hangs>
The cause is this ugly looking quote nesting that was introduced by
patch-configure in PR/48587...
$ BUILD="` grep "^#### $HOST " Makefile | sed -e 's/.*|//' `"
ksh: : cannot execute [Is a directory]
^C
% bash
bash-5.0$ BUILD="` grep "^#### $$HOST " Makefile | sed -e 's/.*|//' `"
bash-5.0$ exit
% sh
sh-3.2$ BUILD="` grep "^#### $$HOST " Makefile | sed -e 's/.*|//' `"
sh-3.2$ exit
Removing patch-configure results in this much simpler, portable looking
script:
$ BUILD=` grep "^#### $$HOST " Makefile | sed -e 's/.*|//' `
No PKGREVISION bump, this change is not anticipated to affect the
package contents, only the success or failure of the build.
59afafc1a4