This patch originates from pkgsrc-wip in order to prevent clang
warnings for adding an integer to a string literal by converting
"foo" + x to &"foo"[x]. However, when gdb was updated to 7.9, the
ampersand was mistakenly dropped. The string literal was also
replaced with a variable, so there is no longer any reason for the
patch.
This caused the oappend function to be called with a char converted
to a pointer, which immediately crashes gdb whenever disassembly
is performed.
1874b9f9b5