pkgsrc/sysutils/lsof/Makefile
jym 1373123a11 When we moved from fd_ofiles to a struct fdtab, the fd_ofiles became
an array of pointer (in struct fdtab) rather than a pointer of pointers.

Sadly for us, no, arrays and pointers are not equivalent from a memory
perspective: while pointers from/to another address space can
be consumed by kvm(3) to query for data in kernel space, arrays
are more tricky, especially when their content is copied in userland:
they are part of the copied struct.

Address of array members are only valid in their own address space,
in our case userland, which is (fortunately?) different from kernel space.
This breaks the various kvm_read() calls that query for file descriptor
information. Consequence: lsof(1) cannot print filedescriptor information
(starting from 5.99.14), and silently ignores the errors, as using
the userland fdtab (``dt'' variable) is not valid for kernel.

Fix that by using the ``fd_dt'' member of struct filedes, which stores
the address of the fdtab struct in kernel address space. Took a few hours
to understand what was going on with lsof(1), hmmm.

Luckily, fstat(1) uses the proper model (checked about 5min ago). Why
lsof(1) decided not to log an error on kvm_read() is... a good question.

Bump rev.
2011-03-21 00:22:02 +00:00

107 lines
3.4 KiB
Makefile

# $NetBSD: Makefile,v 1.109 2011/03/21 00:22:02 jym Exp $
DISTNAME= lsof_4.83
PKGNAME= ${DISTNAME:S/_/-/}
CATEGORIES= sysutils
PKGREVISION= 1
MASTER_SITES= ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/ \
ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/NEW/ \
ftp://lsof.itap.purdue.edu/pub/tools/unix/lsof/OLD/ \
ftp://ftp.cerias.purdue.edu/pub/tools/unix/sysutils/lsof/ \
ftp://ftp.cerias.purdue.edu/pub/tools/unix/sysutils/lsof/NEW/ \
ftp://ftp.cerias.purdue.edu/pub/tools/unix/sysutils/lsof/OLD/ \
ftp://ftp.fu-berlin.de/pub/unix/tools/lsof/ \
ftp://ftp.fu-berlin.de/pub/unix/tools/lsof/NEW/ \
ftp://ftp.fu-berlin.de/pub/unix/tools/lsof/OLD/ \
ftp://gd.tuwien.ac.at/utils/admin-tools/lsof/ \
ftp://gd.tuwien.ac.at/utils/admin-tools/lsof/NEW/ \
ftp://gd.tuwien.ac.at/utils/admin-tools/lsof/OLD/ \
ftp://sunsite.ualberta.ca/pub/Mirror/lsof/ \
ftp://sunsite.ualberta.ca/pub/Mirror/lsof/NEW/ \
ftp://sunsite.ualberta.ca/pub/Mirror/lsof/OLD/
EXTRACT_SUFX= .tar.bz2
MAINTAINER= pkgsrc-users@NetBSD.org
HOMEPAGE= http://people.freebsd.org/~abe/
COMMENT= Lists information about open files
PKG_DESTDIR_SUPPORT= user-destdir
WRKSRC= ${WRKDIR}/${DISTNAME}/${SRCBALL_NAME}
HAS_CONFIGURE= yes
CONFIGURE_SCRIPT= ./Configure
CONFIGURE_ARGS+= -n ${LOWER_OPSYS}
CONFIGURE_ENV+= LSOF_CC="${CC} ${CFLAGS}"
MAKE_FLAGS+= LSOF_BLDCMT="NetBSD pkgsrc rocks!"
OSVERSION_SPECIFIC= yes
TMPWRK= ${WRKDIR}/${DISTNAME}
SRCBALL_NAME= ${DISTNAME}_src
REPLACE_PERL+= scripts/sort_res.perl5 scripts/count_pf.perl5 \
scripts/list_NULf.perl5 scripts/big_brother.perl5 \
scripts/identd.perl5 scripts/shared.perl5 \
scripts/idrlogin.perl5 scripts/count_pf.perl \
scripts/idrlogin.perl scripts/list_fields.perl \
scripts/watch_a_file.perl
USE_TOOLS+= gtar pax perl:run
PKG_INSTALLATION_TYPES= overwrite pkgviews
TEST_DIRS= tests
TEST_TARGET= test
INTERACTIVE_STAGE+= test
.include "../../mk/bsd.prefs.mk"
.include "options.mk"
REAL_GROUP= ${REAL_ROOT_GROUP}
.if ${OPSYS} == "NetBSD"
REAL_GROUP= kmem
CONFIGURE_ENV+= NETBSD_SYS="${NETBSDSRCDIR}/sys"
.elif ${OPSYS} == "FreeBSD"
BUILDLINK_PASSTHRU_DIRS+= /usr/src/sys
.elif ${OPSYS} == "SunOS"
MAKE_ENV+= CPPFLAGS=
.endif
INSTALLATION_DIRS= ${PKGMANDIR}/man8 sbin
post-extract:
.if ${OPSYS} == "FreeBSD"
@(if [ ! -x /usr/src/sys ]; then \
${ECHO} "Lsof requires kernel sources to be found in /usr/src/sys." ; \
exit 1 ; \
fi)
.endif
@(cd ${TMPWRK} ; \
EXPMD5=`${GREP} 'MD5 (' README.${DISTNAME} | ${SED} 's/^[ ]*//'` ; \
CALCMD5=`${DIGEST} MD5 ${SRCBALL_NAME}.tar` ; \
if [ "$${EXPMD5}"X != "$${CALCMD5}"X ]; then \
${ECHO} "Expected and calculated MD5 signatures don't agree." ; \
${ECHO} "($$EXPMD5 != $$CALCMD5)" ; \
exit 1 ; \
fi ; \
if [ X${EXTRACT_USING} = Xgtar ]; then \
${GTAR} -xf ${SRCBALL_NAME}.tar; \
else \
pax -O -r < ${SRCBALL_NAME}.tar; \
fi)
@( cd ${WRKSRC} ; ${ECHO} "y" | ./Inventory || exit 1 )
INSTALLATION_DIRS+= sbin ${PKGMANDIR}/man8 share/lsof
SPECIAL_PERMS+= ${PREFIX}/sbin/lsof ${REAL_ROOT_USER} ${REAL_GROUP} 2755
do-install:
${INSTALL_PROGRAM} ${WRKSRC}/lsof ${DESTDIR}${PREFIX}/sbin
${INSTALL_MAN} ${WRKSRC}/lsof.8 \
${DESTDIR}${PREFIX}/${PKGMANDIR}/man8/lsof.8
${INSTALL_SCRIPT} ${WRKSRC}/scripts/* ${DESTDIR}${PREFIX}/share/lsof
@${CHMOD} 0444 ${DESTDIR}${PREFIX}/share/lsof/00*
opt:
.for _dir_ in ${TEST_DIRS}
${RUN}${_ULIMIT_CMD} \
cd ${WRKSRC} && cd ${_dir_} && \
${TEST_MAKE_CMD} opt
.endfor
.include "../../mk/bsd.pkg.mk"