f705b2b3cc
problems noted in CAN-2004-0914:
Multiple vulnerabilities in libXpm for 6.8.1 and earlier, as
used in XFree86 and other packages, include (1) multiple integer
overflows, (2) out-of-bounds memory accesses, (3) directory
traversal, (4) shell metacharacter, (5) endless loops, and (6)
memory leaks, which could allow remote attackers to obtain
sensitive information, cause a denial of service (application
crash), or execute arbitary code via a certain XPM image file.
Bump PKGREVISION to 4. Since this is a security-related fix, also
bump the BUILDLINK_RECOMMENDED version for this package.
22 lines
673 B
Text
22 lines
673 B
Text
$NetBSD: patch-ao,v 1.1 2005/06/14 18:10:37 jlam Exp $
|
|
|
|
--- lib/WrFFrBuf.c.orig 1998-03-19 14:51:00.000000000 -0500
|
|
+++ lib/WrFFrBuf.c
|
|
@@ -32,6 +32,8 @@
|
|
* Developed by Arnaud Le Hors *
|
|
\*****************************************************************************/
|
|
|
|
+/* October 2004, source code review by Thomas Biege <thomas@suse.de> */
|
|
+
|
|
#include "XpmI.h"
|
|
|
|
int
|
|
@@ -49,7 +51,7 @@ XpmWriteFileFromBuffer(filename, buffer)
|
|
fcheck = fwrite(buffer, len, 1, fp);
|
|
fclose(fp);
|
|
if (fcheck != 1)
|
|
- return XpmOpenFailed;
|
|
+ return XpmOpenFailed; /* maybe use a better return value */
|
|
|
|
return XpmSuccess;
|
|
}
|