957505adcc
* Bumps version dependencies.
Changes (since 1.32.1):
Cliqz Browser release 1.33.0 includes the improvements of Firefox’s latest
version 73.0.1 with additional Cliqz improvements and bug fixes. Improvements
* Cliqz got updated to Firefox 73.0.1 with various improvements and fixes.
* In the browser settings you’ll find the new section "Labs". Here you can
activate the latest browser features that we’re currently testing. The
first one is support for the Dat Protocol that enables the loading of
certain web pages via a peer-to-peer network.
Fixes
* Users of Kaspersky Antivirus could no longer open HTTPS pages in the Cliqz
Browser and got the error message "Your Connection is not secure". This
problem should not occur again in the future.
* When updating from an older browser version it could happen that instead of
Cliqz Tab only an empty page was displayed. This issue has been fixed.
Miscellaneous
* The Connect feature has been removed due to performance issues. But we are
already working on a better and more stable solution. Please let us know
what features you would like to see.
112 lines
4.3 KiB
C
112 lines
4.3 KiB
C
$NetBSD: patch-mozilla-release_nsprpub_pr_src_pthreads_ptsynch.c,v 1.1 2020/02/23 00:10:41 fox Exp $
|
|
|
|
firefox: Workaround broken pthread_equal() usage
|
|
|
|
Switch to an internal version of pthread_equal() without sanity checks.
|
|
|
|
Problems detected on NetBSD 9.99.46.
|
|
|
|
Taken from www/firefox
|
|
|
|
--- mozilla-release/nsprpub/pr/src/pthreads/ptsynch.c.orig 2020-01-17 21:34:42.000000000 +0000
|
|
+++ mozilla-release/nsprpub/pr/src/pthreads/ptsynch.c
|
|
@@ -25,6 +25,13 @@ static pthread_condattr_t _pt_cvar_attr;
|
|
extern PTDebug pt_debug; /* this is shared between several modules */
|
|
#endif /* defined(DEBUG) */
|
|
|
|
+/* XXX, pthread_equal() is misused to compare non-valid thread pointers */
|
|
+static int
|
|
+pt_pthread_equal(pthread_t t1, pthread_t t2)
|
|
+{
|
|
+ return t1 == t2;
|
|
+}
|
|
+
|
|
#if defined(FREEBSD)
|
|
/*
|
|
* On older versions of FreeBSD, pthread_mutex_trylock returns EDEADLK.
|
|
@@ -197,9 +204,9 @@ PR_IMPLEMENT(PRStatus) PR_Unlock(PRLock
|
|
PR_ASSERT(lock != NULL);
|
|
PR_ASSERT(_PT_PTHREAD_MUTEX_IS_LOCKED(lock->mutex));
|
|
PR_ASSERT(PR_TRUE == lock->locked);
|
|
- PR_ASSERT(pthread_equal(lock->owner, self));
|
|
+ PR_ASSERT(pt_pthread_equal(lock->owner, self));
|
|
|
|
- if (!lock->locked || !pthread_equal(lock->owner, self)) {
|
|
+ if (!lock->locked || !pt_pthread_equal(lock->owner, self)) {
|
|
return PR_FAILURE;
|
|
}
|
|
|
|
@@ -225,7 +232,7 @@ PR_IMPLEMENT(void) PR_AssertCurrentThrea
|
|
* to the correctness of PR_AssertCurrentThreadOwnsLock(), but
|
|
* this particular order makes the assertion more likely to
|
|
* catch errors. */
|
|
- PR_ASSERT(lock->locked && pthread_equal(lock->owner, pthread_self()));
|
|
+ PR_ASSERT(lock->locked && pt_pthread_equal(lock->owner, pthread_self()));
|
|
}
|
|
|
|
/**************************************************************/
|
|
@@ -281,7 +288,7 @@ static void pt_PostNotifyToCvar(PRCondVa
|
|
_PT_Notified *notified = &cvar->lock->notified;
|
|
|
|
PR_ASSERT(PR_TRUE == cvar->lock->locked);
|
|
- PR_ASSERT(pthread_equal(cvar->lock->owner, pthread_self()));
|
|
+ PR_ASSERT(pt_pthread_equal(cvar->lock->owner, pthread_self()));
|
|
PR_ASSERT(_PT_PTHREAD_MUTEX_IS_LOCKED(cvar->lock->mutex));
|
|
|
|
while (1)
|
|
@@ -369,7 +376,7 @@ PR_IMPLEMENT(PRStatus) PR_WaitCondVar(PR
|
|
PR_ASSERT(_PT_PTHREAD_MUTEX_IS_LOCKED(cvar->lock->mutex));
|
|
PR_ASSERT(PR_TRUE == cvar->lock->locked);
|
|
/* and it better be by us */
|
|
- PR_ASSERT(pthread_equal(cvar->lock->owner, pthread_self()));
|
|
+ PR_ASSERT(pt_pthread_equal(cvar->lock->owner, pthread_self()));
|
|
|
|
if (_PT_THREAD_INTERRUPTED(thred)) {
|
|
goto aborted;
|
|
@@ -582,7 +589,7 @@ PR_IMPLEMENT(PRIntn) PR_GetMonitorEntryC
|
|
|
|
rv = pthread_mutex_lock(&mon->lock);
|
|
PR_ASSERT(0 == rv);
|
|
- if (pthread_equal(mon->owner, self)) {
|
|
+ if (pt_pthread_equal(mon->owner, self)) {
|
|
count = mon->entryCount;
|
|
}
|
|
rv = pthread_mutex_unlock(&mon->lock);
|
|
@@ -598,7 +605,7 @@ PR_IMPLEMENT(void) PR_AssertCurrentThrea
|
|
rv = pthread_mutex_lock(&mon->lock);
|
|
PR_ASSERT(0 == rv);
|
|
PR_ASSERT(mon->entryCount != 0 &&
|
|
- pthread_equal(mon->owner, pthread_self()));
|
|
+ pt_pthread_equal(mon->owner, pthread_self()));
|
|
rv = pthread_mutex_unlock(&mon->lock);
|
|
PR_ASSERT(0 == rv);
|
|
#endif
|
|
@@ -614,7 +621,7 @@ PR_IMPLEMENT(void) PR_EnterMonitor(PRMon
|
|
PR_ASSERT(0 == rv);
|
|
if (mon->entryCount != 0)
|
|
{
|
|
- if (pthread_equal(mon->owner, self)) {
|
|
+ if (pt_pthread_equal(mon->owner, self)) {
|
|
goto done;
|
|
}
|
|
while (mon->entryCount != 0)
|
|
@@ -646,8 +653,8 @@ PR_IMPLEMENT(PRStatus) PR_ExitMonitor(PR
|
|
PR_ASSERT(0 == rv);
|
|
/* the entries should be > 0 and we'd better be the owner */
|
|
PR_ASSERT(mon->entryCount > 0);
|
|
- PR_ASSERT(pthread_equal(mon->owner, self));
|
|
- if (mon->entryCount == 0 || !pthread_equal(mon->owner, self))
|
|
+ PR_ASSERT(pt_pthread_equal(mon->owner, self));
|
|
+ if (mon->entryCount == 0 || !pt_pthread_equal(mon->owner, self))
|
|
{
|
|
rv = pthread_mutex_unlock(&mon->lock);
|
|
PR_ASSERT(0 == rv);
|
|
@@ -695,7 +702,7 @@ PR_IMPLEMENT(PRStatus) PR_Wait(PRMonitor
|
|
/* the entries better be positive */
|
|
PR_ASSERT(mon->entryCount > 0);
|
|
/* and it better be owned by us */
|
|
- PR_ASSERT(pthread_equal(mon->owner, pthread_self()));
|
|
+ PR_ASSERT(pt_pthread_equal(mon->owner, pthread_self()));
|
|
|
|
/* tuck these away 'till later */
|
|
saved_entries = mon->entryCount;
|