kpriv/pkgsrc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
pkgsrc/mk
History
rillig ac62ef6aaf mk/subst.mk: fix combination of SUBST_FILTER_CMD with SUBST_NOOP_OK=no 
Since SUBST_FILTER_CMD is a shell command, it may contain arbitrary
characters.  The condition in mk/subst.mk that tested whether
SUBST_FILTER_CMD was the default filter command was evaluated at run
time.  In such an evaluation, the variables (lhs and rhs) are fully
expanded before parsing the condition.  This means that these variables
must not contain quotes or unquoted condition operators.

Exactly this situation came up in one of the regression tests.  The
quoted "0-9" was copied verbatimly into the condition, including the
quotes.  The resulting condition was:

	"tr -d "0-9"" == "LC_ALL=C /usr/bin/sed "

This produced a syntax error because of the left-hand side. Adding a :Q
modifier would have helped for the left-hand side, but this would have
been necessary for the right-hand side as well.  Since an empty SUBST_SED
is defined not to "contain only identity substitutions", the first
condition can simply be removed.

The whole condition in the shell program had not worked anyway since it
expanded to either "[ true ]" or to "[ false ]", and both of these
commands exited successfully.
2020-04-29 22:46:42 +00:00
..
build mk/build/build.mk: use the login shell by default for build-env 2020-04-25 21:36:17 +00:00
buildlink3 mk/buildlink3: add some more variables to show-all-bl3 2019-08-18 21:00:10 +00:00
check mk/check/check-wrkref.mk: fix shell quoting 2020-04-26 14:23:25 +00:00
checksum Remove clauses 3,4 from TNF-only copyright blocks. 2018-08-22 20:48:36 +00:00
cmake-Modules/Platform
compiler Adjust last to really prepend in the case of cwrappers. 2020-04-17 13:36:26 +00:00
configure mk/configure/replace-localedir.mk: allow SUBST to be a no-op 2020-03-30 22:57:18 +00:00
defaults options.description: add openbox and xfce4-wm (used by LXQt) 2020-04-26 03:17:41 +00:00
depends mk: allow "bmake clean depends" as shortcut 2019-05-07 19:36:43 +00:00
emulator Prepare for compat80 package. 2019-10-15 11:15:49 +00:00
extract mk/extract/bsd.extract-vars.mk: make documentation more user-friendly 2020-03-20 17:16:34 +00:00
features mk: use a single form for headings in the documentation comments 2019-09-02 02:23:02 +00:00
fetch mk/fetch/fetch.mk: Use -f with ofhttp 2020-04-25 11:36:20 +00:00
gnu-config PR pkg/54686: try to handle NetBSD/arm without architecture version the same 2019-11-13 19:06:42 +00:00
haskell Use hashed package keys for (un)installing Cabal packages 2020-01-09 12:29:32 +00:00
help mk/help/help.awk: find library functions in undefined-references.help 2020-03-30 06:21:52 +00:00
init
install mk: Skip CTF_FILES_SKIP before anything else. 2019-09-06 09:00:35 +00:00
internal
misc mk/misc/can-be-built-here.mk: remove NOT_FOT_UNPRIVILEGED 2020-04-26 06:56:29 +00:00
package mk: allow "bmake clean depends" as shortcut 2019-05-07 19:36:43 +00:00
patch mk: allow "bmake clean depends" as shortcut 2019-05-07 19:36:43 +00:00
pbulk Sort the list of files included during a scan run and remove duplicates. 2020-01-13 22:08:33 +00:00
pkgformat mk/pkgformat: include only relevant ident strings in +BUILD_VERSION 2020-01-15 20:11:11 +00:00
pkginstall Work around a potential shell bug where "${FOO=${BAR%/*}}" does not work 2020-04-15 13:33:32 +00:00
pkgtasks mk/misc: make configuration for show-all targets more configurable 2018-11-30 18:38:19 +00:00
platform Add a ulimit flag for address space limits. Support it on NetBSD for 2020-03-22 21:17:30 +00:00
plist mk/plist/print-plist.mk: add show-all-print-PLIST target 2020-04-18 10:54:21 +00:00
repro
scripts mk/subst.mk: allow identity substitutions in SUBST_NOOP_OK=no mode 2020-04-29 18:33:56 +00:00
tools mk/tools: in show-all-tools, sort tool variables by relevance 2020-03-13 17:33:02 +00:00
wrapper mk/wrapper: allow "unwrap" to be a no-op SUBST block 2020-04-27 05:23:11 +00:00
alternatives.mk mk/*: improve documentation for "make help" 2018-05-16 21:23:02 +00:00
apache.mk apache.mk: update comment, apache22 is gone, so is the "ap22" prefix 2019-12-28 11:43:58 +00:00
apache.module.mk
bdb.buildlink3.mk mk: use a single form for headings in the documentation comments 2019-09-02 02:23:02 +00:00
bsd.fast.prefs.mk
bsd.hacks.mk Remove clauses 3,4 from TNF-only copyright blocks. 2018-08-22 20:48:36 +00:00
bsd.makevars.mk
bsd.options.mk mk/misc: make configuration for show-all targets more configurable 2018-11-30 18:38:19 +00:00
bsd.pkg.barrier.mk New target test-env, like build-env and configure-env. 2020-03-23 00:33:48 +00:00
bsd.pkg.clean.mk
bsd.pkg.debug.mk
bsd.pkg.error.mk mk/bsd.pkg.error.mk: fix alignment of the backslashes 2019-09-08 09:15:01 +00:00
bsd.pkg.mk mk: Support undefined UNLIMIT_RESOURCES. 2020-03-26 12:23:54 +00:00
bsd.pkg.readme.mk
bsd.pkg.subdir.mk
bsd.pkg.update.mk mk/bsd.pkg.update.mk: fix indentation 2020-01-11 19:30:50 +00:00
bsd.pkg.use.mk mk/bsd.pkg.use.mk: add more keywords for "bmake help" 2020-03-12 00:12:23 +00:00
bsd.prefs.mk mk/bsd.prefs.mk: add PREFIX to show-all-dirs 2020-03-22 11:07:14 +00:00
bsd.utils.mk
compiler.mk mk/compiler.mk: Add c++17 2019-07-23 13:57:04 +00:00
curses.buildlink3.mk mk: use a single form for headings in the documentation comments 2019-09-02 02:23:02 +00:00
curses.builtin.mk mk/curses.builtin.mk: add mouse function check 2019-06-17 18:19:55 +00:00
cwrappers.mk mk: allow "bmake clean depends" as shortcut 2019-05-07 19:36:43 +00:00
db1.builtin.mk
djbware.mk mk/djbware.mk: make the errno.h hack configurable 2020-03-20 19:40:39 +00:00
dlopen.buildlink3.mk
dlopen.builtin.mk
endian.mk
fam.buildlink3.mk
fonts.mk mk/fonts.mk: Empty USE_LANGUAGES 2020-03-22 09:46:10 +00:00
fuse.buildlink3.mk
haskell.mk Missed a spot -- set MAKE_ENV during haddock build too. 2020-03-30 18:23:48 +00:00
java-env.mk
java-vm.mk datasize limits for VMs should also be matched by VM limits. 2020-03-24 20:41:58 +00:00
jpeg.buildlink3.mk
krb5.buildlink3.mk
Kyuafile
libusb.buildlink3.mk mk: use a single form for headings in the documentation comments 2019-09-02 02:23:02 +00:00
license.mk mk/license.mk: adjust location of the ninka package 2020-04-19 12:53:21 +00:00
linux-pam.builtin.mk mk/linux-pam: replace obsolete _PKG_SILENT with RUN 2020-03-15 23:03:03 +00:00
love.mk s/wip/games/, thanks leot for the ping. 2018-10-01 18:25:17 +00:00
motif.buildlink3.mk
mpi.buildlink3.mk mk: use a single form for headings in the documentation comments 2019-09-02 02:23:02 +00:00
mysql.buildlink3.mk mk/mysql.buildlink3.mk: fix fatal error when no MySQL version is found 2020-03-15 17:50:28 +00:00
ocaml.mk Use MAKE_ENV when calling dune in ocaml.mk 2020-04-21 11:23:29 +00:00
omf-scrollkeeper.mk
oss.buildlink3.mk mk/oss.buildlink3.mk: Simplify per-OS DEV* conditionals. Add MIDI. 2020-04-11 10:31:14 +00:00
oss.builtin.mk mk: use direct include paths 2019-06-30 21:28:28 +00:00
pam.buildlink3.mk
pax.mk
pf.buildlink3.mk
pgsql.buildlink3.mk postgresql12: added version 12.0 2019-10-07 19:21:48 +00:00
pkg-build-options.mk mk/pkg-build-options: fail immediately if pkgbase is not set 2020-03-15 10:33:42 +00:00
pthread.buildlink3.mk mk: use direct include paths 2019-06-30 21:28:28 +00:00
pthread.builtin.mk mk: use direct include paths 2019-06-30 21:28:28 +00:00
readline.buildlink3.mk mk: use a single form for headings in the documentation comments 2019-09-02 02:23:02 +00:00
readline.builtin.mk
resolv.buildlink3.mk
smf.mk
solaris-pam.builtin.mk
subst.mk mk/subst.mk: fix combination of SUBST_FILTER_CMD with SUBST_NOOP_OK=no 2020-04-29 22:46:42 +00:00
termcap.buildlink3.mk mk: use a single form for headings in the documentation comments 2019-09-02 02:23:02 +00:00
termcap.builtin.mk
terminfo.buildlink3.mk mk: use a single form for headings in the documentation comments 2019-09-02 02:23:02 +00:00
terminfo.builtin.mk
unprivileged.mk mk: use a single form for headings in the documentation comments 2019-09-02 02:23:02 +00:00
x11.buildlink3.mk
x11.builtin.mk
x11.version.mk
xaw.buildlink3.mk