From f64440867d8a3d4b189c697dd6fd5925df5e9ac4 Mon Sep 17 00:00:00 2001 From: auouymous Date: Wed, 25 Jan 2023 16:44:06 -0700 Subject: [PATCH] Don't display stacktrace for common download errors. --- src/gpodder/download.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/gpodder/download.py b/src/gpodder/download.py index b01cc6e8..3ee02cdf 100644 --- a/src/gpodder/download.py +++ b/src/gpodder/download.py @@ -984,7 +984,7 @@ class DownloadTask(object): except ConnectionError as ce: # special case request exception result = DownloadTask.FAILED - logger.error('Download failed: %s', str(ce), exc_info=True) + logger.error('Download failed: %s', str(ce)) d = {'host': ce.args[0].pool.host, 'port': ce.args[0].pool.port} self.error_message = _("Couldn't connect to server %(host)s:%(port)s" % d) except RequestException as re: @@ -992,20 +992,19 @@ class DownloadTask(object): if isinstance(re.args[0], MaxRetryError): re = re.args[0] logger.error('%s while downloading "%s"', str(re), - self.__episode.title, exc_info=True) + self.__episode.title) result = DownloadTask.FAILED d = {'error': str(re)} self.error_message = _('Request Error: %(error)s') % d except IOError as ioe: logger.error('%s while downloading "%s": %s', ioe.strerror, - self.__episode.title, ioe.filename, exc_info=True) + self.__episode.title, ioe.filename) result = DownloadTask.FAILED d = {'error': ioe.strerror, 'filename': ioe.filename} self.error_message = _('I/O Error: %(error)s: %(filename)s') % d except gPodderDownloadHTTPError as gdhe: logger.error('HTTP %s while downloading "%s": %s', - gdhe.error_code, self.__episode.title, gdhe.error_message, - exc_info=True) + gdhe.error_code, self.__episode.title, gdhe.error_message) result = DownloadTask.FAILED d = {'code': gdhe.error_code, 'message': gdhe.error_message} self.error_message = _('HTTP Error %(code)s: %(message)s') % d