Commit Graph

71 Commits

Author SHA1 Message Date
Teemu Ikonen 6bd0bb0530 Remove unused imports and pass statements
Fixes flake8 error F401.
Most errors were fixed by running

autoflake -i -r --remove-all-unused-imports .

which also removes unnecessary 'pass' statements, some by hand-editing.
2022-11-14 18:32:09 +02:00
Thomas Perl 576ae2a762 Remove unneeded shebang lines 2022-08-04 12:39:05 +02:00
Thomas Perl 37e296c629 [shebang] Change /usr/bin/python -> /usr/bin/env python3
This should fix "unusual interpreter" Lintian warnings here:
https://udd.debian.org/lintian/?packages=gpodder
2022-08-04 11:53:08 +02:00
auouymous 0fe74c18d2 Generate HTML episode description only when needed.
PR #1094 generated an HTML description for any episode that lacked one.
That however increased the database size (almost double in worst case)
because it was storing both text and html versions of each description.
This fixes that by storing the episode thumbnail URL in the database and
generating the HTML description only when shownotes are drawn.

The text description is now cleared for episodes with an HTML
description. This further reduces database size for feeds that provide
both. It also fixes an issue for feeds that provide different text and
HTML descriptions, because the short description would show the text
description and shownotes would show the HTML description. And EQL only
searched the text descriptions, which might not match what the user sees
in the shownotes.
2022-06-19 11:56:12 -06:00
auouymous 41c312dd68 Change deprecated logger.warn() to logger.warning(). 2022-04-29 02:54:32 -06:00
auouymous 3dd11edf2b Fix soundcloud API change when adding new channels.
The API no longer uses the username to query user info. This requires an
extra page fetch to find the user ID when adding new users.
2021-07-18 04:27:40 -06:00
auouymous 91cf6c9410 Prevent soundcloud from downloading existing episodes each update.
GUIDs are stored in the database as strings, but soundcloud creates them
as integers. Python no longer succeeds when comparing these integers to
the string keys from the existing database entries. This produces new
episodes on every update which then collide with the existing GUIDs.
2021-06-08 00:55:35 -06:00
eric casteleijn af82f96ac8
Update soundcloud.py
Fix usage of a variable that was renamed in this commit: 3babb86c70 (bare except was hiding the error, but flake8 or pylint would have spotted this.)
2021-03-16 12:08:57 -07:00
Teemu Ikonen 0e94386bd3 Use raw strings in regexp patterns, fix DeprecationWarnings 2021-01-15 13:48:21 +02:00
Eric Le Lay d40bc49e0e move download's get_header_param() to util, to use in soundcloud plugin 2020-07-12 17:06:34 +02:00
Eric Le Lay 3babb86c70 use requests package for util.urlopen
now a requests.Response is returned instead of the file-like object from urllib.
Fixed all usages of util.urlopen: it simplifies getting json, text encoding detection.
In particular feedcore (responsible for fetching feeds) is simplified.

This is a first pass and could benefit from better usage of the requests api
(Sessions for instance, to keep connection pools)

TODO: download.py
2020-07-11 17:42:28 +02:00
Eric Le Lay 5e9d2923db Merge remote-tracking branch 'origin/master' into youtube-dl 2019-08-27 20:49:51 +02:00
Eric Le Lay 28f729f15e use stream_url or download_url when applicable 2019-08-26 20:56:16 +02:00
Eric Le Lay a7fbe0d531 use registry.feed_handler instead of gPodderFetcher.custom_handlers 2019-08-17 17:48:52 +02:00
Eric Le Lay 034e3ffa2b Merge default and custom feed handling; support paged feeds
RFC 5005 (http://podlove.org/paged-feeds/)

Fixes #231
2019-06-09 18:59:09 +02:00
Eric Le Lay 0b36f1ee60 pass max_episodes to custom feed handlers 2019-05-19 15:04:17 +02:00
Eric Le Lay 4f063851b1 Custom feeds: change handle_url to fetch_channel 2019-05-18 17:16:06 +02:00
MarkusHackspacher 9a45b04c23 fix E128 continuation line under-indented for visual indent 2018-08-18 12:27:24 +02:00
MarkusHackspacher c99fca923e fix E231 missing whitespace after ',' 2018-05-29 22:54:05 +02:00
MarkusHackspacher bfa93465d3 fix E201 whitespace after '(' 2018-05-21 21:40:40 +02:00
MarkusHackspacher 11bf9e3ef8 fix E401 multiple imports on one line 2018-05-05 23:50:37 +02:00
MarkusHackspacher 52ddd60434 fix E228 missing whitespace around modulo operator
see issue https://github.com/gpodder/gpodder/issues/393
2018-03-18 01:00:02 +01:00
MarkusHackspacher 5bb63884e8 fix E226 missing whitespace around arithmetic operator
in /tools/
2018-03-04 21:15:21 +01:00
MarkusHackspacher a90fa0b521 fix W391 blank line at end of file 2018-02-11 21:51:40 +01:00
MarkusHackspacher 0c18a43d13 fix E302 and E303, only blank line change 2018-02-11 00:22:00 +01:00
MarkusHackspacher 955499fcd1 fix E305 expected 2 blank lines after class or function definition 2018-02-10 11:11:20 +01:00
Thomas Perl 98ec45a712 Update copyright years (2018) 2018-01-28 19:39:53 +01:00
Thomas Perl 7b46a0ee72 Update copyright years (2017) 2017-12-16 13:54:59 +01:00
Eric Le Lay 858497936f Merge branch 'master' into gtk3
- soundcloud non downloadable tracks
- try to parse feeds even if content-type says HTML
2017-11-27 22:27:41 +01:00
Eric Le Lay 6fb609cab4 Increase Soundcloud downloadable track logging
fixes #343
2017-10-19 18:08:09 +02:00
Adam Voss a6208617df Merge Merge pull request #242 from vossad01/soundcloud-default-https
Use https urls for SoundCloud requests
2017-03-25 23:10:09 -05:00
Adam Voss db7ba2f56d Merge Merge pull request #241 from vossad01/soundcloud-handle-https
Updates SoundCloud support to recognize https urls
2017-03-25 23:08:01 -05:00
Adam Voss 59daf51459 Merge pull request #240 from christofdamian/fixing-soundcloud-feeds
Fix soundcloud feeds by using user id for track lists
2017-03-25 23:06:45 -05:00
Adam Voss ecae38d918 Merge pull request #242 from vossad01/soundcloud-default-https
Use https urls for SoundCloud requests
2017-03-19 10:08:31 -05:00
Adam Voss 8e989adc54 Merge pull request #241 from vossad01/soundcloud-handle-https
Updates SoundCloud support to recognize https urls
2017-03-19 10:07:18 -05:00
Adam Voss 5c1507671d Updates SoundCloud support to recognize https urls 2017-03-19 09:52:03 -05:00
Adam Voss ef915dd3b6 Use https urls for SoundCloud requests 2017-03-19 09:30:06 -05:00
Christof Damian e7f34ad090 Fix soundcloud feeds by using user id for track lists 2017-03-06 13:46:00 +01:00
Thomas Perl 0122e8cc00 Merge branch 'master' into gtk3 2016-12-18 13:12:04 +01:00
mprangenberg c83e034174 Increase number of tracks to API page-limit
Standard API page-limit is 50 results, this increases that to 200 results.
2016-12-01 15:27:07 +01:00
Eric Le Lay fd0f9c2403 remove pre-python 2.6 compat code 2016-11-26 16:05:17 +01:00
Thomas Perl e020448e14 More Python 3 fixes (Soundcloud, util) 2016-11-21 23:19:20 +01:00
Thomas Perl 5a7c30b359 Port to Python 3 2016-11-21 23:13:46 +01:00
Thomas Perl 36eefc8a30 Update copyright years (2016) 2016-01-15 15:22:52 +01:00
Thomas Perl aa72634950 Update copyright years (2015) 2015-05-24 19:33:39 +02:00
Thomas Perl c022d9e453 Gtk UI: New podcast directory UI 2014-10-22 21:23:06 +02:00
Thomas Perl d81d7617d3 gpodder.xspf: Remove broken plugin 2014-03-17 19:58:55 +01:00
Thomas Perl 553e35f219 Update copyright years (2014) 2014-02-27 21:55:13 +01:00
Thomas Perl bda982be02 Update copyright years for 2013 2013-03-05 16:38:48 +01:00
Thomas Perl 670e439145 Soundcloud: Fix bug with empty/null descriptions 2012-03-05 11:23:41 +01:00