Commit Graph

37 Commits

Author SHA1 Message Date
Teemu Ikonen 6bd0bb0530 Remove unused imports and pass statements
Fixes flake8 error F401.
Most errors were fixed by running

autoflake -i -r --remove-all-unused-imports .

which also removes unnecessary 'pass' statements, some by hand-editing.
2022-11-14 18:32:09 +02:00
Thomas Perl 576ae2a762 Remove unneeded shebang lines 2022-08-04 12:39:05 +02:00
Thomas Perl 37e296c629 [shebang] Change /usr/bin/python -> /usr/bin/env python3
This should fix "unusual interpreter" Lintian warnings here:
https://udd.debian.org/lintian/?packages=gpodder
2022-08-04 11:53:08 +02:00
auouymous 0fe74c18d2 Generate HTML episode description only when needed.
PR #1094 generated an HTML description for any episode that lacked one.
That however increased the database size (almost double in worst case)
because it was storing both text and html versions of each description.
This fixes that by storing the episode thumbnail URL in the database and
generating the HTML description only when shownotes are drawn.

The text description is now cleared for episodes with an HTML
description. This further reduces database size for feeds that provide
both. It also fixes an issue for feeds that provide different text and
HTML descriptions, because the short description would show the text
description and shownotes would show the HTML description. And EQL only
searched the text descriptions, which might not match what the user sees
in the shownotes.
2022-06-19 11:56:12 -06:00
Eric Le Lay 913b386294 fix tagging extension exception on mkv files 2020-07-06 12:48:52 +02:00
Eric Le Lay d2db5b001c update extension doc links 2020-05-25 18:39:14 +02:00
Eric Le Lay fa5c217c9e fix error when tagging m4a files 2020-04-15 09:49:42 +02:00
Eric Le Lay dc057342fb fix #737 tagging extension broken in 3.10.12
we need to declare COMM and TIT3 frames in EasyID3 before using them
2020-02-16 16:58:02 +01:00
Eric Le Lay e3853806a7 Revert "Revert "Update tagging.py""
This reverts commit ce920d9d1a.
2020-02-16 16:41:34 +01:00
Eric Le Lay ce920d9d1a
Revert "Update tagging.py" 2020-01-29 12:32:39 +01:00
AntonelloA db077c3c36
Update tagging.py
Added "subtitle" tag to audio podcasts, taken from podcast "episode.description".
To see the change in action, try (before and after) one of the episodes of this podcast: 
http://www.radio.rai.it/radio2/podcast/rssradio2.jsp?id=80
2019-09-29 19:58:47 +02:00
oxholm 339cd4e651 checking object type before calling save with keywords 2019-02-01 22:33:41 -08:00
oxholm 1c6ed0a8da addressing style errors 2019-01-23 15:03:06 -08:00
oxholm 26bceadda7 removed a debug statement 2019-01-23 13:04:32 -08:00
oxholm 9d045292cb added 2 settings to the tagging extension 2019-01-23 13:01:06 -08:00
Eric Le Lay 8ddf7363c1 fix linter warning 2018-10-08 19:19:48 +02:00
bohegeek 2b4fb285eb
correction for issue #556
the update is not working because the jpg file is not opened as a binary file.
The fix is tested on both OS X and Linux
2018-10-07 14:31:48 -04:00
Eric Le Lay 6cf6c2121d fix isort on some extensions 2018-07-29 14:46:29 +02:00
MarkusHackspacher 82f41f4c21 sorting imports
with isort -y -rc
see #393
2018-07-24 11:08:10 +02:00
MarkusHackspacher 8eaa6a3c33 fix E251 unexpected spaces around keyword / parameter equals 2018-05-21 19:26:01 +02:00
MarkusHackspacher eecfd64f63 fix E261 at least two spaces before inline comment 2018-05-17 08:39:56 +02:00
Eric Le Lay 11569ca31d more pycodestyle checks
see #393 for discussion
2018-02-06 15:19:08 +01:00
Eric Le Lay 48c1e18a02 fix tagging extension can't add tags to MP4 with no existing tag 2018-01-01 18:20:42 +01:00
Adam Voss a84560e385 Merge pull request #197 from elelay/taggingBasic
tagging extension: basic support for spx and more formats
2017-03-25 19:28:36 -05:00
Adam Voss bcfdc395d5 Ran `2to3` on 'share' and accepted appropriate changes 2017-03-25 19:25:49 -05:00
Eric Le Lay ba9f491ecd tagging extension: basic support for spx and more formats
no cover art, but title, etc. tags if supported by Mutagen
2016-12-22 21:16:50 +01:00
Eric Le Lay a87609ccdc fix #148 - tag downloaded extension broken 2016-10-02 19:52:44 +02:00
Eric Le Lay 46c05218a1 fix #148 - tag downloaded extension broken 2016-10-02 19:46:39 +02:00
Brian J. Cohen e09b6f9d27 Add 'set_artist_to_album' config option to 'tagging' extension. Effect is to set the 'artist' tag equivalent to whatever the 'album' tag value is.
Signed-off-by: Brian J. Cohen <brian@intercarve.net>
2016-02-19 12:13:31 -05:00
Bernd Schlapsi f1f218ddf2 Add option to auto embed coverart image (bug 1742)
Refactored the code to be able to add filetype specific logic.
Until now we used only the mutagen abstraction to implement one
code for all file types, but this don't work for special needs
(e.g: coverart manipulation)
2013-04-20 14:27:41 +02:00
Bernd Schlapsi bbfcd58ba6 Add option to flattr an extensions and to show documentation
If an extension author adds an flattr url to the extensions metadata
gPodder shows the "Flattr this" menu entry in the popup menu for an
extension in the preference dialog.
Alternative the extension author can add an url to the extensions
metadata to link to the authors donation page (Support the author).

Also the extension author can add an url to the extensions metadata
to link to the extensions user documentation.
2013-04-13 12:27:13 +02:00
Bernd Schlapsi 33bdbe071b Extensions: Add option to remove all tags (bug 1771)
Add a new option to the tagging extension
2013-02-16 15:49:48 +01:00
Bernd Schlapsi d5eae16b9f Improvements to the extension system
- Add category metadata in every extension
- Show this category in the extension list gui
- Add "mandatory_in" and "disable-in" configuration for an extension
- Add Ubuntu unity check to enable/disable unity specific extensions
- Move "gpodder.win32" and "gpodder.osx" setting to the "gpodder.ui" namespace to be able to use it in the extensions category settings
- Only show metadata information in the right-click dialog of an extension
2012-12-07 10:30:28 +01:00
Thomas Perl 181d38dd76 Various extension-related fixes 2012-03-27 01:32:20 +02:00
Thomas Perl 140fdeda57 Extensions: Error reporting on load
Report errors if required commands are not
found or if modules cannot be imported.
2012-03-22 14:53:24 +01:00
Thomas Perl 9c147cf980 Extensions: Various fixes and clean-ups from review 2012-03-22 14:53:24 +01:00
Bernd Schlapsi bca9751b75 Add default extensions (ported from hooks) 2012-03-22 14:53:24 +01:00