Commit Graph

58 Commits

Author SHA1 Message Date
Teemu Ikonen 6bd0bb0530 Remove unused imports and pass statements
Fixes flake8 error F401.
Most errors were fixed by running

autoflake -i -r --remove-all-unused-imports .

which also removes unnecessary 'pass' statements, some by hand-editing.
2022-11-14 18:32:09 +02:00
auouymous 0fe74c18d2 Generate HTML episode description only when needed.
PR #1094 generated an HTML description for any episode that lacked one.
That however increased the database size (almost double in worst case)
because it was storing both text and html versions of each description.
This fixes that by storing the episode thumbnail URL in the database and
generating the HTML description only when shownotes are drawn.

The text description is now cleared for episodes with an HTML
description. This further reduces database size for feeds that provide
both. It also fixes an issue for feeds that provide different text and
HTML descriptions, because the short description would show the text
description and shownotes would show the HTML description. And EQL only
searched the text descriptions, which might not match what the user sees
in the shownotes.
2022-06-19 11:56:12 -06:00
Thomas Perl 3cbb36167c Gtk UI: Handle links in HTML shownotes 2022-04-23 13:54:31 +02:00
Teemu Ikonen 011718c032 gPodderShownotesHTML: Replace Gtk.Action with Gio.SimpleAction
Gtk.Action is deprecated.
2022-02-02 09:31:27 +02:00
Eric Le Lay 8f9159ebc7
Merge pull request #1098 from auouymous/make-text-shownotes-title-clickable
Make the text shownotes title a clickable and copyable link.
2021-07-26 21:13:55 +02:00
auouymous 0578ba503e Make the text shownotes title a clickable and copyable link. 2021-07-17 20:38:10 -06:00
auouymous e9353588f3 Reset shownotes to top when changing episodes.
This prevents the title from being partially clipped when moving between
episodes after scrolling the shownotes for one of them.
2021-07-16 05:16:08 -06:00
Eric Le Lay 8dd8b6b2cd fix 'msgid' format string with unnamed arguments cannot be properly localized warning 2021-06-10 10:28:54 +02:00
Teemu Ikonen 124d7b38a2 Add more episode details to shownotes
Add a line after subheading in shownotes with episode release date,
length and size.
2021-05-10 16:37:35 +03:00
Eric Le Lay c119c45fcf html_shownotes: restore translation and fix margins 2020-12-26 15:19:09 +01:00
Teemu Ikonen 0e3b8aff9d Refactor shownotes
Use GtkOverlay to show link destination in both HTML and text shownotes.

Remove GtkTextView from HTML shownote pane and write a HTML header from
episode title and other data. The title section now scrolls with the
rest of the description text. Plain text descriptions are converted to
HTML by adding <br> tags on newlines.
2020-12-25 00:24:16 +02:00
Eric Le Lay b18fa6674d fix linter warnings 2020-05-13 08:36:22 +02:00
Eric Le Lay 233d4adf48 remove dark-theme detection 2020-05-10 16:56:19 +02:00
Eric Le Lay 5340667b82 use TextView foreground, background, link colors 2020-05-10 16:55:47 +02:00
Eric Le Lay 241aa360a9 smaller episode shownotes font size 2020-05-09 16:31:02 +02:00
Eric Le Lay 834367e25c use the label's colors; can't get the link color
but it returns the same color as the foreground, which is not bad
2020-05-09 16:30:53 +02:00
Eric Le Lay 0e7ba56643 don't use blue hyperlinks on dark themes 2020-05-08 20:10:42 +02:00
Eric Le Lay 1f99e166fb fix jumping webview when hovering a link with long url
the label showing the URL at the bottom of the screen then expands the view
horizontally, causing a relayout.
2019-05-27 21:09:59 +02:00
Eric Le Lay 28e2ef0a06 use channel auth in html shownotes 2019-05-05 17:03:59 +02:00
Eric Le Lay 76feaa7117 fix has_website_link() usage as attribute 2019-05-05 16:47:23 +02:00
Eric Le Lay 48ac787af9 fix #412 let html shownote title spill to next line instead of hzscroll 2018-08-15 16:34:26 +02:00
Eric Le Lay 3d2e7822be add missing require_version 2018-08-02 22:40:33 +02:00
MarkusHackspacher 82f41f4c21 sorting imports
with isort -y -rc
see #393
2018-07-24 11:08:10 +02:00
MarkusHackspacher 0e32494b94 fix codestyle
recognized by travis CI
2018-07-23 11:17:47 +02:00
Eric Le Lay e4334eafb4 gPodderShownotesText prefer description_html to show hyperlinks
fixes #414 comment
2018-07-21 22:01:38 +02:00
Eric Le Lay f8a06d025b gPodderShownotesText shows target and change cursor when mouse pointer is over an hyperlink 2018-07-21 21:58:32 +02:00
Eric Le Lay 031b56f532 shownotes color theme: fix undefined variable stylesheet 2018-02-18 19:22:33 +01:00
Eric Le Lay 444647b23d theme-aware shownotes color in webview
fixes #369
2018-02-15 23:11:41 +01:00
Eric Le Lay 27e0fe05a1 theme-aware foreground and background for shownotes
when a channel is selected
2018-02-15 23:09:25 +01:00
Thomas Perl 98ec45a712 Update copyright years (2018) 2018-01-28 19:39:53 +01:00
Thomas Perl 7b46a0ee72 Update copyright years (2017) 2017-12-16 13:54:59 +01:00
Eric Le Lay 924f4f5919 disable java, javascript, plugins in HTML shownotes 2017-04-23 13:38:43 +02:00
Adam Voss 4bfaeecea2 Merge pull request #266 from elelay/gtk3-plain-text-shownotes
if description is not html, show it as plain-text in webkit
2017-04-18 10:13:53 -05:00
Eric Le Lay 18bd4cd566 show HTML shownotes when episode.link has no path 2017-04-13 22:02:04 +02:00
Eric Le Lay 13c1b8e7db if description is not html, show it as plain-text in webkit 2017-04-09 19:14:41 +02:00
Adam Voss 08c8f4d194 Coerce textual description to HTML when using gPodderShownotesHTML
Needed because model.py no longer does that automatically.
2017-04-08 12:15:03 -05:00
Eric Le Lay 1d01855340 html shownotes fixes following review 2017-02-05 20:49:38 +01:00
Eric Le Lay e2bba3928b html shownotes 2017-01-29 22:38:02 +01:00
Eric Le Lay fd0f9c2403 remove pre-python 2.6 compat code 2016-11-26 16:05:17 +01:00
Eric Le Lay 3757756b95 fix selection white on white in shownotes 2016-10-29 15:03:01 +02:00
Eric Le Lay 6cb0123aed single quote strings in updated code 2016-10-02 19:34:24 +02:00
Eric Le Lay eb1404ff37 gtk3 fixes and cleanup 2016-09-28 11:58:37 +02:00
Eric Le Lay 9d56e65994 draw centered_text, pills, cake
Shows "Please Select an episode" when shownotes shown and refreshing
channels without new episodes.

Shows downloaded and new count after channel name

Shows download progress before episodes
2016-09-28 11:58:37 +02:00
Eric Le Lay ef2df7b867 replace deprecated Gtk{H,V}Paned Gtk{H,V}Box with GtkPaned and GtkBox + orientation
have to set the expand property to children
2016-09-28 11:53:28 +02:00
Thomas Perl 9b8dbdc3a6 New try to do a minimal Gtk+3 port 2016-09-25 14:31:58 +02:00
Thomas Perl 55fb426500 Activate URLs on enter and do not handle selection clicks 2016-08-08 20:10:45 +02:00
Thomas Perl df9647a583 Simplify searching for hyperlinks 2016-08-08 20:10:45 +02:00
Mathias Rav 1831cc9b00 Use util.open_website rather than webbrowser.open to avoid blocking the UI 2016-08-07 17:20:22 +02:00
Mathias Rav c7ab9f6f70 Use html5lib to find hyperlinks in the HTML of the podcast show notes 2016-08-07 12:24:03 +02:00
Thomas Perl e44344a9fe Gtk UI: Remove WebKit1 support
WebKit1 for Gtk2 support is deprecated in Debian, we may want
to re-introduce WebKit(2) support once we have ported gPodder
to Gtk3 and its GObject Introspection-based Python bindings.

See also: https://bugs.debian.org/790218
2016-02-15 07:47:43 +01:00