Commit graph

332 commits

Author SHA1 Message Date
Eric Le Lay
a321db85e3 working windows notifications based on powershell
- fix powershell console briefly displayed on notifications
 - use win10 toast notification instead of balloon if available
 - win10 notifications show as gPodder if it's installed, as
   powershell otherwise (but with gPodder icon)
 - removing notifu from appveyor build since it won't be necessary

See #485
2018-07-29 12:54:36 +02:00
Eric Le Lay
403af81e85 use powershell script to implement windows notifications
the issue is that when running gpodder.exe, the powershell
window shows for a brief instant, because it's a console app.
There is no issue when running gpodder-cmd.exe
see #485.
2018-07-28 21:17:32 +02:00
Eric Le Lay
21acabebb5
Merge pull request #472 from MarkusHackspacher/style231
fix E231 missing whitespace after ','
2018-07-20 14:03:39 +02:00
Eric Le Lay
66bc2a6f72 fix #494 - ensure short filenames
- fix rename_download that was causing #494
- max_length is now mandatory in util.sanitize_filename
- add max_length param where it's missing
- factor name computation in deviceplaylist and sync
2018-07-20 09:38:00 +02:00
Markus Hackspacher
94628749ea
Merge branch 'master' into style231 2018-06-10 14:46:12 +02:00
Eric Le Lay
3101c72387 fix linter warnings 2018-06-10 12:20:04 +02:00
Eric Le Lay
0dee7e39dd menu accelerators + toolbar button names
for better keyboard navigation + screen readers
2018-06-04 22:37:04 +02:00
MarkusHackspacher
c99fca923e fix E231 missing whitespace after ',' 2018-05-29 22:54:05 +02:00
Eric Le Lay
b307b41a40 apply util.Popen everywhere
It will default to close_fds=True.
On Windows, it will log an explanation message on incompatible use of close_fds+redirection.
2018-05-28 21:14:08 +02:00
Eric Le Lay
a1da47dfae Merge branch 'master' of https://github.com/Vhati/gpodder into Vhati-master 2018-05-28 20:32:12 +02:00
Eric Le Lay
92ce200438
Merge pull request #462 from MarkusHackspacher/style251
fix E251 unexpected spaces around keyword / parameter equals
2018-05-27 10:13:02 +02:00
Eric Le Lay
92dcb1c0c3 Merge branch 'master' into gtk3-win_installer 2018-05-27 10:05:11 +02:00
MarkusHackspacher
8eaa6a3c33 fix E251 unexpected spaces around keyword / parameter equals 2018-05-21 19:26:01 +02:00
MarkusHackspacher
eecfd64f63 fix E261 at least two spaces before inline comment 2018-05-17 08:39:56 +02:00
Vhati
68ff1ff35e Added a warning about Popen() and leaked file descriptors 2018-05-16 18:37:28 -04:00
Eric Le Lay
3d7cbcfb6d added missing translatable to menus; make messages 2018-05-13 19:37:16 +02:00
Eric Le Lay
395aec5514
Merge pull request #448 from gpodder/340-connection-limit
support jumps in limit downloads
2018-05-13 17:32:32 +02:00
Eric Le Lay
5ade7d40ff
Merge pull request #457 from MarkusHackspacher/code-e702
Fix E502 the backslash is redundant between brackets
2018-05-13 17:30:10 +02:00
MarkusHackspacher
49bb08c8a3 fix E502 the backslash is redundant between brackets 2018-05-08 10:43:56 +02:00
MarkusHackspacher
039ffba236 fix E731 do not assign a lambda expression, use a def 2018-05-06 22:26:54 +02:00
MarkusHackspacher
11bf9e3ef8 fix E401 multiple imports on one line 2018-05-05 23:50:37 +02:00
Eric Le Lay
0f88112905 notifications as Gtk.MessageDialog on windows 2018-05-02 10:59:03 +02:00
MarkusHackspacher
9adb9a7d22 fix E124 closing bracket does not match visual indentation
add e124 and E220 to E229 as E22 in setup.cfg
2018-05-01 14:22:18 +02:00
Vhati
7698b0dc41 Fixed file descriptor leaks into child processes 2018-04-29 17:12:47 -04:00
Eric Le Lay
5d4b99cd68 unchecked 'download limit' really means 16 download limit
fixes #151 Client is opening an insane amount of parallel connections
2018-04-29 15:59:22 +02:00
Jason Lingohr
57b62e7ab8
Updates from review. 2018-04-21 12:40:59 +10:00
Jason Lingohr
288acdec67
Improve sonos.py a bit
Some modifications to better handle grouped speakers, as well as showing them as a target choice.
2018-04-20 13:27:27 +10:00
Eric Le Lay
3d64e671a4
Merge pull request #440 from elelay/soco-update
sonos extension: update to soco >= 0.7 API
2018-04-19 21:55:01 +02:00
Eric Le Lay
afe8d458ba sonos extension: remove controller from any group
suggested by @lingfish
2018-04-19 21:54:18 +02:00
Eric Le Lay
d468482573 fix sonos.py code 2018-04-18 21:52:18 +02:00
Eric Le Lay
fa5a289396 finish fixing E226 2018-04-15 18:59:20 +02:00
Eric Le Lay
ecf732d9c9 sonos extension: update to soco >= 0.7 API
fixes #431
2018-04-15 18:34:57 +02:00
MarkusHackspacher
52ddd60434 fix E228 missing whitespace around modulo operator
see issue https://github.com/gpodder/gpodder/issues/393
2018-03-18 01:00:02 +01:00
Eric Le Lay
41f893806a documentation link for Command on Download extension
fixes #317
2018-03-17 16:44:40 +01:00
Eric Le Lay
192fc3d730
Merge pull request #418 from MarkusHackspacher/codestyle7
fix W503 line break before binary operator
2018-03-17 15:37:07 +01:00
Eric Le Lay
2a811fbf30
Merge pull request #402 from gpodder/command_on_download_ext
Extension to run a command on download
2018-03-14 20:00:30 +01:00
MarkusHackspacher
41f07738ff fix W503 line break before binary operator 2018-03-04 20:27:00 +01:00
MarkusHackspacher
91e2ea9f85 Merge github.com:gpodder/gpodder into codestyle4 2018-02-17 08:09:53 +01:00
Eric Le Lay
798babad8f fix mpris-listener extension error from gpo 2018-02-15 20:59:33 +01:00
Eric Le Lay
570c9ae90f Extension to run a command on download
closes #317
2018-02-11 22:27:44 +01:00
MarkusHackspacher
a90fa0b521 fix W391 blank line at end of file 2018-02-11 21:51:40 +01:00
MarkusHackspacher
0c18a43d13 fix E302 and E303, only blank line change 2018-02-11 00:22:00 +01:00
MarkusHackspacher
d927b5176b Merge github.com:gpodder/gpodder into codestyle 2018-02-06 18:37:46 +01:00
MarkusHackspacher
9dca8e0506 fix E306 expected 1 blank line before a nested definition 2018-02-06 18:33:52 +01:00
Eric Le Lay
11569ca31d more pycodestyle checks
see #393 for discussion
2018-02-06 15:19:08 +01:00
MarkusHackspacher
fcbaee227c Fix W291 trailing whitespace 2018-02-01 07:59:22 +01:00
MarkusHackspacher
c1c841c08c Fix W293 blank line contains whitespace 2018-01-30 14:04:28 +01:00
Eugene Nikolsky
065a316677 Set '<Primary>E' as the shortcut for episode's "Toggle New Status"
Verified that it works on OSX 10.11.6 (where the shortcut is 'Cmd+E')
for one and multiple selected episodes.

This reapplies commit bb4d31fc60 into the
`master` branch.
2018-01-28 20:07:27 -08:00
Thomas Perl
98ec45a712 Update copyright years (2018) 2018-01-28 19:39:53 +01:00
Eric Le Lay
48c1e18a02 fix tagging extension can't add tags to MP4 with no existing tag 2018-01-01 18:20:42 +01:00