maryjane/syncevolution
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

engine: call getenv() only once

Browse source 
Helps Klocwork, which otherwise warned about the potential
NULL return from the second call.
This commit is contained in:
Patrick Ohly 2013-03-22 02:45:11 -07:00
parent cbac788a65
commit 132e915624
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/syncevo/SyncContext.cpp
View file

@ -2872,7 +2872,7 @@ void SyncContext::initMain(const char *appname)
// pulls it into the process by loading libecal.
EDSAbiWrapperInit();
if (getenv("SYNCEVOLUTION_GNUTLS_DEBUG")) {
if (const char *gnutlsdbg = getenv("SYNCEVOLUTION_GNUTLS_DEBUG")) {
// Enable libgnutls debugging without creating a hard dependency on it,
// because we don't call it directly and might not even be linked against
// it. Therefore check for the relevant symbols via dlsym().
@ -2884,7 +2884,7 @@ void SyncContext::initMain(const char *appname)
set_log_function = (typeof(set_log_function))dlsym(RTLD_DEFAULT, "gnutls_global_set_log_function");
if (set_log_level && set_log_function) {
set_log_level(atoi(getenv("SYNCEVOLUTION_GNUTLS_DEBUG")));
set_log_level(atoi(gnutlsdbg));
set_log_function(GnutlsLogFunction);
} else {
SE_LOG_ERROR(NULL, NULL, "SYNCEVOLUTION_GNUTLS_DEBUG debugging not possible, log functions not found");