cppcheck performance: Prefer prefix ++/-- operators for non-primitive types.

This fixes all instances found by cppcheck where a prefix opererator
should have been used.
This commit is contained in:
Patrick Ohly 2014-01-07 00:43:52 -08:00
parent db01a1a8cc
commit 37c43f00ea
6 changed files with 9 additions and 9 deletions

View File

@ -401,7 +401,7 @@ void EvolutionCalendarSource::listAllItems(RevisionMap_t &revisions)
// Update m_allLUIDs
m_allLUIDs.clear();
RevisionMap_t::iterator it;
for(it = revisions.begin(); it != revisions.end(); it++) {
for(it = revisions.begin(); it != revisions.end(); ++it) {
m_allLUIDs.insertLUID(it->first);
}
#else

View File

@ -272,7 +272,7 @@ TrackingSyncSource::InsertItemResult MaemoCalendarSource::insertItem(const strin
}
vector< CComponent * >::iterator it = comps.begin();
if (comps.size() > 1) {
for (; it != comps.end(); it++) {
for (; it != comps.end(); ++it) {
delete (*it);
}
throwError(string("too many events in ical: ") + item);

View File

@ -99,7 +99,7 @@ void XMLRPCSyncSource::listAllItems(RevisionMap_t &revisions)
static_cast<map<string, xmlrpc_c::value> >(tmp));
map<string, xmlrpc_c::value>::const_iterator it;
for(it = resultMap.begin(); it != resultMap.end(); it++)
for(it = resultMap.begin(); it != resultMap.end(); ++it)
revisions[(*it).first] = xmlrpc_c::value_string((*it).second);
}

View File

@ -164,12 +164,12 @@ static void copyProperty(const StringPair &keyvalue,
static void setSyncFilters(const ReadOperations::Config_t &config,FilterConfigNode::ConfigFilter &syncFilter,std::map<std::string, FilterConfigNode::ConfigFilter> &sourceFilters)
{
ReadOperations::Config_t::const_iterator it;
for (it = config.begin(); it != config.end(); it++) {
for (it = config.begin(); it != config.end(); ++it) {
map<string, string>::const_iterator sit;
string name = it->first;
if (name.empty()) {
ConfigPropertyRegistry &registry = SyncConfig::getRegistry();
for (sit = it->second.begin(); sit != it->second.end(); sit++) {
for (sit = it->second.begin(); sit != it->second.end(); ++sit) {
// read-only properties can (and have to be) ignored
static const char *init[] = {
"configName",
@ -191,7 +191,7 @@ static void setSyncFilters(const ReadOperations::Config_t &config,FilterConfigNo
name = name.substr(strlen("source/"));
FilterConfigNode::ConfigFilter &sourceFilter = sourceFilters[name];
ConfigPropertyRegistry &registry = SyncSourceConfig::getRegistry();
for (sit = it->second.begin(); sit != it->second.end(); sit++) {
for (sit = it->second.begin(); sit != it->second.end(); ++sit) {
copyProperty(*sit, registry, sourceFilter);
}
} else {
@ -312,7 +312,7 @@ void Session::setNamedConfig(const std::string &configName,
/* apply user settings */
from->setConfigFilter(true, "", syncFilter);
map<string, FilterConfigNode::ConfigFilter>::iterator it;
for ( it = sourceFilters.begin(); it != sourceFilters.end(); it++ ) {
for (it = sourceFilters.begin(); it != sourceFilters.end(); ++it) {
from->setConfigFilter(false, it->first, it->second);
}

View File

@ -218,7 +218,7 @@ void IniFileConfigNode::removeProperty(const string &property)
it = m_lines.erase(it);
m_modified = true;
} else {
it++;
++it;
}
}
}

View File

@ -985,7 +985,7 @@ std::vector<std::string> unescapeJoinedString (const std::string& src, char sep)
if (!((s1.length() - ((pos == s1.npos) ? 0: pos-1)) &1 )) {
s2="";
boost::trim (s1);
for (std::string::iterator i = s1.begin(); i != s1.end(); i++) {
for (std::string::iterator i = s1.begin(); i != s1.end(); ++i) {
//unescape characters
if (*i == '\\') {
if(++i == s1.end()) {