maryjane/syncevolution
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

PIM Manager: remove redundant type check+cast

Browse source 
Cut-and-paste error, casting into FolksAbstractFieldDetails twice is
unnecessary.
This commit is contained in:
Patrick Ohly 2013-03-27 16:57:52 +01:00
parent d9881c30f5
commit 4fd4334821
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/dbus/server/pim/individual-traits.cpp
View file

@ -286,7 +286,7 @@ template <> struct dbus_traits<FolksPostalAddressFieldDetails *> {
static void append(builder_type &builder, FolksPostalAddressFieldDetails *value) {
g_variant_builder_open(&builder, G_VARIANT_TYPE(StringPrintf("(%sas)", INDIVIDUAL_DICT).c_str())); // pair of dict and string list
FolksAbstractFieldDetails *fieldDetails = FOLKS_ABSTRACT_FIELD_DETAILS(value);
gconstpointer v = folks_abstract_field_details_get_value(FOLKS_ABSTRACT_FIELD_DETAILS(fieldDetails));
gconstpointer v = folks_abstract_field_details_get_value(fieldDetails);
dbus_traits<FolksPostalAddress *>::append(builder, static_cast<FolksPostalAddress *>(const_cast<gpointer>(v)));
g_variant_builder_open(&builder, G_VARIANT_TYPE("as"));
GeeMultiMap *map = folks_abstract_field_details_get_parameters(fieldDetails);
@ -303,7 +303,7 @@ template <> struct dbus_traits<FolksPostalAddressFieldDetails *> {
template <> struct dbus_traits<FolksNoteFieldDetails *> {
static void append(builder_type &builder, FolksNoteFieldDetails *value) {
FolksAbstractFieldDetails *fieldDetails = FOLKS_ABSTRACT_FIELD_DETAILS(value);
gconstpointer v = folks_abstract_field_details_get_value(FOLKS_ABSTRACT_FIELD_DETAILS(fieldDetails));
gconstpointer v = folks_abstract_field_details_get_value(fieldDetails);
dbus_traits<const char *>::append(builder, static_cast<const char *>(v)); // plain string
// Ignore parameters. LANGUAGE is hardly ever set.
}
@ -312,7 +312,7 @@ template <> struct dbus_traits<FolksNoteFieldDetails *> {
template <> struct dbus_traits<FolksRoleFieldDetails *> {
static void append(builder_type &builder, FolksRoleFieldDetails *value) {
FolksAbstractFieldDetails *fieldDetails = FOLKS_ABSTRACT_FIELD_DETAILS(value);
gconstpointer v = folks_abstract_field_details_get_value(FOLKS_ABSTRACT_FIELD_DETAILS(fieldDetails));
gconstpointer v = folks_abstract_field_details_get_value(fieldDetails);
dbus_traits<FolksRole *>::append(builder, static_cast<FolksRole *>(const_cast<gpointer>((v))));
// Ignore parameters. LANGUAGE is hardly ever set.
}