maryjane/syncevolution
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

dbus client: stop leaking memory on every dbus callback

Browse source
This commit is contained in:
Jussi Kukkonen 2009-04-23 16:50:15 +01:00
parent a09ce3d9ca
commit 98a02241bc
3 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/gtk-ui/sync-ui.c
View file

@ -307,6 +307,9 @@ get_server_config_for_template_cb (SyncevoService *service, GPtrArray *options,
g_ptr_array_free (data->options_override, TRUE);
}
g_slice_free (server_data ,data);
g_ptr_array_foreach (options, (GFunc)syncevo_option_free, NULL);
g_ptr_array_free (options, TRUE);
}
static void
@ -950,6 +953,10 @@ get_sync_reports_cb (SyncevoService *service, GPtrArray *reports, GError *error,
syncevo_report_array_get (session_report, &data->last_sync, NULL);
}
refresh_last_synced_label (data);
g_ptr_array_foreach (reports, (GFunc)syncevo_report_array_free, NULL);
g_ptr_array_free (reports, TRUE);
}
static void
@ -977,6 +984,9 @@ get_server_config_cb (SyncevoService *service, GPtrArray *options, GError *error
syncevo_service_get_sync_reports_async (service, data->current_service->name, 1,
(SyncevoGetSyncReportsCb)get_sync_reports_cb,
data);
g_ptr_array_foreach (options, (GFunc)syncevo_option_free, NULL);
g_ptr_array_free (options, TRUE);
}
static void

3
src/syncevo-dbus-server.cpp
View file

@ -333,9 +333,6 @@ void syncevo_report_array_get (SyncevoReportArray *array, int *end_time, GPtrArr
*end_time = g_value_get_int (g_value_array_get_nth (array, 0));
}
if (reports) {
/*
* how do I turn a gvalue into a gptrarray?
* */
*reports = (GPtrArray*)g_value_get_boxed (g_value_array_get_nth (array, 1));
}
}

1
syncevo-dbus/syncevo-dbus-types.c
View file

@ -281,7 +281,6 @@ void syncevo_report_array_get (SyncevoReportArray *array, int *end_time, GPtrArr
*end_time = g_value_get_int (g_value_array_get_nth (array, 0));
}
if (reports) {
/* does this really work ?*/
*reports = g_value_get_boxed (g_value_array_get_nth (array, 1));
}
}