maryjane/syncevolution
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

syncevo-http-server: better logging of D-Bus exceptions

Browse source 
Exceptions from syncevo-dbus-server which will also appear as error
message from that server need to be logged at debug level, to avoid
showing internal details like stack backtrace to users.

Also, the observer must *replace* the default logging instead of
adding itself. Done with startLoggingWithObserver().

The observer replaces the default logger. As a special case
This commit is contained in:
Patrick Ohly 2010-12-27 22:03:30 +01:00
parent dfc332debd
commit 99b53ec93d
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
test/syncevo-http-server.py
View file

@ -229,7 +229,15 @@ class TwistedLogging(object):
if 'logLevel' in eventDict:
level = eventDict['logLevel']
elif eventDict['isError']:
level = logging.ERROR
if 'failure' in eventDict and \
eventDict['failure'].type == dbus.exceptions.DBusException and \
eventDict['failure'].value.get_dbus_name() == "org.syncevolution.Exception":
# special case: errors inside the syncevo-dbus-server are better shown
# to users as part of the syncevo-dbus-server output, so treat the
# syncevo-http-server side of it as something for debugging.
level = logging.DEBUG
else:
level = logging.ERROR
else:
level = logging.DEBUG
text = twisted.python.log.textFromEventDict(eventDict)
@ -238,7 +246,7 @@ class TwistedLogging(object):
self.logger.log(level, text)
def start(self):
twisted.python.log.addObserver(self.emit)
twisted.python.log.startLoggingWithObserver(self.emit, setStdout=False)
def stop(self):
twisted.python.log.removeObserver(self.emit)