maryjane/syncevolution
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Folks: disable tests which never worked

Browse source 
The tests were originally added to test compilation of code written
against the proposed APIs. After implementing them it turned out that
creating FolksIndividual instances and setting properties is not
supported by libfolks
(https://bugzilla.gnome.org/show_bug.cgi?id=684557), and thus testing
like this is impossible.

Keeping the tests anyway, without running them, because perhaps such
testing becomes possible at some point (mock FolksIndividual?!) and
the tests still cover compilation against the APIs.
This commit is contained in:
Patrick Ohly 2012-09-24 12:34:33 +02:00
parent a044071e0c
commit d588e929e1
1 changed files with 29 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
src/dbus/server/pim/folks.cpp
View file

@ -208,8 +208,17 @@ class FolksTest : public CppUnit::TestFixture {
CPPUNIT_TEST(open);
CPPUNIT_TEST(asyncError);
CPPUNIT_TEST(gvalue);
CPPUNIT_TEST(fullview);
CPPUNIT_TEST(filter);
// The tests are not working because it is currently not possible
// to create FolksIndividual instances directly with some chosen
// properties. Testing the FullView and IndividualFilter thus must
// be done by putting real data into EDS and reading it via libfolks.
// See testpim.py.
// CPPUNIT_TEST(fullview);
// CPPUNIT_TEST(filter);
// aggregate() works, but doesn't do anything. Keeping it and the
// other two tests as compile test for the API.
CPPUNIT_TEST(aggregate);
CPPUNIT_TEST_SUITE_END();
@ -224,8 +233,24 @@ public:
FolksStructuredName *fn;
contact = FolksIndividualCXX::steal(folks_individual_new(NULL));
folks_name_details_set_full_name(FOLKS_NAME_DETAILS(contact.get()), "Abraham Zzz");
fn = folks_name_details_get_structured_name(FOLKS_NAME_DETAILS(contact.get()));
FolksNameDetails *nd = FOLKS_NAME_DETAILS(contact.get());
// Crashes due to bug in Vala:
// https://bugzilla.gnome.org/show_bug.cgi?id=684557
// GErrorCXX gerror;
// SYNCEVO_GLIB_CALL_SYNC(NULL, gerror,
// folks_name_details_change_full_name,
// nd,
// "Abraham Zzz");
// if (gerror) {
// gerror.throwError("folks_name_details_change_full_name(Abraham Zzz)");
// }
// Doesn't have any effect: without an associated store,
// properties in a FolksIndividual are not writable.
folks_name_details_set_full_name(nd, "Abraham Zzz");
fn = folks_name_details_get_structured_name(nd);
folks_structured_name_set_family_name(fn, "Zzz");
folks_structured_name_set_given_name(fn, "Abraham");
m_contactA = contact;