maryjane/syncevolution
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

WebDAV: handle 412 response to delete

Browse source 
Radicale reports 412 'Preconditiona Failed' instead of 404 when asked
to delete a non-existent item. Translate that into the 404 expected by
the Synthesis engine. Found when running Client::Source test against
Radicale 0.7-7-g186c59c.
This commit is contained in:
Patrick Ohly 2012-06-12 17:09:50 +02:00
parent 5e82815b5c
commit fdaf27f7e5
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/backends/webdav/WebDAVSource.cpp
View file

@ -1501,8 +1501,19 @@ void WebDAVSource::removeItem(const string &uid)
// TODO: match exactly the expected revision, aka ETag,
// or implement locking.
// req.addHeader("If-Match", etag);
if (req->run()) {
break;
try {
if (req->run()) {
break;
}
} catch (const TransportStatusException &ex) {
if (ex.syncMLStatus() == 412) {
// Radicale reports 412 'Precondition Failed'. Hmm, okay.
// Let's map it to the expected 404.
SE_THROW_EXCEPTION_STATUS(TransportStatusException,
"object not found (was 412 'Precondition Failed')",
SyncMLStatus(404));
}
throw;
}
}
SE_LOG_DEBUG(NULL, NULL, "remove item status: %s",