In this case it is fairly obvious that new_active and old_active
will both be set before use. There is no need for setting old_active
to FALSE. cppcheck warned about this.
Running a sync while the UI had no service selected caused a crash in
find_updated_source_progress() because the code dereferences the NULL
prog_data->data->current_service pointer. Affected both the GTK2 and
GTK3 UI.
Fix it by checking for NULL and not doing anything if NULL.
g_strcasecmp() was deprecated and produces warnings with later glib,
which is fatal with -Werror. The method is used to relax an equal
comparison of the config name. Config names are not case sensitive and
SyncEvolution is using a similar "to lower" approach, so relaxing the
comparison is okay, although it is uncertain why exactly it is
necessary and/or whether it catches all cases.
All strings are expected to be UTF-8, but because SyncEvolution only
does primitive lowercasing itself, calling g_ascii_strcasecmp() seems
like a better match than the full UTF-8 aware case handling methods in
glib.
The old ui.glade was still being referenced by the list of translatable
files. The corresponding files from the GTK3 version were missing.
automake doesn't seem to handle conditional _DATA files correctly. In contrast
to source files, they end up not being distributed when disabled. To solve
this, src/gtk*-ui/gtk-ui.am must be included unconditionally in src.am and
contain unconditional EXTRA_DIST entries for the two ui.xml files.
If the font size is large, the UI may end up overflowing horizontally
on small screens. Make sure that does not happen by limiting info
label size and setting proper expand/fill properties. Also set info
label font size in application css so we don't get nasty surprises
if default is massive.
* drawing rewrite for home made widgets
* size request rewrite for home made widgets
* don't use direct access to widget structs
* explicitly set expand to FALSE on some widgets
(children now inherit expand=TRUE)
* use gio to start bluetooth-wizard
* use GtkSwitch instead of MxGtkLightSwitch
(this needs to be done now as mx-gtk is not available for gtk3)
We want to support both GTK+-2.0 and GTK+-3.0 for the time being
(even if the former is just maintenance). This is not possible in
the same codebase without large amounts of ifdefs so we fork the UI.
