781e505c77
This patch started with the goal of changing the uint level into a string. The motivation for that was that the numeric constants would have to be documented (which they weren't) and prevent us from easily changing the Logger::Level later on. I did change them once today (see previous commit about reordering the SHOW level) and really had the problem that a not-restarted syncevo-dbus-server couldn't talk to a recompiled client. Using strings avoids that problem. While changing uint to string I had to make the change twice, once in an entirely unnecessary new and the pointer definition. Replaced the shared_ptr with normal members, throughout the code. Then I wondered about the use of the () operator on these signal watches. At the point of use it was not obvious what that did. Turns out that this activates the watch. In contrast to making a remote function call or emitting a signal, I find the use of the operator inappropriate for watches. Replaced with an explicit activate() method. While looking at the implementation, I found that this operator and destructors had been duplicated. Instead of fixing it in all copies, I moved the common code into a SignalWatch<> base template, parameterized with the type of callback that it deals with. |
||
|---|---|---|
| .. | ||
| interfaces | ||
| Makefile.am | ||
| README | ||
| syncevo-dbus-types.c | ||
| syncevo-dbus-types.h | ||
| syncevo-dbus.pc.in | ||
| syncevo-server.c | ||
| syncevo-server.h | ||
| syncevo-session.c | ||
| syncevo-session.h | ||
| test.c | ||
This is the C wrapper for the SyncEvolution DBus API. It is used by the GTK ui.