bf14e33977
This addresses two different warnings from Fedora Rawhide: /srv/runtests/work/sources/syncevolution/src/syncevo/SyncContext.cpp: In member function 'std::string SyncEvo::XMLFiles::get(SyncEvo::XMLFiles::Category)': /srv/runtests/work/sources/syncevolution/src/syncevo/SyncContext.cpp:2390:28: error: loop variable 'entry' of type 'const StringPair&' {aka 'const std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >&'} binds to a temporary constructed from type 'std::pair<const std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >' [-Werror=range-loop-construct] 2390 | for (const StringPair &entry: m_files[category]) { | ^~~~~ /srv/runtests/work/sources/syncevolution/src/syncevo/SyncContext.cpp:2390:28: note: use non-reference type 'const StringPair' {aka 'const std::pair<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >'} to make the copy explicit or 'const std::pair<const std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >&' to prevent copying This fails because StringPair has non-const members. By using "auto", we get rid of the need to define and pick exactly the right type. /srv/runtests/work/sources/syncevolution/src/syncevo/SyncConfig.cpp: In member function 'void SyncEvo::SyncConfig::removeSyncSource(const string&)': /srv/runtests/work/sources/syncevolution/src/syncevo/SyncConfig.cpp:2552:36: error: loop variable 'peer' creates a copy from type 'const string' {aka 'const std::__cxx11::basic_string<char>'} [-Werror=range-loop-construct] 2552 | for (const std::string peer: m_tree->getChildren(m_contextPath + "/peers")) { | ^~~~ /srv/runtests/work/sources/syncevolution/src/syncevo/SyncConfig.cpp:2552:36: note: use reference type to prevent copying 2552 | for (const std::string peer: m_tree->getChildren(m_contextPath + "/peers")) { | ^~~~ | & We could have used "auto" also instead of "std::string", but here it doesn't save that much typing and is more readable. We just have to use a reference. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com> |
||
---|---|---|
.. | ||
activesync | ||
akonadi | ||
evolution | ||
file | ||
gnome | ||
goa | ||
kcalextended | ||
kde | ||
maemo | ||
oauth2 | ||
pbap | ||
qtcontacts | ||
signon | ||
sqlite | ||
tde | ||
tdepim | ||
webdav | ||
xmlrpc |