eeded54cf4
The VALUE parameter was ignored completely and thus got lost in the Synthesis engine. Added it as a string. The TYPE parameter was an incomplete enum. Better allow arbitrary strings. Both parameters must be copied together with the PHOTO data they belong to. In combination with merge="fillempty" this can be problematic: if one of the parameters is empty, it may be overwritten although the PHOTO data is not copied. This problem is solved by ensuring that the internal field list never has empty PHOTO_TYPE/VALUE fields. This is done by setting "binary" resp. "unknown" when importing contact data from a peer or the local Evolution backend and removing them again before sending to a peer or storing. The same change needs to be done with other backends. It is not made mandatory because some backends (like file) might want to store these values explicitly. Because it is unknown which peers support VALUE=uri, only the CLIENT_TEST_SERVER=syncevolution testItem testcases contain a contact with such a PHOTO. |
||
|---|---|---|
| .. | ||
| backends | ||
| dbus | ||
| gdbus | ||
| gnome-bluetooth | ||
| gtk-ui | ||
| syncevo | ||
| synthesis-includes | ||
| templates | ||
| .cvsignore | ||
| .gitignore | ||
| async.patch | ||
| client-test-app.cpp | ||
| client-test-buteo.cpp | ||
| client-test-buteo.h | ||
| CmdlineSyncClient.cpp | ||
| CmdlineSyncClient.h | ||
| Makefile-gen.am | ||
| NotificationBackendBase.h | ||
| NotificationBackendLibnotify.cpp | ||
| NotificationBackendLibnotify.h | ||
| NotificationBackendMLite.cpp | ||
| NotificationBackendMLite.h | ||
| NotificationBackendNoop.cpp | ||
| NotificationBackendNoop.h | ||
| NotificationManager.cpp | ||
| NotificationManager.h | ||
| NotificationManagerBase.h | ||
| NotificationManagerFactory.cpp | ||
| NotificationManagerFactory.h | ||
| org.syncevolution.service.in | ||
| README.h | ||
| README.templates | ||
| shlibs.local | ||
| syncevo-dbus-server-startup.sh.in | ||
| syncevo-dbus-server.cpp | ||
| syncevo-dbus-server.desktop.in | ||
| syncevolution.cpp | ||
| valgrind.supp | ||
The configuration templates in "templates" get installed into $(datadir)/syncevolution/templates. When adding/changing a new server, then only enter the properties which need to be changed here so that the default values can be used for the remaining properties. An icon can be added here for servers. The file name must start with "icon". Server configurations must be kept in sync in three different places: - here (if a server is installed as files) - in SyncEvolutionConfig.cpp's EvolutionSyncConfig::createServerTemplate() - in SyncEvolutionCmdline.cpp's test server configs - in test/test-dbus.py testGetConfigsTemplates() Note that server icons must come with a suitable license that allows redistribution.